Skip to content

Commit e4bb1fd

Browse files
authored
Update lychee to latest version which really does verify link fragments (#2848)
1 parent a7d4b41 commit e4bb1fd

File tree

28 files changed

+64
-54
lines changed

28 files changed

+64
-54
lines changed

.github/scripts/lychee-config.toml

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,25 @@ include_fragments = true
22

33
accept = ["200..=299", "403"]
44

5+
remap = [
6+
# workaround for https://github.com/lycheeverse/lychee/issues/1729
7+
"https://github.com/(.*?)/(.*?)/blob/(.*?)/(.*#.*)$ https://raw.githubusercontent.com/$1/$2/$3/$4",
8+
"https://docs.oracle.com/(.*)#.*$ https://docs.oracle.com/$1",
9+
"https://www.ibm.com/docs/api/v1/content/SSYKE2_8.0.0/openj9/(.*)#.*$ https://www.ibm.com/docs/api/v1/content/SSYKE2_8.0.0/openj9/$1",
10+
"https://docs.docker.com/reference/(.*)#.*$ https://docs.docker.com/reference/$1",
11+
"https://javadoc.io/(.*)#.*$ https://javadoc.io/$1",
12+
"https://github.com/(.*)#issuecomment-.*$ https://github.com/$1",
13+
"https://github.com/(.*)#discussion_r.*$ https://github.com/$1",
14+
]
15+
516
exclude = [
6-
"^https://www.foo.bar",
7-
# excluding links to pull requests and issues is done for performance
8-
"^https://github.com/open-telemetry/semantic-conventions/(pull|issues)/\\d+$",
9-
"^https://github.com/open-telemetry/opentelemetry-specification/(pull|issues)/\\d+$",
10-
# TODO (lmolkova) treat timeout as not a failure?
11-
"^https://www.intersystems.com",
12-
"^https://gcc.gnu.org",
17+
"^https://www.foo.bar",
18+
# excluding links to pull requests and issues is done for performance
19+
"^https://github.com/open-telemetry/semantic-conventions/(pull|issues)/\\d+$",
20+
"^https://github.com/open-telemetry/opentelemetry-specification/(pull|issues)/\\d+$",
21+
# TODO (lmolkova) treat timeout as not a failure?
22+
"^https://www.intersystems.com",
23+
"^https://gcc.gnu.org",
1324
]
1425

1526
# better to be safe and avoid failures

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ the VCS metrics to include `vcs.repository.name` as a recommended attribute.
414414
### 🧰 Bug fixes 🧰
415415

416416
- `service`: Merge `resource` experimental and stable groups for service and telemetry.sdk (#1423)
417-
Discovered when fixing [weaver#306](https://github.com/open-telemetry/weaver/issues/306#issue-2458430277)
417+
Discovered when fixing [weaver#306](https://github.com/open-telemetry/weaver/issues/306)
418418

419419
- `db`: Fix telemetry for complex queries:
420420

dependencies.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ FROM otel/weaver:v0.18.0@sha256:5425ade81dc22ddd840902b0638b4b6a9186fb654c5b50c1
99
FROM openpolicyagent/opa:1.9.0@sha256:bd7e1216865884be8095726fb80282ece2f6b531883bc86f9f8917f2fc52de61 AS opa
1010

1111
# Lychee is used for checking links in documentation.
12-
FROM lycheeverse/lychee:sha-2aa22f8@sha256:2e3786630482c41f9f2dd081e06d7da1c36d66996e8cf6573409b8bc418d48c4 AS lychee
12+
FROM lycheeverse/lychee:sha-0a96dc2@sha256:2d397eb32e4add073deb5af328f7d644538cd62c007892c57b57551b073b6a12 AS lychee

docs/cicd/cicd-metrics.md

Lines changed: 9 additions & 9 deletions
Large diffs are not rendered by default.

docs/database/cosmosdb.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Batch operations:
7979
Bulk operations:
8080

8181
- `execute_bulk` SHOULD be used on spans reported for methods like
82-
[`executeBulkOperations`](https://javadoc.io/doc/com.azure/azure-cosmos/latest/com/azure/cosmos/CosmosAsyncContainer.html#executeBulkOperations)).
82+
[`executeBulkOperations`](https://javadoc.io/doc/com.azure/azure-cosmos/latest/com/azure/cosmos/CosmosAsyncContainer.html#executeBulkOperations(reactor.core.publisher.Flux)),
8383
which represents a bulk execution of multiple operations.
8484
- `bulk_{operation name}` (`bulk_create_item`, `bulk_upsert_item`, etc) SHOULD be used on spans describing individual operations (when they are reported)
8585
within the bulk. This pattern SHOULD be used when instrumentation creates span per each operation, but operations are buffered and then performed in bulk.

docs/exceptions/exceptions-logs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ emitted through the [Logger API](https://github.com/open-telemetry/opentelemetry
2121
## Recording an exception
2222

2323
Exceptions SHOULD be recorded as attributes on the
24-
[LogRecord](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#log-and-event-record-definition) passed to the [Logger](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.49.0/specification/logs/api.md#logger) emit
24+
[LogRecord](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#log-and-event-record-definition) passed to the [Logger](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/api.md#logger) emit
2525
operations. Exceptions MAY be recorded on "logs" or "events" depending on the
2626
context.
2727

docs/faas/faas-metrics.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ FaaS providers. This list is not exhaustive.
385385
* [AWS Lambda Metrics](https://docs.aws.amazon.com/lambda/latest/dg/monitoring-metrics.html)
386386
* [AWS Lambda Insight Metrics](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-metrics.html)
387387
* [Azure Functions Metrics](https://docs.microsoft.com/azure/azure-monitor/platform/metrics-supported)
388-
* [Google CloudFunctions Metrics](https://cloud.google.com/monitoring/api/metrics_gcp#gcp-cloudfunctions)
388+
* [Google CloudFunctions Metrics](https://cloud.google.com/monitoring/api/metrics_gcp)
389389
* [OpenFaas Metrics](https://docs.openfaas.com/architecture/metrics/)
390390

391391
[DocumentStatus]: https://opentelemetry.io/docs/specs/otel/document-status

docs/faas/faas-spans.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ The span attribute `faas.invocation_id` differs from the [resource attribute][Fa
121121

122122
[AWS lambda]: https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
123123
[Azure functions]: https://docs.microsoft.com/azure/azure-functions/manage-connections#static-clients
124-
[Google functions]: https://cloud.google.com/functions/docs/concepts/execution-environment#scope
124+
[Google functions]: https://cloud.google.com/functions/docs/concepts/execution-environment
125125

126126
## Incoming invocations
127127

docs/feature-flags/feature-flags-events.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ This can be used to determine the impact a feature has on a request, enabling en
2626

2727
## Recording an evaluation
2828

29-
Feature flag evaluations SHOULD be recorded as attributes on the [Event](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#events) passed to the [Logger](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.49.0/specification/logs/api.md#logger) emit operations.
29+
Feature flag evaluations SHOULD be recorded as attributes on the [Event](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#events) passed to the [Logger](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/api.md#logger) emit operations.
3030

3131
> Note:
3232
> Events are in-development and not yet available in some languages. Check the [spec-compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/spec-compliance-matrix.md#logs) to see the implementation status in the corresponding language.

docs/general/events.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ with attributes and the type of the body if any.
2626
that uniquely identifies the event. Event names are subject to the [Naming guidelines](/docs/general/naming.md). Event name SHOULD be of a low-cardinality.
2727
* Events MAY have [attributes](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#field-attributes)
2828
that provide additional context about the event.
29-
* Events MAY contain a [body](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#field-body) of type [`any`](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.49.0/specification/logs/data-model.md#type-any).
29+
* Events MAY contain a [body](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#field-body) of type [`any`](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#type-any).
3030
* The event name uniquely identifies event structure: the set of attributes and
3131
the type of the body.
3232
* Events MAY have [severity number](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/specification/logs/data-model.md#field-severitynumber).

0 commit comments

Comments
 (0)