Fix metric.v8js.memory.heap.space.physical_size and metric.v8js.memory.heap.space.available_size metric names (#2856)

Author: maryliag

.chloggen/update-v8js-metrics.yaml

@@ -0,0 +1,19 @@
+# Use this changelog template to create an entry for release notes.
+#
+# If your change doesn't affect end users you should instead start
+# your pull request title with [chore] or use the "Skip Changelog" label.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
+component: v8js
+
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: |
+  Rename metric `v8js.heap.space.available_size` to `v8js.memory.heap.space.available_size`.
+  Rename metric `v8js.heap.space.physical_size` to `v8js.memory.heap.space.physical_size`.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+# The values here must be integers.
+issues: [2856]

docs/runtime/v8js-metrics.md

@@ -13,8 +13,8 @@ This document describes semantic conventions for V8 JS Engine Runtime metrics in
 - [Metric: `v8js.gc.duration`](#metric-v8jsgcduration)
 - [Metric: `v8js.memory.heap.limit`](#metric-v8jsmemoryheaplimit)
 - [Metric: `v8js.memory.heap.used`](#metric-v8jsmemoryheapused)
-- [Metric: `v8js.heap.space.available_size`](#metric-v8jsheapspaceavailable_size)
-- [Metric: `v8js.heap.space.physical_size`](#metric-v8jsheapspacephysical_size)
+- [Metric: `v8js.memory.heap.space.available_size`](#metric-v8jsmemoryheapspaceavailable_size)
+- [Metric: `v8js.memory.heap.space.physical_size`](#metric-v8jsmemoryheapspacephysical_size)
 
 <!-- tocstop -->
 
@@ -141,11 +141,11 @@ This metric is [recommended][MetricRecommended].
 <!-- END AUTOGENERATED TEXT -->
 <!-- endsemconv -->
 
-## Metric: `v8js.heap.space.available_size`
+## Metric: `v8js.memory.heap.space.available_size`
 
 This metric is [recommended][MetricRecommended].
 
-<!-- semconv metric.v8js.heap.space.available_size -->
+<!-- semconv metric.v8js.memory.heap.space.available_size -->
 <!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
 <!-- see templates/registry/markdown/snippet.md.j2 -->
 <!-- prettier-ignore-start -->
@@ -154,7 +154,7 @@ This metric is [recommended][MetricRecommended].
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `v8js.heap.space.available_size` | UpDownCounter | `By` | Heap space available size. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `v8js.memory.heap.space.available_size` | UpDownCounter | `By` | Heap space available size. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Value can be retrieved from value `space_available_size` of [`v8.getHeapSpaceStatistics()`](https://nodejs.org/api/v8.html#v8getheapspacestatistics)
 
@@ -181,11 +181,11 @@ This metric is [recommended][MetricRecommended].
 <!-- END AUTOGENERATED TEXT -->
 <!-- endsemconv -->
 
-## Metric: `v8js.heap.space.physical_size`
+## Metric: `v8js.memory.heap.space.physical_size`
 
 This metric is [recommended][MetricRecommended].
 
-<!-- semconv metric.v8js.heap.space.physical_size -->
+<!-- semconv metric.v8js.memory.heap.space.physical_size -->
 <!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
 <!-- see templates/registry/markdown/snippet.md.j2 -->
 <!-- prettier-ignore-start -->
@@ -194,7 +194,7 @@ This metric is [recommended][MetricRecommended].
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `v8js.heap.space.physical_size` | UpDownCounter | `By` | Committed size of a heap space. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `v8js.memory.heap.space.physical_size` | UpDownCounter | `By` | Committed size of a heap space. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Value can be retrieved from value `physical_space_size` of [`v8.getHeapSpaceStatistics()`](https://nodejs.org/api/v8.html#v8getheapspacestatistics)
 

model/v8js/deprecated/metrics-deprecated.yaml

@@ -0,0 +1,33 @@
+groups:
+  - id: metric.v8js.heap.space.available_size
+    type: metric
+    metric_name: v8js.heap.space.available_size
+    deprecated:
+      reason: renamed
+      renamed_to: v8js.memory.heap.space.available_size
+    annotations:
+      code_generation:
+        metric_value_type: int
+    brief: "Deprecated, use `v8js.memory.heap.space.available_size` instead."
+    instrument: updowncounter
+    unit: "By"
+    stability: development
+    attributes:
+      - ref: v8js.heap.space.name
+        requirement_level: required
+  - id: metric.v8js.heap.space.physical_size
+    type: metric
+    metric_name: v8js.heap.space.physical_size
+    deprecated:
+      reason: renamed
+      renamed_to: v8js.memory.heap.space.physical_size
+    annotations:
+      code_generation:
+        metric_value_type: int
+    brief: "Deprecated, use `v8js.memory.heap.space.physical_size` instead."
+    instrument: updowncounter
+    unit: "By"
+    stability: development
+    attributes:
+      - ref: v8js.heap.space.name
+        requirement_level: required

model/v8js/metrics.yaml

@@ -49,9 +49,9 @@ groups:
       The value can be retrieved from value `space_used_size` of
       [`v8.getHeapSpaceStatistics()`](https://nodejs.org/api/v8.html#v8getheapspacestatistics)
 
-  - id: metric.v8js.heap.space.available_size
+  - id: metric.v8js.memory.heap.space.available_size
     type: metric
-    metric_name: v8js.heap.space.available_size
+    metric_name: v8js.memory.heap.space.available_size
     annotations:
       code_generation:
         metric_value_type: int
@@ -65,9 +65,9 @@ groups:
     note: >
       Value can be retrieved from value `space_available_size` of [`v8.getHeapSpaceStatistics()`](https://nodejs.org/api/v8.html#v8getheapspacestatistics)
 
-  - id: metric.v8js.heap.space.physical_size
+  - id: metric.v8js.memory.heap.space.physical_size
     type: metric
-    metric_name: v8js.heap.space.physical_size
+    metric_name: v8js.memory.heap.space.physical_size
     annotations:
       code_generation:
         metric_value_type: int