[chore] Show deprecated enum members in docs #2496 #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
3 times, most recently
from
dfdf35b to
ec3043b
Compare
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
from
ec3043b to
1d7497a
Compare
|
I'm not sure if this is a good thing, for similar reasoning as #2607 (comment) |
|
The problem is no where at all is the deprecation reason visible. For attributes you atleast have the attribute registry to get that information. |
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
2 times, most recently
from
55e3371 to
3abbe81
Compare
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
3 times, most recently
from
d1e9655 to
74e0c8c
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
from
74e0c8c to
55f4bd5
Compare
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
from
508a80f to
8566d04
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
thompson-tomo
force-pushed
the
chore/#2496_ShowDeprecatedEnumMembers
branch
from
8566d04 to
b2b4842
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2496
Changes
Have the documentation tables to now include deprecated members to assist with transition etc. At the same time if the attribute is deprecated, the enum table will be rendered the same as if the member was deprecated but the deprecation reason now also states the attribute to use.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]