-
Notifications
You must be signed in to change notification settings - Fork 278
Add gen_ai _ref attributes for referencing external uploaded content
#2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adapted from 092db44 Co-authored-by: Liudmila Molkova <[email protected]>
_ref blob reference attributes_ref attributes for referencing external uploaded content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do support this version, just wanted to bring up the reasoning we pushed it away from #2179.
I believe we got stuck on the following question: should we record content on parts in external storage or record the whole json there.
My preference is on recording the whole thing with the following arguments:
- it's easier and faster (when it comes to P95, more reliable) to upload and download one reasonably sized (megabytes) object than N of smaller ones. Creating an object/blob is time-consuming operation on its own
- input, output, instructions object are not useful without the content and part's content output is not useful without roles/structure. So when string/binary content is uploaded, but the rest of the message content is not, all consumers always need to do smart joins on the telemetry and object store data.
- someone who wants to upload individual contents per part can still do so
Leaving it as a comment and not approval only to hear feedback.
But this will be less useful to do if there isn't a semconv for uploads per part. So this argument doesn't work for me unless we think we might define conventions for both versions. The ideal I’m imagining for a ref for each part looks like this:
|
|
Converting to draft - would like to have some end-to-end impl to proceed |
Fixes #2753
Changes
Introduces reference attributes that were held back from #2179 (092db44):
gen_ai.system_instructions_refgen_ai.input.messages_refgen_ai.output.messages_refThis makes uploading references to external storage more normative
Prototypes
opentelemetry-instrumentation-google-genai.Merge requirement checklist
[chore]