-
Notifications
You must be signed in to change notification settings - Fork 282
Add Pressure Stall Information (PSI) metrics #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
braydonk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't submit the review last night.
a98d71f to
8af31d2
Compare
|
Is there anything else I can or should do to get this PR merged? |
# Conflicts: # docs/system/system-metrics.md
Co-authored-by: James Thompson <[email protected]>
thompson-tomo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should also be confirmed if the metrics should be renamed to system.psi.linux.* to follow the changes made in #2984
Any updates on whether this should be changed? |
This won't be necessary for |
@braydonk currently this is not being followed as the metrics are currently named |
Co-authored-by: James Thompson <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Please update your commit message(s) by doing |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
Wrong rebase order 🙈 |
|
There are still issues with the rebase, as I see changes on the |
|
"Files changed" tab in this PR no longer updates changes as PR was closed. Actual changes can be seen here: main...alpineQ:semantic-conventions:main I can open a new PR if this will help with the issue |
I was mixed up when I said this.
We should do the inverse of this; the attributes should be changed to
|
|
Ah ok, then attributes should be renamed. I am aware of that guidance which is what prompted my suggestion to rename as I was seeing psi as the area of concern just like memory. Might be worthwhile to update that doc to define what the area of concern and encorporate terminology about diverging. |
|
I think that's what this last line is intending to say, perhaps could be worded better:
|
Closes #2995
Changes
This PR adds support for Linux Pressure Stall Information (PSI) metrics to the system semantic conventions.
PSI is a Linux kernel feature (available since kernel 4.20) that identifies and quantifies resource contention by measuring the time impact that CPU, memory, and I/O resource crunches have on workloads.
New Metrics
system.linux.psi.pressure(Gauge): Measures resource pressure as a percentage of time that tasks were stalled over a time window (10s, 60s, or 300s)system.linux.psi.total_time(Counter): Tracks the total cumulative stall time in microseconds since system bootNew Attributes
system.psi.resource: The resource type (cpu,memory,io)system.psi.stall_type: The stall severity (somefor partial stalls,fullfor complete stalls where all non-idle tasks are blocked)system.psi.window: The time window for pressure calculation (10s,60s,300s)Use Cases
PSI metrics enable:
References
Relevant issues and PRs
There are issues on this matter in:
And 2 PRs that I am proposing to address these issues:
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]