Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Oct 30, 2025

Progresses #189

Changes

This ensures that lists use - as opposed to * as per prettier recommendations.

Note all pages which have a toc also require - to be list symbol.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@github-actions
Copy link

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Oct 30, 2025

Note lint issue will be addressed with #3010 / #3014

@thompson-tomo thompson-tomo force-pushed the editoral/#189_StandardiseListSymbol branch 2 times, most recently from 534e304 to b6d584b Compare November 12, 2025 04:36
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe there is a consensus on #189. this chance does not seem to be beneficial and enforcing it seems to bring more harm then good

@thompson-tomo
Copy link
Contributor Author

@lmolkova this is important not just for code formatting but also linting which also enforces that a single style is used within a single page. This gets more difficult to mantain when we are also linting dynamically generated content. Also consider that any page which has a TOC needs to use - for the list symbol.

@thompson-tomo thompson-tomo force-pushed the editoral/#189_StandardiseListSymbol branch from 12ffb0f to 3a45092 Compare November 22, 2025 02:09
- [`ThreadMXBean#getAllThreadIds()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html#getAllThreadIds--)
- [`ThreadMXBean#getThreadInfo()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html#getThreadInfo-long:A-)
- [`ThreadInfo#getThreadState()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadInfo.html#getThreadState--)
- [`ThreadInfo#isDaemon()`](<https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/ThreadInfo.html#isDaemon()>) (requires Java 9+)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [`ThreadInfo#isDaemon()`](<https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/ThreadInfo.html#isDaemon()>) (requires Java 9+)
- [`ThreadInfo#isDaemon()`](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/ThreadInfo.html#isDaemon()) (requires Java 9+)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is done to easily regex the url when the url contains ), also is valid markdown syntax.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just because its valid markdown syntax is a different question from whether we need this more complex syntax

let's simplify it for now until we have a specific need for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have changed it back.

@thompson-tomo thompson-tomo force-pushed the editoral/#189_StandardiseListSymbol branch from 3a45092 to cd9ea74 Compare November 23, 2025 02:36
@thompson-tomo thompson-tomo force-pushed the editoral/#189_StandardiseListSymbol branch from cd9ea74 to 5e2ec3b Compare November 23, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants