Skip to content

[chore] Exclude chore PRs from ownership checks, trigger checks on edits and labeling #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2025
Merged

[chore] Exclude chore PRs from ownership checks, trigger checks on edits and labeling #3109

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f646f41
Exclude chore PRs from ownership checks
lmolkova Nov 22, 2025
c6886c4
Merge branch 'main' into allow-chore-prs-on-all-areas
lmolkova Nov 24, 2025
265495d
trigger ownership check on PR edits and labeling
lmolkova Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/scripts/triage/check-changes-ownership.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,23 @@ const prNumber: number = +process.env.PR_NUMBER!;
const changes: string[] = process.env.CHANGED_FILES!.split(',');

/**
* Checks if the PR already has the 'triage:accepted:ready' label, meaning the triage checks should be skipped.
* @returns true if the PR has the 'triage:accepted:ready' assigned to it, false otherwise.
* Checks if the PR already has the 'triage:accepted:ready' or 'triage:accepted:ready-with-sig' label, meaning the triage checks should be skipped.
* Also checks if the PR title starts with '[chore]' which indicates a maintenance PR that should skip checks.
* @returns true if the PR has the 'triage:accepted:ready' or 'triage:accepted:ready-with-sig' label or title starts with '[chore]', false otherwise.
*/
async function shouldSkipCheck() {
const result = await octokit.request("GET /repos/{owner}/{repo}/issues/{issue_number}/labels", {
const result = await octokit.request("GET /repos/{owner}/{repo}/issues/{issue_number}", {
owner: owner,
repo: repo,
issue_number: prNumber
});

return result.data.some(l => l.name === "triage:accepted:ready");
const hasAcceptedLabel = result.data.labels?.some(l =>
l.name === "triage:accepted:ready" || l.name === "triage:accepted:ready-with-sig"
) ?? false;
const isChore = result.data.title.toLowerCase().startsWith('[chore]');

return hasAcceptedLabel || isChore;
}

function getCommentText(changesWithoutOwners: string[]): string {
Expand Down
Loading