Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Dec 6, 2024

No description provided.

@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (4cb5868) to head (fed8edc).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #510   +/-   ##
=====================================
  Coverage   73.9%   73.9%           
=====================================
  Files         50      50           
  Lines       3911    3911           
=====================================
  Hits        2894    2894           
  Misses      1017    1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask trask marked this pull request as ready for review December 6, 2024 03:52
@trask trask requested a review from a team as a code owner December 6, 2024 03:52
if ctx.add_old_style_paragraph {
ctx.pushln(indent)?;
if !matches!(md_node, Node::List(_)) {
if matches!(md_node, Node::Paragraph(_)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why I didn't think of this in #474

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit c5c66ba into open-telemetry:main Dec 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants