bluetooth: Fix resource leak issue.

jialu522 · hyson710 · commit 6c9dc5503b50 · 2025-12-20T12:56:06.000+08:00
bug: v/80614

When the family is not AF_LOCAL or AF_RPMSG, the function returns immediately without freeing the memory allocated for 'priv', leading to a memory leak.

Signed-off-by: jialu &lt;jialu@xiaomi.com&gt;
diff --git a/service/ipc/socket/src/bt_socket_client.c b/service/ipc/socket/src/bt_socket_client.c
@@ -715,6 +715,7 @@ int bt_socket_async_client_init(bt_instance_t* ins, uv_loop_t* loop, int family,
 {
     int ret;
     bt_socket_async_client_t* priv;
+    bt_status_t status = BT_STATUS_FAIL;
 
     if (ins == NULL || loop == NULL)
         return BT_STATUS_PARM_INVALID;
@@ -757,7 +758,8 @@ int bt_socket_async_client_init(bt_instance_t* ins, uv_loop_t* loop, int family,
         }
 #endif
         else {
-            return BT_STATUS_NOT_SUPPORTED;
+            status = BT_STATUS_NOT_SUPPORTED;
+            goto fail;
         }
     }
 
@@ -766,7 +768,7 @@ int bt_socket_async_client_init(bt_instance_t* ins, uv_loop_t* loop, int family,
     return BT_STATUS_SUCCESS;
 fail:
     bt_socket_async_client_deinit(ins);
-    return BT_STATUS_FAIL;
+    return status;
 }
 
 static void bt_socket_invoke_async_cb(bt_instance_t* ins, bt_list_t* list)

Original file line number	Diff line number	Diff line change
`@@ -715,6 +715,7 @@ int bt_socket_async_client_init(bt_instance_t* ins, uv_loop_t* loop, int family,`
`715`	`715`	`{`
`716`	`716`	`int ret;`
`717`	`717`	`bt_socket_async_client_t* priv;`
	`718`	`+ bt_status_t status = BT_STATUS_FAIL;`
`718`	`719`
`719`	`720`	`if (ins == NULL \|\| loop == NULL)`
`720`	`721`	`return BT_STATUS_PARM_INVALID;`
`@@ -757,7 +758,8 @@ int bt_socket_async_client_init(bt_instance_t* ins, uv_loop_t* loop, int family,`
`757`	`758`	`}`
`758`	`759`	`#endif`
`759`	`760`	`else {`
`760`		`- return BT_STATUS_NOT_SUPPORTED;`
	`761`	`+ status = BT_STATUS_NOT_SUPPORTED;`
	`762`	`+ goto fail;`
`761`	`763`	`}`
`762`	`764`	`}`
`763`	`765`
`@@ -766,7 +768,7 @@ int bt_socket_async_client_init(bt_instance_t* ins, uv_loop_t* loop, int family,`
`766`	`768`	`return BT_STATUS_SUCCESS;`
`767`	`769`	`fail:`
`768`	`770`	`bt_socket_async_client_deinit(ins);`
`769`		`- return BT_STATUS_FAIL;`
	`771`	`+ return status;`
`770`	`772`	`}`
`771`	`773`
`772`	`774`	`static void bt_socket_invoke_async_cb(bt_instance_t* ins, bt_list_t* list)`