Merge pull request #35 from open-wc/fix/events-bug

fix: event name bug

Author: thepassle

packages/analyzer/browser/index.js

@@ -9,35 +9,32 @@
         {
           "kind": "class",
           "description": "",
-          "name": "CustomElementSchemaViewerElement",
+          "name": "MyElement",
           "members": [
             {
-              "kind": "field",
-              "name": "src",
-              "description": "Any valid path to load a JSON file that adheres to the custom element manifest schema: https://github.com/webcomponents/custom-elements-manifest/"
+              "kind": "method",
+              "name": "myMethod"
+            }
+          ],
+          "events": [
+            {
+              "type": {
+                "text": "MyCustomEvent"
+              }
             }
           ],
           "superclass": {
             "name": "LitElement"
           },
-          "tagName": "customelement-schema-viewer",
           "customElement": true
         }
       ],
       "exports": [
         {
           "kind": "js",
-          "name": "CustomElementSchemaViewerElement",
-          "declaration": {
-            "name": "CustomElementSchemaViewerElement",
-            "module": "fixtures/-default/package/bar.js"
-          }
-        },
-        {
-          "kind": "custom-element-definition",
-          "name": "customelement-schema-viewer",
+          "name": "MyElement",
           "declaration": {
-            "name": "CustomElementSchemaViewerElement",
+            "name": "MyElement",
             "module": "fixtures/-default/package/bar.js"
           }
         }

packages/analyzer/custom-elements.json

@@ -1,7 +1,18 @@
-@customElement("customelement-schema-viewer")
-export class CustomElementSchemaViewerElement extends LitElement {
-  /**
-   * Any valid path to load a JSON file that adheres to the custom element manifest schema: {@link https://github.com/webcomponents/custom-elements-manifest/}
-   */
-  src;
-}
+
+import { LitElement } from 'lit';
+
+/**
+ * Some information here.
+ */
+class MyCustomEvent extends CustomEvent {
+  constructor(eventInit) {
+    super('my-custom-event', eventInit);
+  }
+}
+
+export class MyElement extends LitElement {
+  myMethod() {
+      // FAILS HERE because no `type` argument is being passed to `MyCustomEvent`.
+      this.dispatchEvent(new MyCustomEvent());
+  }
+}

packages/analyzer/fixtures/-default/package/bar.js

@@ -1,6 +1,6 @@
 {
   "name": "@custom-elements-manifest/analyzer",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "",
   "license": "MIT",
   "type": "module",

packages/analyzer/package.json

@@ -151,16 +151,16 @@ function eventsVisitor(source, classTemplate) {
         if (isDispatchEvent(node)) {
           node?.arguments?.forEach((arg) => {
             if (arg.kind === ts.SyntaxKind.NewExpression) {
-              const eventName = arg.arguments[0].text;
-
+              /** e.g. `selected-changed` */
+              const eventName = arg?.arguments?.[0]?.text;
               /**
                * Check if event already exists
                */
               const eventExists = classTemplate?.events?.some(event => event.name === eventName);
 
               if(!eventExists) {
                 let eventDoc = {
-                  name: eventName,
+                  ...(eventName ? {name: eventName} : {}),
                   type: {
                     text: arg.expression.text,
                   },