try fix release build (#357)

* fix release build

* add release build test in ci

* ci release

* fix space

* format

* fix

* fix

* fix build

* fix tests

Author: qiweiii

.github/workflows/ci.yml

@@ -23,9 +23,12 @@ jobs:
         args: --config .swiftlint.yml --strict
 
   test:
-    name: Build and Test
+    name: Build and Test (${{ matrix.config }})
     runs-on: [self-hosted, linux]
-    timeout-minutes: 30
+    timeout-minutes: 40
+    strategy:
+      matrix:
+        config: [debug, release]
     steps:
     - name: Checkout Code
       uses: actions/checkout@v4
@@ -42,8 +45,9 @@ jobs:
       uses: runs-on/cache@v4
       with:
         path: '**/.build'
-        key: ${{ runner.os }}-spm-${{ hashFiles('**/Package.resolved') }}
+        key: ${{ runner.os }}-spm-${{ matrix.config }}-${{ hashFiles('**/Package.resolved') }}
         restore-keys: |
+          ${{ runner.os }}-spm-${{ matrix.config }}-
           ${{ runner.os }}-spm-
       env:
         RUNS_ON_S3_BUCKET_CACHE: laminar-gh-action-cache
@@ -87,6 +91,17 @@ jobs:
     - name: Check rust format
       run: cargo +nightly fmt --all -- --check
     - name: Build
-      run: make build
+      run: |
+        if [ "${{ matrix.config }}" = "release" ]; then
+          make deps
+          ./scripts/run.sh build -c release -Xswiftc -enable-testing -Xswiftc -Onone -Xswiftc -whole-module-optimization -Xswiftc -package-cmo -Xswiftc -unavailable-decl-optimization=complete
+        else
+          make build
+        fi
     - name: Test
-      run: make test-all
+      run: |
+        if [ "${{ matrix.config }}" = "release" ]; then
+          ./scripts/runTests.sh test -c release -Xswiftc -enable-testing -Xswiftc -Onone -Xswiftc -whole-module-optimization -Xswiftc -package-cmo -Xswiftc -unavailable-decl-optimization=complete
+        else
+          make test-all
+        fi

Blockchain/Sources/Blockchain/RuntimeProtocols/Safrole.swift

@@ -257,10 +257,8 @@ extension Safrole {
             let validatorQueueWithoutOffenders = withoutOffenders(offenders: offenders, validators: validatorQueue)
 
             let newCommitment = {
-                try Bandersnatch.RingCommitment(
-                    ring: validatorQueueWithoutOffenders.map { try? Bandersnatch.PublicKey(data: $0.bandersnatch) },
-                    ctx: ctx
-                ).data
+                let ring = validatorQueueWithoutOffenders.map { try? Bandersnatch.PublicKey(data: $0.bandersnatch) }
+                return try withExtendedLifetime(ring) { try Bandersnatch.RingCommitment(ring: ring, ctx: ctx).data }
             }
             let verifier = Bandersnatch.Verifier(ctx: ctx, commitment: commitment)
 

Utils/Tests/UtilsTests/DebugCheckTests.swift

@@ -16,18 +16,20 @@ struct DebugCheckTests {
 
     @Test
     func testDebugCheck() async throws {
-        try #expect(doesThrow {
-            try debugCheck(1 + 1 == 2)
-        } == true)
-        #expect(throws: DebugCheckError.self) {
-            try debugCheck(1 + 1 == 3)
-        }
-        try await #expect(awaitThrow {
-            try await debugCheck(1 + 1 == 2)
-        } == true)
+        #if DEBUG_ASSERT
+            try #expect(doesThrow {
+                try debugCheck(1 + 1 == 2)
+            } == true)
+            #expect(throws: DebugCheckError.self) {
+                try debugCheck(1 + 1 == 3)
+            }
+            try await #expect(awaitThrow {
+                try await debugCheck(1 + 1 == 2)
+            } == true)
 
-        await #expect(throws: DebugCheckError.self) {
-            try await debugCheck(1 + 1 == 3)
-        }
+            await #expect(throws: DebugCheckError.self) {
+                try await debugCheck(1 + 1 == 3)
+            }
+        #endif
     }
 }

scripts/release.Dockerfile

@@ -17,7 +17,7 @@ RUN make deps
 
 WORKDIR /boka/Boka
 
-RUN swift build -c release -Xswiftc -Onone -Xswiftc -whole-module-optimization -Xswiftc -package-cmo -Xswiftc -unavailable-decl-optimization=complete
+RUN swift build -c release  -Xswiftc -Onone -Xswiftc -whole-module-optimization -Xswiftc -package-cmo -Xswiftc -unavailable-decl-optimization=complete
 
 RUN cp $(swift build --show-bin-path -c release)/Boka /boka/boka-bin