Skip to content

Extend nomination pools E2E tests#569

Merged
rockbmb merged 17 commits intomasterfrom
nomination-pools-e2e
Apr 5, 2026
Merged

Extend nomination pools E2E tests#569
rockbmb merged 17 commits intomasterfrom
nomination-pools-e2e

Conversation

@rockbmb
Copy link
Copy Markdown
Collaborator

@rockbmb rockbmb commented Mar 20, 2026

Closes #257 .

@rockbmb rockbmb added this to the Advanced CUI/CUJ Coverage milestone Mar 20, 2026
@rockbmb rockbmb self-assigned this Mar 20, 2026
@rockbmb rockbmb added enhancement New feature or request e2e tests Related to end-to-end tests labels Mar 20, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduce two new test cases for nomination pools, covering unbonding and slashing scenarios. The logic is generally sound, but there is a potential for numeric precision loss in one of the tests when manipulating storage.

@rockbmb rockbmb enabled auto-merge (squash) April 4, 2026 17:42
rockbmb added 2 commits April 5, 2026 11:21
When choosing a nonexistent bounty's index, it was assumed that
such a count would never reach 1000; it is now at over 7000,
as there has been a spam attempt on PAH, which broke tests.
@rockbmb rockbmb merged commit 2cca592 into master Apr 5, 2026
7 checks passed
@rockbmb rockbmb deleted the nomination-pools-e2e branch April 5, 2026 12:29
@rockbmb
Copy link
Copy Markdown
Collaborator Author

rockbmb commented Apr 5, 2026

Found bifrost-io/bifrost#2083 through this; Bifrost Kusama accounts E2E test snapshots began failing in CI in this PR; see 1b5ef6e .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e tests Related to end-to-end tests enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve nomination pool tests

2 participants