Fix a compatibility issue with old clients. (#584)

jianjunz · web-flow · commit 07823094dd87 · 2023-07-04T13:39:19.000+08:00
Old clients don't have connection Id. Disable perfect negotiation if remote
client is not supported.
diff --git a/src/sdk/p2p/p2pclient.js b/src/sdk/p2p/p2pclient.js
@@ -100,7 +100,7 @@ const P2PClient = function(configuration, signalingChannel) {
           ErrorModule.errors.P2P_CLIENT_DENIED);
       return;
     }
-    if (connectionIds.has(origin) &&
+    if (connectionIds.has(origin) && connectionId &&
         connectionIds.get(origin) !== connectionId && !isPolitePeer(origin)) {
       Logger.warning(
           // eslint-disable-next-line max-len

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ const P2PClient = function(configuration, signalingChannel) {`
`100`	`100`	`ErrorModule.errors.P2P_CLIENT_DENIED);`
`101`	`101`	`return;`
`102`	`102`	`}`
`103`		`- if (connectionIds.has(origin) &&`
	`103`	`+ if (connectionIds.has(origin) && connectionId &&`
`104`	`104`	`connectionIds.get(origin) !== connectionId && !isPolitePeer(origin)) {`
`105`	`105`	`Logger.warning(`
`106`	`106`	`// eslint-disable-next-line max-len`