Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Commit ee75c64

Browse files
committed
Revert "Revert "Allow video codec preference when publishing with RTCRtpEncodingParameters.""
This reverts commit ea2f536.
1 parent ba0a843 commit ee75c64

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/sdk/base/publication.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,14 +186,14 @@ export class PublishOptions {
186186
* @member {?Array<Owt.Base.AudioEncodingParameters> | ?Array<RTCRtpEncodingParameters>} audio
187187
* @instance
188188
* @memberof Owt.Base.PublishOptions
189-
* @desc Parameters for audio RtpSender.
189+
* @desc Parameters for audio RtpSender. Publishing with RTCRtpEncodingParameters is an experimental feature. It is subject to change.
190190
*/
191191
this.audio = audio;
192192
/**
193193
* @member {?Array<Owt.Base.VideoEncodingParameters> | ?Array<RTCRtpEncodingParameters>} video
194194
* @instance
195195
* @memberof Owt.Base.PublishOptions
196-
* @desc Parameters for video RtpSender.
196+
* @desc Parameters for video RtpSender. Publishing with RTCRtpEncodingParameters is an experimental feature. It is subject to change.
197197
*/
198198
this.video = video;
199199
/**

src/sdk/conference/channel.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class ConferencePeerConnectionChannel extends EventDispatcher {
3636
this._config = config;
3737
this._videoCodecs = undefined;
3838
this._options = null;
39+
this._videoCodecs = undefined;
3940
this._signaling = signaling;
4041
this._pc = null;
4142
this._internalId = null; // It's publication ID or subscription ID.

src/sdk/conference/client.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,9 +419,10 @@ export const ConferenceClient = function(config, signalingImpl) {
419419
* @desc Publish a LocalStream to conference server. Other participants will be able to subscribe this stream when it is successfully published.
420420
* @param {Owt.Base.LocalStream} stream The stream to be published.
421421
* @param {Owt.Base.PublishOptions} options Options for publication.
422+
* @param {string[]} videoCodecs Video codec names for publishing. Valid values are 'VP8', 'VP9' and 'H264'. This parameter only valid when options.video is RTCRtpEncodingParameters. Publishing with RTCRtpEncodingParameters is an experimental feature. This parameter is subject to change.
422423
* @return {Promise<Publication, Error>} Returned promise will be resolved with a newly created Publication once specific stream is successfully published, or rejected with a newly created Error if stream is invalid or options cannot be satisfied. Successfully published means PeerConnection is established and server is able to process media data.
423424
*/
424-
this.publish = function(stream, options) {
425+
this.publish = function(stream, options, videoCodecs) {
425426
if (!(stream instanceof StreamModule.LocalStream)) {
426427
return Promise.reject(new ConferenceError('Invalid stream.'));
427428
}

0 commit comments

Comments
 (0)