Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Commit 16ad48f

Browse files
authored
Fix linux build issue after upgrading to M88. (#522)
1 parent 2dd5e6a commit 16ad48f

File tree

7 files changed

+15
-14
lines changed

7 files changed

+15
-14
lines changed

scripts/build_linux.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
def gen_lib_path(scheme):
4646
out_lib = OUT_LIB % {'scheme': scheme}
47-
return os.path.join(r'out', out_lib)
47+
return os.path.join(HOME_PATH + r'/out', out_lib)
4848

4949
def gngen(arch, ssl_root, msdk_root, quic_root, scheme, tests, use_gcc, fake_audio):
5050
gn_args = list(GN_ARGS)
@@ -101,7 +101,9 @@ def gngen(arch, ssl_root, msdk_root, quic_root, scheme, tests, use_gcc, fake_aud
101101
return False
102102

103103
def getoutputpath(arch, scheme):
104-
return 'out/%s-%s' % (scheme, arch)
104+
bin_path = 'out/%s-%s' % (scheme, arch)
105+
obj_path = os.path.join(HOME_PATH, bin_path)
106+
return obj_path
105107

106108

107109
def ninjabuild(arch, scheme):
@@ -138,11 +140,11 @@ def pack_sdk(arch, scheme, output_path):
138140
src_lib_path = gen_lib_path(scheme)
139141
src_include_path = os.path.join(HOME_PATH, r'talk/owt/sdk/include/cpp')
140142
src_doc_path = os.path.join(HOME_PATH, r'talk/owt/docs/cpp/html')
141-
dst_lib_path = os.path.join(output_path, 'libs')
142-
dst_include_path = os.path.join(output_path, 'include')
143-
dst_doc_path = os.path.join(output_path, 'docs')
143+
dst_lib_path = os.path.join(os.path.abspath(output_path), 'libs')
144+
dst_include_path = os.path.join(os.path.abspath(output_path), 'include')
145+
dst_doc_path = os.path.join(os.path.abspath(output_path), 'docs')
144146
if not os.path.exists(dst_lib_path):
145-
os.mkdir(dst_lib_path)
147+
os.makedirs(dst_lib_path)
146148
if os.path.exists(dst_include_path):
147149
shutil.rmtree(dst_include_path)
148150
shutil.copy(src_lib_path, dst_lib_path)

talk/owt/BUILD.gn

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,8 @@ static_library("owt_sdk_base") {
254254
}
255255
if (is_linux) {
256256
if (owt_msdk_header_root != "") {
257+
include_dirs += [ owt_msdk_header_root ]
258+
defines += [ "OWT_USE_MSDK" ]
257259
sources += [
258260
"sdk/base/linux/displayutils.cc",
259261
"sdk/base/linux/displayutils.h",

talk/owt/sdk/base/linux/msdkvideodecoder.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "talk/owt/sdk/base/linux/msdkvideodecoder.h"
88
#include "webrtc/api/scoped_refptr.h"
99
#include "webrtc/rtc_base/logging.h"
10-
10+
#include "webrtc/rtc_base/ref_counted_object.h"
1111
#include "msdkcommon.h"
1212
#include "msdkvideobase.h"
1313
#include "msdkvideodecoder.h"
@@ -205,9 +205,8 @@ int32_t MsdkVideoDecoder::Decode(
205205
// 4. Invoke the callback to send decoded image to video sink.
206206
ReadFromInputStream(bit_stream_.get(), input_image.data(),
207207
input_image.size());
208-
if (input_image._completeFrame){
209-
bit_stream_->DataFlag = MFX_BITSTREAM_COMPLETE_FRAME;
210-
}
208+
bit_stream_->DataFlag = MFX_BITSTREAM_COMPLETE_FRAME;
209+
211210
mfxStatus sts = MFX_ERR_NONE;
212211
// First try to extract the video parameters from the frame after the
213212
// initialization

talk/owt/sdk/base/linux/msdkvideodecoder.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include "webrtc/api/video_codecs/video_encoder.h"
99
#include "webrtc/api/video_codecs/sdp_video_format.h"
10-
#include "webrtc/common_video/include/i420_buffer_pool.h"
1110
#include "webrtc/modules/video_coding/include/video_codec_interface.h"
1211
#include "webrtc/rtc_base/bind.h"
1312
#include "webrtc/rtc_base/checks.h"

talk/owt/sdk/base/mediautils.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "webrtc/rtc_base/string_to_number.h"
1313
#include "system_wrappers/include/field_trial.h"
1414
#include "talk/owt/sdk/base/mediautils.h"
15-
#include "talk/owt/sdk/base/win/mediacapabilities.h"
1615

1716
namespace owt {
1817
namespace base {

talk/owt/sdk/base/mediautils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ enum class H265ProfileId : int {
8181
kMain10,
8282
kMainStillPicture,
8383
kMainRExt, // Range extension
84-
KScc // Screen content extension.
84+
kScc // Screen content extension.
8585
};
8686

8787
/// Level ID as negotiated in SDP level-id field.

talk/owt/sdk/base/win/mediacapabilities.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ MediaCapabilities::SupportedCapabilitiesForVideoEncoder(
209209
hevc_scc_cap.max_temporal_layers = 1;
210210
hevc_scc_cap.max_spatial_layers = 1;
211211
hevc_scc_cap.low_power = true;
212-
hevc_scc_cap.codec_specific.H265.profile = H265ProfileId::KScc;
212+
hevc_scc_cap.codec_specific.H265.profile = H265ProfileId::kScc;
213213
hevc_scc_cap.supported_brc_modes.push_back(BRCMode::kCBR);
214214
hevc_scc_cap.supported_brc_modes.push_back(BRCMode::kVBR);
215215
hevc_scc_cap.supported_brc_modes.push_back(BRCMode::kCQP);

0 commit comments

Comments
 (0)