Fix klocwork issues. (#659)

Author: taste1981

talk/owt/sdk/base/customizedvideoencoderproxy.cc

@@ -154,7 +154,7 @@ int32_t CustomizedVideoEncoderProxy::Encode(
     for (int i = 0; i < 16; i++) {
       data_ptr[i + 7] = frame_number_sei_guid[i];
     }
-    if (side_data_size > 0) {
+    if (side_data_size > 0 && side_data_ptr) {
       memcpy(data_ptr + 23, side_data_ptr, side_data_size);
       encoder_buffer_handle->meta_data_.encoded_image_sidedata_free();
     }
@@ -203,7 +203,7 @@ int32_t CustomizedVideoEncoderProxy::Encode(
       data_ptr[i + 8] = frame_number_sei_guid[i];
     }
 
-    if (side_data_size > 0) {
+    if (side_data_size > 0 && side_data_ptr) {
       memcpy(data_ptr + 24, side_data_ptr, side_data_size);
       encoder_buffer_handle->meta_data_.encoded_image_sidedata_free();
     }

talk/owt/sdk/base/desktopcapturer.h

@@ -42,10 +42,12 @@ class BasicDesktopCapturer : public webrtc::VideoCaptureModule,
       rtc::VideoSinkInterface<webrtc::VideoFrame>* dataCallback) override {
     webrtc::MutexLock lock(&datacb_lock_);
     data_callback_ = dataCallback;
+    return;
   }
   virtual void DeRegisterCaptureDataCallback() override {
     webrtc::MutexLock lock(&datacb_lock_);
     data_callback_ = nullptr;
+    return;
   }
 
   virtual int32_t StartCapture(

talk/owt/sdk/base/deviceutils.cc

@@ -161,7 +161,8 @@ std::string DeviceUtils::GetDeviceNameByIndex(int index) {
   char unique_name[256];
   info->GetDeviceName(static_cast<uint32_t>(index), device_name,
                       sizeof(device_name), unique_name, sizeof(unique_name));
-  return std::string(device_name);
+  const std::string device_str(device_name);
+  return device_str;
 }
 
 }

talk/owt/sdk/base/win/video_capture_mf.cc

@@ -313,7 +313,7 @@ void VideoCaptureMF::IncomingFrame(IMFMediaBuffer*& frame, int64_t capture_time)
     }
 
     // Retrieves the texture from dxgi buffer
-    if (FAILED(dxgi_buffer->GetResource(IID_PPV_ARGS(&texture)))) {
+    if (FAILED(dxgi_buffer->GetResource(IID_PPV_ARGS(&texture))) || texture == nullptr) {
       RTC_LOG(LS_ERROR) << "Retreiving the texture from dxgi buffer failed:"
                         << std::system_category().message(hr);
       return;

talk/owt/sdk/base/win/videorendererd3d11.cc

@@ -361,7 +361,7 @@ bool WebrtcVideoRendererD3D11Impl::InitMPO(int width, int height) {
 
   CComPtr<IDCompositionDesktopDevice> desktop_device;
   hr = DCompositionCreateDevice2(dxgi_device2_, IID_PPV_ARGS(&desktop_device));
-  if (FAILED(hr))
+  if (FAILED(hr) || !desktop_device.p)
     return false;
 
   hr = desktop_device->QueryInterface(&comp_device2_);