Revert "Introduce RTC_NO_UNIQUE_ADDRESS."

This reverts commit f5e261a.

Reason for revert: Breaks downstream projects.

Original change's description:
> Introduce RTC_NO_UNIQUE_ADDRESS.
>
> This macro introduces the possibility to suggest the compiler that a
> data member doesn't need an address different from other non static
> data members.
>
> The usage of a macro is to maintain portability since at the moment
> the attribute [[no_unique_address]] is only supported by clang
> with at least -std=c++11 but it should be supported by all the
> compilers starting from C++20.
>
> Bug: webrtc:11495
> Change-Id: I9f12b67b4422a2749649eaa6b004a67d5fd572d8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173331
> Commit-Queue: Mirko Bonadei <[email protected]>
> Reviewed-by: Karl Wiberg <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#32246}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11495
Change-Id: Ice318d1b11ca3dff09c190187a0b0a32ca945fe3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186944
Reviewed-by: Mirko Bonadei <[email protected]>
Reviewed-by: Per Kjellander <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#32335}

Author: MirkoBonadei

audio/BUILD.gn

@@ -94,7 +94,6 @@ rtc_library("audio") {
     "../rtc_base/experiments:field_trial_parser",
     "../rtc_base/synchronization:mutex",
     "../rtc_base/synchronization:sequence_checker",
-    "../rtc_base/system:no_unique_address",
     "../rtc_base/task_utils:to_queued_task",
     "../system_wrappers",
     "../system_wrappers:field_trial",

audio/channel_receive_frame_transformer_delegate.h

@@ -15,7 +15,6 @@
 
 #include "api/frame_transformer_interface.h"
 #include "rtc_base/synchronization/sequence_checker.h"
-#include "rtc_base/system/no_unique_address.h"
 #include "rtc_base/task_queue.h"
 #include "rtc_base/thread.h"
 
@@ -62,7 +61,7 @@ class ChannelReceiveFrameTransformerDelegate : public TransformedFrameCallback {
   ~ChannelReceiveFrameTransformerDelegate() override = default;
 
  private:
-  RTC_NO_UNIQUE_ADDRESS SequenceChecker sequence_checker_;
+  SequenceChecker sequence_checker_;
   ReceiveFrameCallback receive_frame_callback_
       RTC_GUARDED_BY(sequence_checker_);
   rtc::scoped_refptr<FrameTransformerInterface> frame_transformer_

audio/voip/BUILD.gn

@@ -98,7 +98,6 @@ rtc_library("audio_egress") {
     "../../rtc_base:thread_checker",
     "../../rtc_base:timeutils",
     "../../rtc_base/synchronization:mutex",
-    "../../rtc_base/system:no_unique_address",
     "../utility:audio_frame_operations",
   ]
 }

call/BUILD.gn

@@ -224,7 +224,6 @@ rtc_library("bitrate_allocator") {
     "../rtc_base:rtc_base_approved",
     "../rtc_base:safe_minmax",
     "../rtc_base/synchronization:sequence_checker",
-    "../rtc_base/system:no_unique_address",
     "../system_wrappers",
     "../system_wrappers:field_trial",
     "../system_wrappers:metrics",
@@ -285,7 +284,6 @@ rtc_library("call") {
     "../rtc_base/experiments:field_trial_parser",
     "../rtc_base/network:sent_packet",
     "../rtc_base/synchronization:sequence_checker",
-    "../rtc_base/system:no_unique_address",
     "../rtc_base/task_utils:pending_task_safety_flag",
     "../system_wrappers",
     "../system_wrappers:field_trial",

call/bitrate_allocator.h

@@ -22,7 +22,6 @@
 #include "api/call/bitrate_allocation.h"
 #include "api/transport/network_types.h"
 #include "rtc_base/synchronization/sequence_checker.h"
-#include "rtc_base/system/no_unique_address.h"
 
 namespace webrtc {
 
@@ -149,7 +148,7 @@ class BitrateAllocator : public BitrateAllocatorInterface {
   // video send stream.
   static uint8_t GetTransmissionMaxBitrateMultiplier();
 
-  RTC_NO_UNIQUE_ADDRESS SequenceChecker sequenced_checker_;
+  SequenceChecker sequenced_checker_;
   LimitObserver* const limit_observer_ RTC_GUARDED_BY(&sequenced_checker_);
   // Stored in a list to keep track of the insertion order.
   std::vector<AllocatableTrack> allocatable_tracks_

call/call.cc

@@ -51,7 +51,6 @@
 #include "rtc_base/logging.h"
 #include "rtc_base/strings/string_builder.h"
 #include "rtc_base/synchronization/sequence_checker.h"
-#include "rtc_base/system/no_unique_address.h"
 #include "rtc_base/task_utils/pending_task_safety_flag.h"
 #include "rtc_base/thread_annotations.h"
 #include "rtc_base/time_utils.h"
@@ -533,7 +532,7 @@ class SharedModuleThread::Impl {
   }
 
  private:
-  RTC_NO_UNIQUE_ADDRESS SequenceChecker sequence_checker_;
+  SequenceChecker sequence_checker_;
   mutable int ref_count_ RTC_GUARDED_BY(sequence_checker_) = 0;
   std::unique_ptr<ProcessThread> const module_thread_;
   std::function<void()> const on_one_ref_remaining_;

call/call_factory.h

@@ -15,7 +15,6 @@
 #include "call/call.h"
 #include "call/call_config.h"
 #include "rtc_base/synchronization/sequence_checker.h"
-#include "rtc_base/system/no_unique_address.h"
 
 namespace webrtc {
 
@@ -28,7 +27,7 @@ class CallFactory : public CallFactoryInterface {
 
   Call* CreateCall(const CallConfig& config) override;
 
-  RTC_NO_UNIQUE_ADDRESS SequenceChecker call_thread_;
+  SequenceChecker call_thread_;
   rtc::scoped_refptr<SharedModuleThread> module_thread_
       RTC_GUARDED_BY(call_thread_);
 };

logging/BUILD.gn

@@ -268,7 +268,6 @@ if (rtc_enable_protobuf) {
       "../rtc_base:rtc_task_queue",
       "../rtc_base:safe_minmax",
       "../rtc_base/synchronization:sequence_checker",
-      "../rtc_base/system:no_unique_address",
     ]
     absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
   }

logging/rtc_event_log/rtc_event_log_impl.h

@@ -24,7 +24,6 @@
 #include "api/task_queue/task_queue_factory.h"
 #include "logging/rtc_event_log/encoder/rtc_event_log_encoder.h"
 #include "rtc_base/synchronization/sequence_checker.h"
-#include "rtc_base/system/no_unique_address.h"
 #include "rtc_base/task_queue.h"
 #include "rtc_base/thread_annotations.h"
 
@@ -79,7 +78,7 @@ class RtcEventLogImpl final : public RtcEventLog {
   int64_t last_output_ms_ RTC_GUARDED_BY(*task_queue_);
   bool output_scheduled_ RTC_GUARDED_BY(*task_queue_);
 
-  RTC_NO_UNIQUE_ADDRESS SequenceChecker logging_state_checker_;
+  SequenceChecker logging_state_checker_;
   bool logging_state_started_ RTC_GUARDED_BY(logging_state_checker_);
 
   // Since we are posting tasks bound to |this|,  it is critical that the event

media/BUILD.gn

@@ -196,7 +196,6 @@ rtc_library("rtc_simulcast_encoder_adapter") {
     "../rtc_base:rtc_base_approved",
     "../rtc_base/experiments:rate_control_settings",
     "../rtc_base/synchronization:sequence_checker",
-    "../rtc_base/system:no_unique_address",
     "../rtc_base/system:rtc_export",
     "../system_wrappers",
     "../system_wrappers:field_trial",