Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Commit 0e48b26

Browse files
qwu16qwu16
committed
Remove debug info
1 parent 35f9619 commit 0e48b26

7 files changed

+7
-32
lines changed

‎quic_transport/sdk/impl/quic_transport_factory_impl.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ QuicTransportFactoryImpl::CreateQuicTransportClient(
212212

213213
::quic::QuicServerId server_id(host, port, false);
214214
::quic::ParsedQuicVersionVector versions = ::quic::CurrentSupportedVersions();
215-
printf("url host is:%s, origin host is:%s\n", url.host().c_str(), host);
216215

217216
*result = new net::QuicTransportOwtClientImpl(
218217
::quic::QuicSocketAddress(ip_addr, port), server_id, versions, fingerprints,

‎quic_transport/sdk/impl/quic_transport_owt_client_impl.cc‎

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ std::unique_ptr<::quic::ProofVerifier> CreateProofVerifier(
5050
server_certificate_fingerprints) {
5151
bool success = verifier->AddFingerprint(fingerprint);
5252
if (!success) {
53-
DLOG(WARNING) << "Failed to add a certificate fingerprint: "
53+
LOG(ERROR) << "Failed to add a certificate fingerprint: "
5454
<< fingerprint.fingerprint;
5555
}
5656
}
@@ -118,14 +118,14 @@ void QuicTransportOwtClientImpl::Start() {
118118

119119
void QuicTransportOwtClientImpl::StartOnCurrentThread() {
120120
if (!Initialize()) {
121-
std::cerr << "Failed to initialize client." << std::endl;
121+
LOG(ERROR) << "Failed to initialize client." << std::endl;
122122
if(visitor_) {
123123
visitor_->OnConnectionFailed();
124124
}
125125
return;
126126
}
127127
if (!Connect()) {
128-
std::cerr << "Failed to connect." << std::endl;
128+
LOG(ERROR) << "Failed to connect." << std::endl;
129129
if(visitor_) {
130130
visitor_->OnConnectionFailed();
131131
}
@@ -135,10 +135,8 @@ void QuicTransportOwtClientImpl::StartOnCurrentThread() {
135135
session_ = client_session();
136136
session_->set_visitor(this);
137137
if(visitor_) {
138-
printf("client call onConnected\n");
139138
visitor_->OnConnected();
140139
}
141-
std::cerr << "client connect to quic server succeed in thread:" << base::PlatformThread::CurrentId() << std::endl;
142140
}
143141

144142
void QuicTransportOwtClientImpl::Stop() {
@@ -190,7 +188,6 @@ void QuicTransportOwtClientImpl::OnStreamClosed(uint32_t id) {
190188
}
191189

192190
const char* QuicTransportOwtClientImpl::Id() {
193-
std::cerr << "QuicTransportOwtClientImpl Get client session id:" << client_session()->connection()->connection_id().ToString();
194191
const std::string& session_id_str =
195192
client_session()->connection()->connection_id().ToString();
196193
char* id = new char[session_id_str.size() + 1];
@@ -201,7 +198,6 @@ const char* QuicTransportOwtClientImpl::Id() {
201198
}
202199

203200
void QuicTransportOwtClientImpl::CloseStreamOnCurrentThread(uint32_t id) {
204-
printf("QuicTransportOwtClientImpl::CloseStreamOnCurrentThread close stream:%d\n", id);
205201
session_->ResetStream(id, quic::QUIC_STREAM_CANCELLED);
206202
}
207203

@@ -216,7 +212,6 @@ uint8_t QuicTransportOwtClientImpl::length() {
216212
}
217213

218214
owt::quic::QuicTransportStreamInterface* QuicTransportOwtClientImpl::CreateBidirectionalStream() {
219-
std::cerr << "QuicTransportOwtClientImpl::CreateBidirectionalStream" << std::endl;
220215
owt::quic::QuicTransportStreamInterface* result(nullptr);
221216
base::WaitableEvent done(base::WaitableEvent::ResetPolicy::AUTOMATIC,
222217
base::WaitableEvent::InitialState::NOT_SIGNALED);
@@ -235,15 +230,13 @@ owt::quic::QuicTransportStreamInterface* QuicTransportOwtClientImpl::CreateBidir
235230
}
236231

237232
owt::quic::QuicTransportStreamInterface* QuicTransportOwtClientImpl::CreateBidirectionalStreamOnCurrentThread() {
238-
std::cerr << "QuicTransportOwtClientImpl::CreateBidirectionalStreamOnCurrentThread" << std::endl;
239233
if (!connected()) {
240234
return nullptr;
241235
}
242236

243237
auto* stream = static_cast<owt::quic::QuicTransportStreamInterface*>(
244238
client_session()->CreateOutgoingBidirectionalStream());
245239

246-
std::cerr << "QuicTransportOwtClientImpl::CreateBidirectionalStreamOnCurrentThread succeed" << std::endl;
247240
return stream;
248241
}
249242

‎quic_transport/sdk/impl/quic_transport_owt_client_session.cc‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void QuicTransportOwtClientSession::OnProofVerifyDetailsAvailable(
4444

4545
bool QuicTransportOwtClientSession::ShouldCreateOutgoingBidirectionalStream() {
4646
if (!crypto_stream_->encryption_established()) {
47-
QUIC_DLOG(INFO) << "Encryption not active so no outgoing stream created.";
47+
LOG(ERROR) << "Encryption not active so no outgoing stream created.";
4848
return false;
4949
}
5050
// if (!GetQuicReloadableFlag(quic_use_common_stream_check) &&
@@ -132,7 +132,7 @@ bool QuicTransportOwtClientSession::ShouldCreateIncomingStream(QuicStreamId id)
132132
return false;
133133
}
134134
if (transport_goaway_received() && respect_goaway_) {
135-
QUIC_DLOG(INFO) << "Failed to create a new outgoing stream. "
135+
LOG(INFO) << "Failed to create a new outgoing stream. "
136136
<< "Already received goaway.";
137137
return false;
138138
}
@@ -204,7 +204,6 @@ void QuicTransportOwtClientSession::OnStreamClosed(quic::QuicStreamId stream_id)
204204
void QuicTransportOwtClientSession::OnConnectionClosed(
205205
const quic::QuicConnectionCloseFrame& frame,
206206
quic::ConnectionCloseSource source) {
207-
//std::cerr << "QuicTransportOwtClientSession::OnConnectionClosed and client session id:" << connection()->connection_id().ToString() << " in thread" << base::PlatformThread::CurrentId();
208207
const std::string& session_id_str =
209208
connection()->client_connection_id().ToString();
210209
char* id = new char[session_id_str.size() + 1];

‎quic_transport/sdk/impl/quic_transport_owt_dispatcher.cc‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ std::unique_ptr<QuicSession> QuicTransportOwtDispatcher::CreateQuicSession(
3939
const ParsedQuicVersion& version,
4040
const ParsedClientHello& parsed_chlo) {
4141
// The QuicServerSessionBase takes ownership of |connection| below.
42-
//printf("QuicTransportOwtDispatcher::CreateQuicSession in thread:%d\n", base::PlatformThread::CurrentId());
4342
QuicConnection* connection =
4443
new QuicConnection(connection_id, self_address, peer_address, helper(),
4544
alarm_factory(), writer(),
@@ -51,7 +50,6 @@ std::unique_ptr<QuicSession> QuicTransportOwtDispatcher::CreateQuicSession(
5150
crypto_config(), compressed_certs_cache(), task_runner_, event_runner_);
5251
session->Initialize();
5352
if (visitor_) {
54-
printf("QuicTransportOwtDispatcher call visitor OnSessionCreated\n");
5553
visitor_->OnSessionCreated(session.get());
5654
}
5755
return session;
@@ -62,12 +60,10 @@ std::unique_ptr<QuicSession> QuicTransportOwtDispatcher::CreateQuicSession(
6260
QuicErrorCode error,
6361
const std::string& error_details,
6462
ConnectionCloseSource source) {
65-
//printf("QuicTransportOwtDispatcher OnConnectionClosed for connection:%s in thread:%d\n", server_connection_id.ToString().c_str(), base::PlatformThread::CurrentId());
6663
if (visitor_) {
6764
visitor_->OnSessionClosed(server_connection_id);
6865
}
6966

70-
printf("QuicTransportOwtDispatcher OnConnectionClosed ends\n");
7167
}
7268

7369
} // namespace quic

‎quic_transport/sdk/impl/quic_transport_owt_server_impl.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ void QuicTransportOwtServerImpl::StartOnCurrentThread() {
138138
LOG(ERROR) << "GetLocalAddress() failed: " << ErrorToString(rc);
139139
}
140140

141-
DVLOG(1) << "Listening on " << server_address_.ToString();
141+
LOG(INFO) << "Listening on " << server_address_.ToString();
142142

143143
socket_.swap(socket);
144144

@@ -182,7 +182,6 @@ void QuicTransportOwtServerImpl::SetVisitor(owt::quic::QuicTransportServerInterf
182182
}
183183

184184
void QuicTransportOwtServerImpl::NewSessionCreated(quic::QuicTransportOwtServerSession* session) {
185-
printf("QuicTransportOwtServerImpl call visitor OnSession\n");
186185
if (visitor_) {
187186
visitor_->OnSession(session);
188187
}
@@ -202,7 +201,6 @@ void QuicTransportOwtServerImpl::OnSessionCreated(quic::QuicTransportOwtServerSe
202201
void QuicTransportOwtServerImpl::SessionClosed(quic::QuicConnectionId sessionId) {
203202
if (visitor_) {
204203
const std::string& session_id_str = sessionId.ToString();
205-
printf("server session:%s closed\n", session_id_str.c_str());
206204
char* id = new char[session_id_str.size() + 1];
207205
strcpy(id, session_id_str.c_str());
208206
visitor_->OnClosedSession(id, session_id_str.size());

‎quic_transport/sdk/impl/quic_transport_owt_server_session.cc‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ QuicTransportOwtServerSession::~QuicTransportOwtServerSession() {
4848
// for (auto const& kv : dynamic_streams()) {
4949
// static_cast<QuicRawStream*>(kv.second.get())->ClearSession();
5050
// }
51-
//delete visitor_;
52-
printf("We are in ~QuicTransportOwtServerSession\n");
53-
//visitor_ = nullptr;
5451
}
5552

5653
void QuicTransportOwtServerSession::Initialize() {
@@ -93,7 +90,6 @@ void QuicTransportOwtServerSession::StopOnCurrentThread() {
9390

9491
void QuicTransportOwtServerSession::Stop() {
9592
if (task_runner_->BelongsToCurrentThread()) {
96-
printf("QuicTransportOwtServerSession::Stop in current thread\n");
9793
return StopOnCurrentThread();
9894
}
9995
task_runner_->PostTask(
@@ -106,7 +102,6 @@ void QuicTransportOwtServerSession::SetVisitor(owt::quic::QuicTransportSessionIn
106102
}
107103

108104
const char* QuicTransportOwtServerSession::Id() {
109-
QUIC_DLOG(INFO) << "QuicTransportOwtServerSession Get session id:" << connection()->connection_id().ToString();
110105
const std::string& session_id_str =
111106
connection()->connection_id().ToString();
112107
char* id = new char[session_id_str.size() + 1];
@@ -116,7 +111,6 @@ const char* QuicTransportOwtServerSession::Id() {
116111
}
117112

118113
void QuicTransportOwtServerSession::CloseStreamOnCurrentThread(uint32_t id) {
119-
printf("QuicTransportOwtServerSession::CloseStreamOnCurrentThread close stream:%d\n", id);
120114
ResetStream(id, QUIC_STREAM_CANCELLED);
121115
}
122116

@@ -156,7 +150,7 @@ bool QuicTransportOwtServerSession::ShouldCreateIncomingStream(QuicStreamId id)
156150

157151
if (QuicUtils::IsServerInitiatedStreamId(connection()->transport_version(),
158152
id)) {
159-
QUIC_DLOG(INFO) << "Invalid incoming even stream_id:" << id;
153+
LOG(ERROR) << "Invalid incoming even stream_id:" << id;
160154
connection()->CloseConnection(
161155
QUIC_INVALID_STREAM_ID, "Client created even numbered stream",
162156
ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);

‎quic_transport/sdk/impl/quic_transport_owt_stream_impl.cc‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ uint32_t QuicTransportOwtStreamImpl::Id() const {
4343
}
4444

4545
void QuicTransportOwtStreamImpl::SetVisitor(owt::quic::QuicTransportStreamInterface::Visitor* visitor) {
46-
printf("QuicTransportOwtStreamImpl::SetVisitor\n");
4746
visitor_ = visitor;
4847
}
4948

@@ -76,10 +75,8 @@ void QuicTransportOwtStreamImpl::processData() {
7675
struct iovec iov;
7776
if (sequencer()->GetReadableRegions(&iov, 1) == 0) {
7877
// No more data to read.
79-
printf("No more data to read\n");
8078
break;
8179
}
82-
//printf("Stream: %d processd:%zu, bytes in thread:%d\n",id(), iov.iov_len, base::PlatformThread::CurrentId());
8380
if (visitor()) {
8481
visitor()->OnData(this, static_cast<char*>(iov.iov_base), iov.iov_len);
8582
}
@@ -96,7 +93,6 @@ void QuicTransportOwtStreamImpl::processData() {
9693
OnFinRead();
9794

9895
if (write_side_closed() || fin_buffered()) {
99-
printf("write side closed or fin buffered\n");
10096
return;
10197
}
10298
}

0 commit comments

Comments
 (0)