Add IsSessionReady(). (#18)

It allows developer to query whether a session is negotiated and ready
for first writing.

Author: jianjunz

quic_transport/api/owt/quic/quic_transport_session_interface.h

@@ -22,8 +22,9 @@ class OWT_EXPORT QuicTransportSessionInterface {
     virtual void OnCanCreateNewOutgoingStream(bool unidirectional) = 0;
   };
   virtual ~QuicTransportSessionInterface() = default;
-  virtual const char* ConnectionId() = 0;
+  virtual const char* ConnectionId() const = 0;
   virtual void SetVisitor(Visitor* visitor) = 0;
+  virtual bool IsSessionReady() const = 0;
   virtual QuicTransportStreamInterface* CreateBidirectionalStream() = 0;
   // Get connection stats.
   virtual const ConnectionStats& GetStats() = 0;

quic_transport/api/owt/quic/quic_transport_stream_interface.h

@@ -20,7 +20,9 @@ class OWT_EXPORT QuicTransportStreamInterface {
     virtual ~Visitor() = default;
     // Called when new data is available.
     virtual void OnCanRead() = 0;
-    // Called when stream is ready to write.
+    // Called when stream is ready to write new data. It doesn't called before
+    // first write. Before first write, please check IsSessionReady().
+    // TODO: Add OnSessionReady to QuicTransportSessionInterface::Visitor.
     virtual void OnCanWrite() = 0;
     // Called when final incoming data is read.
     virtual void OnFinRead() = 0;

quic_transport/impl/quic_transport_owt_server_session.cc

@@ -60,13 +60,17 @@ QuicTransportOwtServerSession::~QuicTransportOwtServerSession() {
   }
 }
 
-const char* QuicTransportOwtServerSession::ConnectionId() {
+const char* QuicTransportOwtServerSession::ConnectionId() const {
   const std::string& connection_id_str = connection_id().ToString();
   char* id = new char[connection_id_str.size() + 1];
   strcpy(id, connection_id_str.c_str());
   return id;
 }
 
+bool QuicTransportOwtServerSession::IsSessionReady() const {
+  return ::quic::QuicTransportServerSession::IsSessionReady();
+}
+
 QuicTransportStreamInterface*
 QuicTransportOwtServerSession::CreateBidirectionalStream() {
   if (runner_->BelongsToCurrentThread()) {
@@ -93,7 +97,7 @@ QuicTransportStreamInterface*
 QuicTransportOwtServerSession::CreateBidirectionalStreamOnCurrentThread() {
   std::unique_ptr<::quic::QuicTransportStream> stream =
       std::make_unique<::quic::QuicTransportStream>(
-          GetNextOutgoingUnidirectionalStreamId(), this, this);
+          GetNextOutgoingBidirectionalStreamId(), this, this);
   std::unique_ptr<QuicTransportStreamImpl> stream_impl =
       std::make_unique<QuicTransportStreamImpl>(stream.get(), runner_,
                                                 event_runner_);
@@ -182,5 +186,6 @@ const ConnectionStats& QuicTransportOwtServerSession::GetStats() {
   stats_.estimated_bandwidth = stats.estimated_bandwidth.ToBitsPerSecond();
   return stats_;
 }
+
 }  // namespace quic
 }  // namespace owt

quic_transport/impl/quic_transport_owt_server_session.h

@@ -53,7 +53,8 @@ class QuicTransportOwtServerSession
   void SetVisitor(
       owt::quic::QuicTransportSessionInterface::Visitor* visitor) override;
   // Caller needs to free the connection ID returned.
-  const char* ConnectionId() override;
+  const char* ConnectionId() const override;
+  bool IsSessionReady() const override;
   QuicTransportStreamInterface* CreateBidirectionalStream() override;
   const ConnectionStats& GetStats() override;