Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Commit 995f58b

Browse files
authored
Add const qualifier to the first argument of Write method. (#38)
The pointer to data doesn't need to be changed. Making it const so it can accept pointer casted from std::string.
1 parent 56ab441 commit 995f58b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

web_transport/sdk/api/owt/quic/web_transport_stream_interface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class OWT_EXPORT WebTransportStreamInterface {
3333
virtual void SetVisitor(Visitor* visitor) = 0;
3434
// Write or buffer data. Returns the length of data written or buffered.
3535
// Current implementation always returns 0 or `length`.
36-
virtual size_t Write(uint8_t* data, size_t length) = 0;
36+
virtual size_t Write(const uint8_t* data, size_t length) = 0;
3737
// Reads at most `length` bytes into `data` and returns the number of bytes
3838
// actually read.
3939
virtual size_t Read(uint8_t* data, size_t length) = 0;

web_transport/sdk/impl/web_transport_stream_impl.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ uint32_t WebTransportStreamImpl::Id() const {
5858
return stream_->GetStreamId();
5959
}
6060

61-
size_t WebTransportStreamImpl::Write(uint8_t* data, size_t length) {
61+
size_t WebTransportStreamImpl::Write(const uint8_t* data, size_t length) {
6262
DCHECK_EQ(sizeof(uint8_t), sizeof(char));
6363
CHECK(io_runner_);
6464
if (io_runner_->BelongsToCurrentThread()) {
@@ -71,11 +71,11 @@ size_t WebTransportStreamImpl::Write(uint8_t* data, size_t length) {
7171
io_runner_->PostTask(
7272
FROM_HERE,
7373
base::BindOnce(
74-
[](WebTransportStreamImpl* stream, uint8_t* data, size_t& length,
74+
[](WebTransportStreamImpl* stream, const uint8_t* data, size_t& length,
7575
bool& result, base::WaitableEvent* event) {
7676
if (stream->stream_->CanWrite()) {
77-
result = stream->stream_->Write(
78-
absl::string_view(reinterpret_cast<char*>(data), length));
77+
result = stream->stream_->Write(absl::string_view(
78+
reinterpret_cast<const char*>(data), length));
7979
} else {
8080
result = false;
8181
}

web_transport/sdk/impl/web_transport_stream_impl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class WebTransportStreamImpl : public WebTransportStreamInterface,
4141
void SetVisitor(
4242
owt::quic::WebTransportStreamInterface::Visitor* visitor) override;
4343
uint32_t Id() const override;
44-
size_t Write(uint8_t* data, size_t length) override;
44+
size_t Write(const uint8_t* data, size_t length) override;
4545
size_t Read(uint8_t* data, size_t length) override;
4646
size_t ReadableBytes() const override;
4747
void Close() override;

0 commit comments

Comments
 (0)