Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Commit 23a5731

Browse files
committed
Terminate a session returns a promise.
A session might be managed by rtcController or quicController, since accessController doesn't know a session's type, try to terminate it in either rtcControoler or quicController.
1 parent a5091b4 commit 23a5731

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

source/agent/conference/accessController.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,10 @@ module.exports.create = function(spec, rpcReq, on_session_established, on_sessio
259259
that.terminate = function(sessionId, direction, reason) {
260260
log.debug('terminate, sessionId:', sessionId, 'direction:', direction);
261261
if (!sessions[sessionId]) {
262-
rtc_controller.terminate(sessionId, direction, reason);
263-
quic_controller.terminate(sessionId, direction, reason);
264-
return;
262+
// It looks like accessController doesn't know if a session is a RTC session or QUIC session.
263+
return rtc_controller.terminate(sessionId, direction, reason).catch(e => {
264+
quic_controller.terminate(sessionId, direction, reason);
265+
});
265266
}
266267

267268
var session = sessions[sessionId];

0 commit comments

Comments
 (0)