Close connection if no transport ID is received after 10s.

Author: jianjunz

source/agent/quic/webtransport/quicTransportServer.js

@@ -17,6 +17,11 @@ const zeroUuid = '00000000000000000000000000000000';
  * streamadded - A new stream is added, and ready to be attached to a stream
  * pipeline. Argument: a string for publication or subscription ID.
  */
+
+// Connection will be closed if no transport ID is received after
+// `authenticationTimeout` seconds.
+const authenticationTimeout = 10;
+
 module.exports = class QuicTransportServer extends EventEmitter {
   constructor(addon, port) {
     super();
@@ -28,6 +33,12 @@ module.exports = class QuicTransportServer extends EventEmitter {
     this._assignedTransportIds = []; // Transport channels assigned to this server.
     this._server.onconnection = (connection) => {
       this._unAuthenticatedConnections.push(connection);
+      setTimeout(() => {
+        // Must be authenticated in `authenticationTimeout` seconds.
+        if (!connection.transportId) {
+          connection.close();
+        }
+      }, authenticationTimeout * 1000);
       connection.onincomingstream = (stream) => {
         stream.oncontentsessionid = (id) => {
           const streamId = this._uuidBytesToString(new Uint8Array(id))
@@ -46,11 +57,17 @@ module.exports = class QuicTransportServer extends EventEmitter {
             this.emit('streamadded', stream);
           }
         };
-        stream.ondata=(data)=>{
+        stream.ondata = (data) => {
           if (stream.contentSessionId === zeroUuid) {
-            connection.transportId = data.toString('utf8');
+            const transportId = data.toString('utf8');
+            if (!this._assignedTransportIds.includes(transportId)) {
+              log.info(JSON.stringify(connection));
+              connection.close();
+            }
+            connection.transportId = transportId;
+            stream.transportId = transportId;
             this._connections.set(connection.transportId, connection);
-            log.info('Transport ID: ' + connection.transportId);
+            log.info('New connection for transport ID: ' + transportId);
           }
         }
       }
@@ -110,7 +127,6 @@ module.exports = class QuicTransportServer extends EventEmitter {
     for (let i = 0; i < 16; i++) {
       uuidArray[i] = parseInt(uuidString.substring(i * 2, i * 2 + 2), 16);
     }
-    console.log(uuidArray);
     return uuidArray;
   }
 };

source/agent/quic/webtransport/test/quicTransportServerTest.js

@@ -6,7 +6,7 @@
 
 'use strict';
 
-const expect = require('chai').use(require('chai-as-promised')).expect;
+const assert = require('chai').use(require('chai-as-promised')).assert;
 const QuicTransportServer = require('../quicTransportServer.js');
 const sinon = require('sinon');
 
@@ -48,18 +48,58 @@ describe('Test QuicTransportServer.', () => {
        const transportid1 = 'transportid1';
        const transportid2 = 'transportid2';
        server.addTransportId(transportid1);
-       expect(server.createSendStream(transportid2)).to.be.undefined;
+       assert.equal(server.createSendStream(transportid2), undefined);
        done();
      });
 
-  it('Test UUID convertions.',
-     (done) => {
-       const uuidString0='';
-       const uuidString1='';
-       const uuidString2='';
-       const uuidArray0='';
-       const uuidArray1='';
-       const uuidArray2='';
-       done();
-     });
+  it('UUID convertions.', (done) => {
+    const uuidStrings = [
+      '00000000000000000000000000000000', 'd8bc24a9360b4320bf42704353d906db',
+      'e6fc9b708b96418ab996c50bed964eb2'
+    ];
+    const uuidArrays = [
+      new Uint8Array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]),
+      new Uint8Array([
+        216, 188, 36, 169, 54, 11, 67, 32, 191, 66, 112, 67, 83, 217, 6, 219
+      ]),
+      new Uint8Array([
+        230, 252, 155, 112, 139, 150, 65, 138, 185, 150, 197, 11, 237, 150, 78,
+        178
+      ])
+    ];
+    assert.equal(uuidStrings.length, uuidArrays.length);
+    for (let i = 0; i < uuidStrings.length; i++) {
+      assert.deepEqual(
+          uuidArrays[i], server._uuidStringToUint8Array(uuidStrings[i]));
+      assert.deepEqual(
+          uuidStrings[i], server._uuidBytesToString(uuidArrays[i]));
+    }
+    done();
+  });
+
+  it('Correctly identify transport ID and content session ID.', (done) => {
+    const connection1 = {close: sinon.stub()};
+    const connection2 = {close: sinon.stub()};
+    const stream10 = {};
+    const stream20 = {};
+    const transportId = '0123456789';
+    const unauthenticatedTransportId = '1234567890';
+    server.addTransportId(transportId);
+    fakeAddonServer.onconnection(connection1);
+    connection1.onincomingstream(stream10);
+    stream10.oncontentsessionid(
+        new Uint8Array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]));
+    stream10.ondata(Buffer.from(transportId, 'utf8'));
+    assert.equal(connection1.transportId, transportId);
+    assert.equal(stream10.transportId, transportId);
+    fakeAddonServer.onconnection(connection2);
+    connection2.onincomingstream(stream20);
+    stream20.oncontentsessionid(
+        new Uint8Array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]));
+    stream20.ondata(Buffer.from(unauthenticatedTransportId, 'utf8'));
+    sinon.assert.notCalled(connection1.close);
+    // connection2 doesn't have an authenticated transport ID. Thus, it should be closed.
+    sinon.assert.calledOnce(connection2.close);
+    done();
+  });
 });