Deep clone data before notify to clients (#1335)

snoozebear · web-flow · commit 62fd9c418ab3 · 2023-07-19T09:48:58.000+08:00
diff --git a/source/portal/socketIOServer.js b/source/portal/socketIOServer.js
@@ -487,7 +487,8 @@ var SocketIOServer = function(spec, portal, observer) {
     log.debug('receivers:', JSON.stringify(receivers));
     for (let clientId of receivers) {
       if (!excludeList.includes(clientId) && clients[clientId]) {
-        clients[clientId].notify(event, data);
+        let dataClone = JSON.parse(JSON.stringify(data));
+        clients[clientId].notify(event, dataClone);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -487,7 +487,8 @@ var SocketIOServer = function(spec, portal, observer) {`
`487`	`487`	`log.debug('receivers:', JSON.stringify(receivers));`
`488`	`488`	`for (let clientId of receivers) {`
`489`	`489`	`if (!excludeList.includes(clientId) && clients[clientId]) {`
`490`		`- clients[clientId].notify(event, data);`
	`490`	`+ let dataClone = JSON.parse(JSON.stringify(data));`
	`491`	`+ clients[clientId].notify(event, dataClone);`
`491`	`492`	`}`
`492`	`493`	`}`
`493`	`494`	`}`