Update variable names (#1296)

Author: starwarfan

source/management_console/index.js

@@ -30,12 +30,7 @@ app.use('/console', express.static(__dirname + '/public'));
 const session = require('express-session');
 const {v4: uuidv4} = require('uuid');
 
-function createRandomHex(num) {
-  return crypto.randomBytes(num).toString('hex');
-}
-
-app.use(session({
-  secret: createRandomHex(32),
+const options = {
   name: 'owtserver',
   genid: function(req) {
     return uuidv4();
@@ -48,7 +43,10 @@ app.use(session({
     sameSite: true,
     maxAge: 600000
   }
-}));
+}
+Object.assign(options, {secret: crypto.randomBytes(32).toString('hex')});
+
+app.use(session(options));
 
 app.use((req, res, next) => {
   res.set('Cache-Control', 'no-store, no-cache');

source/stream_service/stateTypes.js

@@ -61,7 +61,7 @@ class WorkerNode {
     this.pubs = new Set();
     this.subs = new Set();
     this.procs = new Set();
-    this.address = null;
+    this.streamAddr = null;
   }
   isEmpty() {
     return this.pubs.size === 0 && this.subs.size === 0;
@@ -253,7 +253,7 @@ class SourceTrack {
     this.id = id;
     this.parent = parent;
     this.linkedSubs = new Set(); // Set {SubscriptionId}
-    this.address = null; // Same as WokerNode's
+    this.address = null; // Same as WokerNode's streamAddr
   }
   plain() {
     const plain = Object.assign({}, this);

source/stream_service/streamService.js

@@ -231,13 +231,13 @@ function streamEngine(rpcClient) {
     if (!plainNode) {
       throw new Error('No node for internal address');
     }
-    if (plainNode.address) {
-      nodeAddress.set(nodeId, plainNode.address);
-      return plainNode.address;
+    if (plainNode.streamAddr) {
+      nodeAddress.set(nodeId, plainNode.streamAddr);
+      return plainNode.streamAddr;
     }
     const addr = await rpcChannel.makeRPC(
       nodeId, 'getInternalAddress', []);
-    await stateStores.update('nodes', {id: nodeId}, {address: addr});
+    await stateStores.update('nodes', {id: nodeId}, {streamAddr: addr});
     nodeAddress.set(nodeId, addr);
     return addr;
   };