Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Commit d2538e5

Browse files
committed
Address comments
1 parent dfdb641 commit d2538e5

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

scripts/installWebrtc.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ download_and_build(){
7171
echo "src already exists."
7272
else
7373
git clone -b 88-sdk https://github.com/open-webrtc-toolkit/owt-deps-webrtc.git src
74+
pushd src >/dev/null
75+
git reset --hard 0d230afe9c7a968c0f2d966ef9d4d396fee489bf
76+
popd >/dev/null
7477
mkdir -p src/build_overrides/ssl
7578
echo "" > src/build_overrides/ssl/ssl.gni
7679
echo $GNI_APPEND >> src/build_overrides/build.gni
@@ -84,7 +87,7 @@ download_and_build(){
8487

8588
export PATH="$PATH:$DEPOT_TOOLS"
8689
gclient sync --no-history
87-
pushd src >/dev/null
90+
pushd src >/dev/null
8891
gn gen out --args="$GN_ARGS"
8992
ninja -C out call default_task_queue_factory
9093
all=`find ./out/obj/ -name "*.o"`

source/core/owt_base/SsrcGenerator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
#include <set>
99

10+
#include "rtc_base/random.h"
1011
#include "rtc_base/synchronization/mutex.h"
1112
#include "rtc_base/thread_annotations.h"
12-
#include "rtc_base/random.h"
1313

1414
namespace owt_base {
1515

source/core/rtc_adapter/VideoSendAdapter.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,10 @@ bool VideoSendAdapterImpl::init()
180180
configuration.retransmission_rate_limiter = m_retransmissionRateLimiter.get();
181181
configuration.local_media_ssrc = m_ssrc; //rtp_config.ssrcs[i];
182182
// TODO: enable UlpfecGenerator
183+
// should follow similar logic as
184+
// webrtc/call/rtp_video_sender.cc:MaybeCreateFecGenerator()
185+
// for creating the fec genetator,
186+
// instead of hardcoding it to ulpfec_generator.
183187
/*
184188
std::make_unique<UlpfecGenerator>(
185189
rtp.ulpfec.red_payload_type, rtp.ulpfec.ulpfec_payload_type, clock);

0 commit comments

Comments
 (0)