Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Commit dc4a7ae

Browse files
authored
Fix bug 754&755 (#789)
1 parent 4941ef5 commit dc4a7ae

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

source/agent/conference/conference.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ var Conference = function (rpcClient, selfRpcId) {
253253
});
254254
});
255255
} else if (direction === 'out') {
256-
return addSubscription(sessionId, sessionInfo.locality, sessionInfo.transport, sessionInfo.media, sessionInfo.data, sessionInfo.info
256+
return addSubscription(sessionId, sessionInfo.locality, sessionInfo.media, sessionInfo.data, sessionInfo.info, sessionInfo.transport
257257
).then(() => {
258258
if (sessionInfo.info && sessionInfo.info.type !== 'webrtc') {
259259
if (sessionInfo.info.location) {
@@ -754,7 +754,7 @@ var Conference = function (rpcClient, selfRpcId) {
754754
return Promise.resolve('ok');
755755
};
756756

757-
const addSubscription = (id, locality, transport, mediaSpec, dataSpec, info) => {
757+
const addSubscription = (id, locality, mediaSpec, dataSpec, info, transport) => {
758758
if (!participants[info.owner]) {
759759
return Promise.reject('Participant early left');
760760
}
@@ -1311,7 +1311,7 @@ var Conference = function (rpcClient, selfRpcId) {
13111311
}
13121312

13131313
if (subDesc.type === 'sip') {
1314-
return addSubscription(subscriptionId, subDesc.transport, subDesc.locality, subDesc.media, subDesc.data, {owner: participantId, type: 'sip'})
1314+
return addSubscription(subscriptionId, subDesc.locality, subDesc.media, subDesc.data, {owner: participantId, type: 'sip'}, subDesc.transport)
13151315
.then((result) => {
13161316
callback('callback', result);
13171317
})
@@ -2459,6 +2459,7 @@ var Conference = function (rpcClient, selfRpcId) {
24592459
var subUpdate;
24602460
var muteReqs = [];
24612461
for (const cmd of commands) {
2462+
var exe;
24622463
switch (cmd.op) {
24632464
case 'replace':
24642465
if ((cmd.path === '/media/audio/status') && (cmd.value === 'inactive' || cmd.value === 'active')) {
@@ -2498,6 +2499,7 @@ var Conference = function (rpcClient, selfRpcId) {
24982499
} else {
24992500
return Promise.reject('Invalid path or value');
25002501
}
2502+
break;
25012503
default:
25022504
return Promise.reject('Invalid subscription control operation');
25032505
}

0 commit comments

Comments
 (0)