fixup! refactor: add GlobalsAccessor abstraction for OpenEMR globals access

Author: kojiromike

tests/E2E/RealVocabularyImportE2ETest.php

@@ -22,6 +22,7 @@
 namespace OpenCoreEMR\CLI\ImportCodes\Tests\E2E;
 
 use OpenCoreEMR\CLI\ImportCodes\Command\ImportCodesCommand;
+use OpenCoreEMR\CLI\ImportCodes\Config\GlobalsAccessor;
 use OpenCoreEMR\CLI\ImportCodes\Service\OpenEMRConnector;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\Test;
@@ -61,7 +62,7 @@ protected function setUp(): void
             $this->markTestSkipped('OpenEMR not available. Run inside Docker: task dev:start');
         }
 
-        $this->connector = new OpenEMRConnector();
+        $this->connector = new OpenEMRConnector(new GlobalsAccessor());
         try {
             $this->connector->initialize(self::OPENEMR_PATH, self::SITE);
         } catch (\Exception $e) {

tests/E2E/VocabularyImportE2ETest.php

@@ -17,6 +17,7 @@
 namespace OpenCoreEMR\CLI\ImportCodes\Tests\E2E;
 
 use OpenCoreEMR\CLI\ImportCodes\Command\ImportCodesCommand;
+use OpenCoreEMR\CLI\ImportCodes\Config\GlobalsAccessor;
 use OpenCoreEMR\CLI\ImportCodes\Service\OpenEMRConnector;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
@@ -52,7 +53,7 @@ protected function setUp(): void
             );
         }
 
-        $this->connector = new OpenEMRConnector();
+        $this->connector = new OpenEMRConnector(new GlobalsAccessor());
         try {
             $this->connector->initialize(self::OPENEMR_PATH, self::SITE);
         } catch (\Exception $e) {
@@ -268,7 +269,7 @@ public function cleanupRemovesTemporaryFiles(): void
         $this->assertEquals(0, $result);
 
         // Verify temp directory was cleaned up
-        $tempDir = $GLOBALS['temporary_files_dir'] . '/CQM_VALUESET';
+        $tempDir = $this->connector->getTempDir() . '/CQM_VALUESET';
         $this->assertDirectoryDoesNotExist($tempDir, 'Temp directory should be removed after cleanup');
     }
 

tests/Integration/ImportCodesIntegrationTest.php

@@ -17,6 +17,7 @@
 namespace OpenCoreEMR\CLI\ImportCodes\Tests\Integration;
 
 use OpenCoreEMR\CLI\ImportCodes\Command\ImportCodesCommand;
+use OpenCoreEMR\CLI\ImportCodes\Config\GlobalsAccessor;
 use OpenCoreEMR\CLI\ImportCodes\Service\CodeImporter;
 use OpenCoreEMR\CLI\ImportCodes\Service\MetadataDetector;
 use OpenCoreEMR\CLI\ImportCodes\Service\OpenEMRConnector;
@@ -54,7 +55,7 @@ protected function setUp(): void
         }
 
         // Try to initialize the connector
-        $this->connector = new OpenEMRConnector();
+        $this->connector = new OpenEMRConnector(new GlobalsAccessor());
         try {
             $this->connector->initialize(self::OPENEMR_PATH, self::SITE);
             $this->openemrAvailable = true;
@@ -92,7 +93,7 @@ public function openEmrConnectorCanGetTempDir(): void
     #[Test]
     public function codeImporterCanCheckIfVocabularyLoaded(): void
     {
-        $importer = new CodeImporter();
+        $importer = new CodeImporter(new GlobalsAccessor());
 
         // Should not throw exception when database is available
         $result = $importer->isVocabularyLoaded('RXNORM');
@@ -103,7 +104,7 @@ public function codeImporterCanCheckIfVocabularyLoaded(): void
     #[Test]
     public function codeImporterCanCheckIfAlreadyLoaded(): void
     {
-        $importer = new CodeImporter();
+        $importer = new CodeImporter(new GlobalsAccessor());
 
         // Check with fake data - should return false
         $result = $importer->isAlreadyLoaded(