Sync build-sdk from main, add diagnostic patch for SkipSamples UB

Author: Aliaksandr Adziareika

.github/actions/build-sdk/action.yml

@@ -30,6 +30,10 @@ inputs:
     description: 'Run tests after build'
     required: false
     default: 'false'
+  ctest-preset:
+    description: 'CTest preset name'
+    required: false
+    default: ''
 
 outputs:
   gtest-xml-path:
@@ -59,7 +63,7 @@ runs:
       uses: jwlawson/actions-setup-cmake@v2
 
     - name: Install Windows dependencies
-      if: runner.os == 'Windows'
+      if: runner.os == 'Windows' && inputs.additional-dependencies != ''
       shell: pwsh
       run: choco install ${{ inputs.additional-dependencies }} -y --no-progress
 
@@ -178,16 +182,19 @@ runs:
         echo "gtest-xml-path=$GTEST_XML_PATH" >> "$GITHUB_OUTPUT"
 
         CTEST_ARGS=""
+        if [ -n "${{ inputs.ctest-preset }}" ]; then
+          CTEST_ARGS="--preset ${{ inputs.ctest-preset }}"
+        fi
+
         if [ -n "$CMAKE_BUILD_TYPE" ]; then
-          CTEST_ARGS="--build-config $CMAKE_BUILD_TYPE"
+          CTEST_ARGS="$CTEST_ARGS --build-config $CMAKE_BUILD_TYPE"
         fi
 
-        # Use sudo if available (needed for tests requiring elevated privileges)
         SUDO_CMD=""
         if command -v sudo &> /dev/null; then
           SUDO_CMD="sudo -E"
         fi
 
         echo "::group::CTest"
-        $SUDO_CMD ctest --test-dir "$CMAKE_BUILD_PATH" --preset run_tests --output-on-failure $CTEST_ARGS
+        $SUDO_CMD ctest --test-dir "$CMAKE_BUILD_PATH" --output-on-failure $CTEST_ARGS
         echo "::endgroup::"

.github/patches/diagnose-skip-samples-ub.patch

@@ -0,0 +1,54 @@
+diff --git a/core/opendaq/reader/tests/test_stream_reader.cpp b/core/opendaq/reader/tests/test_stream_reader.cpp
+index 50c68c0b..b912eea7 100644
+--- a/core/opendaq/reader/tests/test_stream_reader.cpp
++++ b/core/opendaq/reader/tests/test_stream_reader.cpp
+@@ -1748,16 +1748,20 @@ TYPED_TEST(StreamReaderTest, SkipSamplesOnePacket)
+     {
+         for (size_t i = 0; i < 10; ++i)
+         {
+-            ASSERT_EQ(firstBatchSamples[i], TypeParam(typename TypeParam::Type(i * 11.1)));
+-            ASSERT_EQ(secondBatchSamples[i], TypeParam(typename TypeParam::Type((40 + i) * 11.1)));
++            TypeParam expectedFirst = TypeParam(typename TypeParam::Type(i * 11.1));
++            TypeParam expectedSecond = TypeParam(typename TypeParam::Type((40 + i) * 11.1));
++            ASSERT_EQ(firstBatchSamples[i], expectedFirst);
++            ASSERT_EQ(secondBatchSamples[i], expectedSecond);
+         }
+     }
+     else
+     {
+         for (size_t i = 0; i < 10; ++i)
+         {
+-            ASSERT_EQ(firstBatchSamples[i], (TypeParam)(i * 11.1));
+-            ASSERT_EQ(secondBatchSamples[i], (TypeParam) ((40 + i) * 11.1));
++            TypeParam expectedFirst = (TypeParam)(i * 11.1);
++            TypeParam expectedSecond = (TypeParam)((40 + i) * 11.1);
++            ASSERT_EQ(firstBatchSamples[i], expectedFirst);
++            ASSERT_EQ(secondBatchSamples[i], expectedSecond);
+         }
+     }
+ }
+@@ -1819,16 +1823,20 @@ TYPED_TEST(StreamReaderTest, SkipSamplesBetweenPackets)
+     {
+         for (size_t i = 0; i < 10; ++i)
+         {
+-            ASSERT_EQ(firstBatchSamples[i], TypeParam(typename TypeParam::Type(i * 11.1)));
+-            ASSERT_EQ(secondBatchSamples[i], TypeParam(typename TypeParam::Type((40 + i) * 11.1)));
++            TypeParam expectedFirst = TypeParam(typename TypeParam::Type(i * 11.1));
++            TypeParam expectedSecond = TypeParam(typename TypeParam::Type((40 + i) * 11.1));
++            ASSERT_EQ(firstBatchSamples[i], expectedFirst);
++            ASSERT_EQ(secondBatchSamples[i], expectedSecond);
+         }
+     }
+     else
+     {
+         for (size_t i = 0; i < 10; ++i)
+         {
+-            ASSERT_EQ(firstBatchSamples[i], (TypeParam) (i * 11.1));
+-            ASSERT_EQ(secondBatchSamples[i], (TypeParam) ((40 + i) * 11.1));
++            TypeParam expectedFirst = (TypeParam)(i * 11.1);
++            TypeParam expectedSecond = (TypeParam)((40 + i) * 11.1);
++            ASSERT_EQ(firstBatchSamples[i], expectedFirst);
++            ASSERT_EQ(secondBatchSamples[i], expectedSecond);
+         }
+     }
+ }

.github/workflows/ci-sandbox.yml

@@ -133,6 +133,7 @@ jobs:
           cmake-generator: ${{ matrix.cmake-generator }}
           enable-tests: true
           enable-32bit: ${{ matrix.enable-32bit == true }}
+          ctest-preset: ${{ env.ctest_preset }}
 
       # TODO: Remove this 1 step before merging to openDAQ/openDAQ
       - name: Show ccache statistics
@@ -222,6 +223,14 @@ jobs:
         shell: bash
         run: cp -r _ci-sandbox/.github/actions .github/
 
+      - name: Apply patches
+        if: github.repository != 'openDAQ/openDAQ'
+        shell: bash
+        run: |
+          for patch in _ci-sandbox/.github/patches/*.patch; do
+            [ -f "$patch" ] && git apply "$patch" && echo "Applied: $patch"
+          done
+
       - name: Setup ccache
         if: ${{ matrix.disable-ccache != true }}
         uses: openDAQ/openDAQ-CI-sandbox/.github/actions/ccache-setup@actions/ccache-setup
@@ -241,6 +250,7 @@ jobs:
           cmake-config-args: ${{ matrix.cmake-defines }}
           cmake-generator: ${{ matrix.cmake-generator }}
           enable-tests: true
+          ctest-preset: ${{ env.ctest_preset }}
 
       # TODO: Remove this 1 step before merging to openDAQ/openDAQ
       - name: Show ccache statistics
@@ -273,7 +283,7 @@ jobs:
             cmake-generator: Ninja
             cmake-build-type: Release
             cmake-defines: >-
-              -DCMAKE_C_COMPILER=clang 
+              -DCMAKE_C_COMPILER=clang
               -DCMAKE_CXX_COMPILER=clang++ 
               -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
               -DCMAKE_OSX_DEPLOYMENT_TARGET=10.15
@@ -284,8 +294,8 @@ jobs:
             cmake-generator: Ninja
             cmake-build-type: Release
             cmake-defines: >-
-              -DCMAKE_C_COMPILER=clang 
-              -DCMAKE_CXX_COMPILER=clang++ 
+              -DCMAKE_C_COMPILER=clang
+              -DCMAKE_CXX_COMPILER=clang++
               -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
               -DCMAKE_OSX_DEPLOYMENT_TARGET=10.15
             disable-ccache: 
@@ -310,6 +320,14 @@ jobs:
         shell: bash
         run: cp -r _ci-sandbox/.github/actions .github/
 
+      - name: Apply patches
+        if: github.repository != 'openDAQ/openDAQ'
+        shell: bash
+        run: |
+          for patch in _ci-sandbox/.github/patches/*.patch; do
+            [ -f "$patch" ] && git apply "$patch" && echo "Applied: $patch"
+          done
+
       - name: Setup ccache
         id: ccache-setup
         if: ${{ matrix.disable-ccache != true }}
@@ -354,11 +372,12 @@ jobs:
           cmake-config-args: ${{ matrix.cmake-defines }}
           cmake-generator: ${{ matrix.cmake-generator }}
           enable-tests: true
+          ctest-preset: ${{ env.ctest_preset }}
 
       # Save ccache on build failure to preserve compilation progress
       - name: Save ccache on failure
         if: failure() && matrix.disable-ccache != true
-        uses: actions/cache/save@v4
+        uses: actions/cache/save@v4q
         with:
           path: ${{ github.workspace }}/.ccache
           key: ${{ steps.ccache-setup.outputs.cache-key }}