test(nbp): Add request specs

Part of XI-6523

Author: nenock

spec/requests/users/nbp_wallet/connect_spec.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Users: NBPWallet: Connect', type: :request do
+  subject(:connect_request) { get '/users/nbp_wallet/connect' }
+
+  let(:uid) { 'example-uid' }
+  let(:session_params) { {saml_uid: uid, omniauth_provider: 'nbp'} }
+
+  before do
+    set_session(session_params)
+  end
+
+  context 'without errors' do
+    context 'with a pending Relationship' do
+      before do
+        allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return(Enmeshed::Relationship)
+      end
+
+      it 'redirects to #finalize' do
+        connect_request
+        expect(response).to redirect_to nbp_wallet_finalize_users_path
+      end
+    end
+
+    context 'without a pending Relationship' do
+      let(:truncated_reference) { 'RelationshipTemplateExampleTruncatedReferenceA==' }
+      let(:relationship_template) do
+        instance_double(Enmeshed::RelationshipTemplate,
+                        expires_at: 12.hours.from_now,
+                        nbp_uid: uid,
+                        truncated_reference:,
+                        url: "nmshd://tr##{truncated_reference}",
+                        qr_code_path: nbp_wallet_qr_code_users_path(truncated_reference:),
+                        remaining_validity: 12.hours.from_now - Time.zone.now,
+                        app_store_link: Settings.dig(:omniauth, :nbp, :enmeshed, :app_store_link),
+                        play_store_link: Settings.dig(:omniauth, :nbp, :enmeshed, :play_store_link))
+      end
+
+      before do
+        allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return([])
+        allow(Enmeshed::RelationshipTemplate).to receive(:create!).with(nbp_uid: uid).and_return(relationship_template)
+      end
+
+      it 'sets the correct template' do
+        connect_request
+        expect(response.body).to include 'RelationshipTemplateExampleTruncatedReferenceA=='
+      end
+    end
+  end
+
+  context 'with errors' do
+    # `Enmeshed::ConnectorError` is unknown until 'lib/enmeshed/connector.rb' is loaded, because it's defined there
+    require 'enmeshed/connector'
+
+    shared_examples 'an erroneous request' do |error_type|
+      it 'passes the error reason to Sentry' do
+        expect(Sentry).to receive(:capture_exception) do |e|
+          expect(e).to be_a error_type
+        end
+        connect_request
+      end
+
+      it 'redirects to #new_user_registration' do
+        expect(connect_request).to redirect_to new_user_registration_path
+      end
+
+      it 'displays an error message' do
+        connect_request
+        expect(flash[:alert]).to include I18n.t('common.errors.generic_try_later')
+      end
+    end
+
+    context 'without the session' do
+      let(:session_params) { {} }
+
+      before do
+        connect_request
+      end
+
+      it_behaves_like 'an unauthorized request'
+    end
+
+    context 'when the connector is down' do
+      before { allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_raise(Faraday::ConnectionFailed) }
+
+      it_behaves_like 'an erroneous request', Faraday::Error
+    end
+
+    context 'with an error when parsing the connector response' do
+      before { allow(Enmeshed::Connector).to receive(:pending_relationships).and_raise(Enmeshed::ConnectorError) }
+
+      it_behaves_like 'an erroneous request', Enmeshed::ConnectorError
+    end
+  end
+end

spec/requests/users/nbp_wallet/finalize_spec.rb

@@ -0,0 +1,177 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Account: NBPWallet: Finalize', type: :request do
+  subject(:finalize_request) { get '/users/nbp_wallet/finalize' }
+
+  let(:uid) { 'example-uid' }
+  let(:session_params) { {saml_uid: uid, omniauth_provider: 'nbp'} }
+
+  before do
+    set_session(session_params)
+  end
+
+  context 'without any errors' do
+    let(:relationship) do
+      instance_double(Enmeshed::Relationship,
+        accept!: true,
+        userdata: {
+          email: '[email protected]',
+          first_name: 'john',
+          last_name: 'oliver',
+          status_group: 'learner',
+        })
+    end
+
+    before do
+      allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return(relationship)
+      allow(relationship).to receive(:peer).and_return('id1EvvJ68x6wdHBwYrFTR31XtALHko9fnbyp')
+    end
+
+    it 'creates a user' do
+      expect { finalize_request }.to change(User, :count).by(1)
+    end
+
+    it 'creates two UserIdentities' do
+      expect { finalize_request }.to change(UserIdentity, :count).by(2)
+    end
+
+    it 'accepts the Relationship' do
+      expect(relationship).to receive(:accept!)
+      finalize_request
+    end
+
+    it 'sends a confirmation mail' do
+      expect { finalize_request }.to change(ActionMailer::Base.deliveries, :count).by(1)
+    end
+
+    it 'does not create a confirmed user' do
+      finalize_request
+      expect(User.order(:created_at).last).not_to be_confirmed
+    end
+
+    it 'asks the user to verify the email address' do
+      finalize_request
+      expect(response).to redirect_to home_index_path
+      expect(flash[:notice]).to include I18n.t('devise.registrations.signed_up_but_unconfirmed')
+    end
+  end
+
+  context 'with errors' do
+    shared_examples 'a handled erroneous request' do |error_message|
+      it 'redirects to the connect page' do
+        finalize_request
+        expect(response).to redirect_to nbp_wallet_connect_users_path
+      end
+
+      it 'displays an error message' do
+        finalize_request
+        expect(flash[:alert]).to eq error_message
+      end
+
+      it 'does not send a confirmation mail' do
+        expect { finalize_request }.not_to change(ActionMailer::Base, :deliveries)
+      end
+    end
+
+    shared_examples 'a documented erroneous request' do |error|
+      it 'passes the error reason to Sentry' do
+        expect(Sentry).to receive(:capture_exception) do |e|
+          expect(e).to be_a error
+        end
+        finalize_request
+      end
+    end
+
+    context 'without the session' do
+      let(:session_params) { {} }
+
+      before do
+        finalize_request
+      end
+
+      it_behaves_like 'an unauthorized request'
+    end
+
+    context 'when the connector is down' do
+      before { allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_raise(Faraday::ConnectionFailed) }
+
+      it 'redirects to the connect page' do
+        finalize_request
+        expect(response).to redirect_to(nbp_wallet_connect_users_path)
+      end
+    end
+
+    context 'when an attribute is missing' do
+      # `Enmeshed::ConnectorError` is unknown until 'lib/enmeshed/connector.rb' is loaded, because it's defined there
+      require 'enmeshed/connector'
+
+      let(:relationship) do
+        instance_double(Enmeshed::Relationship, accept!: false, reject!: true)
+      end
+
+      before do
+        allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return(relationship)
+        allow(relationship).to receive(:userdata).and_raise(Enmeshed::ConnectorError, 'EMailAddress must not be empty')
+      end
+
+      it_behaves_like 'a handled erroneous request', I18n.t('common.errors.generic')
+      it_behaves_like 'a documented erroneous request', Enmeshed::ConnectorError
+    end
+
+    context 'when the RelationshipChange cannot be accepted' do
+      let(:relationship) do
+        instance_double(Enmeshed::Relationship,
+          accept!: false,
+          reject!: true,
+          userdata: {
+            email: '[email protected]',
+            first_name: 'john',
+            last_name: 'oliver',
+            status_group: 'learner',
+          })
+      end
+
+      before do
+        allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return(relationship)
+        allow(relationship).to receive(:peer).and_return('id1EvvJ68x6wdHBwYrFTR31XtALHko9fnbyp')
+      end
+
+      it_behaves_like 'a handled erroneous request', I18n.t('common.errors.generic')
+
+      it 'does not create a user' do
+        expect { finalize_request }.not_to change(User, :count)
+      end
+
+      it 'creates no UserIdentities' do
+        expect { finalize_request }.not_to change(UserIdentity, :count)
+      end
+
+      it 'rejects the Relationship' do
+        expect(relationship).to receive(:reject!)
+        finalize_request
+      end
+
+      context 'when the RelationshipChange cannot be rejected either' do
+        before { allow(relationship).to receive(:reject!).and_raise(Faraday::ConnectionFailed) }
+
+        it_behaves_like 'a handled erroneous request', I18n.t('common.errors.generic')
+        it_behaves_like 'a documented erroneous request', Faraday::ConnectionFailed
+
+        it 'does not create a user' do
+          expect { finalize_request }.not_to change(User, :count)
+        end
+
+        it 'creates no UserIdentities' do
+          expect { finalize_request }.not_to change(UserIdentity, :count)
+        end
+
+        it 'does not try to reject the Relationship again' do
+          expect(relationship).to receive(:reject!).once
+          finalize_request
+        end
+      end
+    end
+  end
+end

spec/requests/users/nbp_wallet/qr_code_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Account: NBPWallet: QRCode', type: :request do
+  subject(:qr_code_request) { get '/users/nbp_wallet/qr_code', params: {truncated_reference:} }
+
+  let(:uid) { 'example-uid' }
+  let(:session_params) { {saml_uid: uid, omniauth_provider: 'nbp'} }
+
+  let(:truncated_reference) { 'example_truncated_reference' }
+  let(:qr_code) { RQRCode::QRCode.new("nmshd://tr##{truncated_reference}").as_png(border_modules: 0) }
+  let(:relationship_template) do
+    instance_double(Enmeshed::RelationshipTemplate, qr_code:)
+  end
+
+  before do
+    set_session(session_params)
+    allow(Enmeshed::RelationshipTemplate).to receive(:new).with(truncated_reference:).and_return(relationship_template)
+  end
+
+  it 'returns a png image' do
+    qr_code_request
+    expect(response.content_type).to eq 'image/png'
+  end
+
+  it 'initializes a RelationshipTemplate' do
+    expect(Enmeshed::RelationshipTemplate).to receive(:new)
+    qr_code_request
+  end
+
+  it 'sends the qr code' do
+    qr_code_request
+    expect(response.body).to eq qr_code.to_s
+  end
+
+  context 'without the session' do
+    let(:session_params) { {} }
+
+    before do
+      qr_code_request
+    end
+
+    it_behaves_like 'an unauthorized request'
+  end
+end

spec/requests/users/nbp_wallet/relationship_status_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Account: NBPWallet: RelationshipStatus', type: :request do
+  subject(:relationship_status_request) { get '/users/nbp_wallet/relationship_status' }
+
+  let(:uid) { 'example_uid' }
+  let(:session_params) { {saml_uid: uid, omniauth_provider: 'nbp'} }
+
+  before do
+    set_session(session_params)
+  end
+
+  context 'without errors' do
+    context 'with a Relationship' do
+      before { allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return(Enmeshed::Relationship) }
+
+      it 'returns a json with the ready status' do
+        relationship_status_request
+        expect(response.parsed_body['status']).to eq 'ready'
+      end
+    end
+
+    context 'without a Relationship' do
+      before do
+        allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_return([])
+      end
+
+      it 'returns a json with the waiting status' do
+        relationship_status_request
+        expect(response.parsed_body['status']).to eq 'waiting'
+      end
+    end
+  end
+
+  context 'with errors' do
+    # `Enmeshed::ConnectorError` is unknown until 'lib/enmeshed/connector.rb' is loaded, because it's defined there
+    require 'enmeshed/connector'
+
+    context 'without the session' do
+      let(:session_params) { {} }
+
+      before do
+        relationship_status_request
+      end
+
+      it_behaves_like 'an unauthorized request'
+    end
+
+    context 'when the connector is down' do
+      before { allow(Enmeshed::Relationship).to receive(:pending_for).with(uid).and_raise(Faraday::ConnectionFailed) }
+
+      it 'redirects to the connect page' do
+        relationship_status_request
+        expect(response).to redirect_to(nbp_wallet_connect_users_path)
+      end
+    end
+
+    context 'with an error when parsing the connector response' do
+      before { allow(Enmeshed::Connector).to receive(:pending_relationships).and_raise(Enmeshed::ConnectorError) }
+
+      it 'redirects to the connect page' do
+        relationship_status_request
+        expect(response).to redirect_to(nbp_wallet_connect_users_path)
+      end
+    end
+  end
+end