Skip to content

Commit 1bfd28c

Browse files
committed
Migrate .js.erb files to .js
1 parent 3185a61 commit 1bfd28c

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
max_label_length = <%= Label::MAX_LENGTH %>
1+
get_max_label_length = ->
2+
if (this._max_label_length == undefined)
3+
this._max_label_length = $('#label-settings').data('max-length');
4+
return this._max_label_length;
25

36
verify_label_name = (label_name) ->
47
if label_name == ''
58
return I18n.t('labels.javascripts.cannot_be_empty');
6-
if label_name.length > max_label_length
9+
if label_name.length > get_max_label_length()
710
return I18n.t('labels.javascripts.too_long');
811
return I18n.t('labels.javascripts.ok');
912

@@ -20,7 +23,7 @@ ready = ->
2023
tags: true
2124
multiple: true
2225
maximumSelectionLength: 10
23-
maximumInputLength: max_label_length
26+
maximumInputLength: get_max_label_length()
2427
closeOnSelect: false
2528
tokenSeparators: [',']
2629

app/views/labels/index.html.slim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
.col-md-5
1818
div
1919
.input-group
20+
#label-settings.d-none data-max-length=Label::MAX_LENGTH
2021
= button_tag t('.merge'), type: 'button', id: 'merge-labels-button', disabled: true, class: 'btn btn-primary'
2122
input.form-control#merge-labels-input type='text' placeholder=t('.new_name')
2223

app/views/tasks/_form.html.slim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
= group.name
8383

8484
.field-element
85+
#label-settings.d-none data-max-length=Label::MAX_LENGTH
8586
= f.label :labels, Label.model_name.human(count: :many), class: 'form-label'
8687
= f.select :label_names, options_for_select(@task.labels.map {|l| [l.name, l.name, {label_color: l.color, label_font_color: l.font_color}] }, @task.labels.map(&:name)), {}, {class: 'labels-select2-tag form-control', multiple: 'multiple'}
8788

0 commit comments

Comments
 (0)