Consistently use net_http_persistent with a memorized Faraday object

Author: MrSerth

Gemfile

@@ -10,6 +10,7 @@ gem 'coffee-rails', require: false
 gem 'config'
 gem 'devise-bootstrap-views'
 gem 'faraday'
+gem 'faraday-net_http_persistent'
 gem 'http_accept_language'
 gem 'i18n-js'
 gem 'image_processing'

Gemfile.lock

@@ -167,6 +167,9 @@ GEM
       multipart-post (~> 2.0)
     faraday-net_http (3.4.0)
       net-http (>= 0.5.0)
+    faraday-net_http_persistent (2.3.0)
+      faraday (~> 2.5)
+      net-http-persistent (>= 4.0.4, < 5)
     ffi (1.17.1)
     fugit (1.11.1)
       et-orbi (~> 1, >= 1.2.11)
@@ -276,6 +279,8 @@ GEM
       rails (>= 3.2.0)
     net-http (0.6.0)
       uri
+    net-http-persistent (4.0.5)
+      connection_pool (~> 2.2)
     net-imap (0.5.6)
       date
       net-protocol
@@ -613,6 +618,7 @@ DEPENDENCIES
   devise-bootstrap-views
   factory_bot_rails
   faraday
+  faraday-net_http_persistent
   http_accept_language
   i18n-js
   i18n-tasks
@@ -741,6 +747,7 @@ CHECKSUMS
   faraday (2.12.2) sha256=157339c25c7b8bcb739f5cf1207cb0cefe8fa1c65027266bcbc34c90c84b9ad6
   faraday-multipart (1.1.0) sha256=856b0f1c7316a4d6c052dd2eef5c42f887d56d93a171fe8880da1af064ca0751
   faraday-net_http (3.4.0) sha256=a1f1e4cd6a2cf21599c8221595e27582d9936819977bbd4089a601f24c64e54a
+  faraday-net_http_persistent (2.3.0) sha256=33d4948cabe9f8148222c4ca19634c71e1f25595cccf9da2e02ace8d754f1bb1
   ffi (1.17.1) sha256=26f6b0dbd1101e6ffc09d3ca640b2a21840cc52731ad8a7ded9fb89e5fb0fc39
   fugit (1.11.1) sha256=e89485e7be22226d8e9c6da411664d0660284b4b1c08cacb540f505907869868
   glob (0.4.1) sha256=e68e50419ffb7f896b39a483c1a37e7a1aa8f1a8c8ea13961f8cd1b50f40715d
@@ -787,6 +794,7 @@ CHECKSUMS
   nested_form (0.3.2) sha256=b1c468d7eac781235861c2f74fc9f675df0c4d915d5724aaf7fd29f7891c0538
   nested_form_fields (0.8.4) sha256=e3db8e935b40c6b6027ce65b10ee0c5cf575d1ba175be85154c81d4253635b19
   net-http (0.6.0) sha256=9621b20c137898af9d890556848c93603716cab516dc2c89b01a38b894e259fb
+  net-http-persistent (4.0.5) sha256=6e42880b347e650ffeaf679ae59c9d5a6ed8a22cda6e1b959d9c270050aefa8e
   net-imap (0.5.6) sha256=1ede8048ee688a14206060bf37a716d18cb6ea00855f6c9b15daee97ee51fbe5
   net-pop (0.1.2) sha256=848b4e982013c15b2f0382792268763b748cce91c9e91e36b0f27ed26420dff3
   net-protocol (0.2.2) sha256=aa73e0cba6a125369de9837b8d8ef82a61849360eba0521900e2c3713aa162a8

app/services/task_service.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class TaskService < ServiceBase
+  def self.connection
+    @connection ||= Faraday.new do |faraday|
+      faraday.options[:open_timeout] = 5
+      faraday.options[:timeout] = 5
+
+      faraday.adapter :net_http_persistent
+    end
+  end
+end

app/services/task_service/check_external.rb

@@ -1,19 +1,16 @@
 # frozen_string_literal: true
 
-module TaskService
-  class CheckExternal < ServiceBase
+class TaskService
+  class CheckExternal < TaskService
     def initialize(uuid:, account_link:)
       super()
       @uuid = uuid
       @account_link = account_link
     end
 
     def execute
-      response = connection.post do |req|
-        req.headers['Content-Type'] = 'application/json'
-        req.headers['Authorization'] = authorization_header
-        req.body = {uuid: @uuid}.to_json
-      end
+      body = {uuid: @uuid}.to_json
+      response = self.class.connection.post(@account_link.check_uuid_url) {|request| request_parameters(request, body) }
       response_hash = JSON.parse(response.body, symbolize_names: true).slice(:uuid_found, :update_right)
 
       {error: false, message: message(response_hash)}.merge(response_hash)
@@ -23,8 +20,12 @@ def execute
 
     private
 
-    def authorization_header
-      "Bearer #{@account_link.api_key}"
+    def request_parameters(request, body)
+      request.tap do |req|
+        req.headers['Content-Type'] = 'application/json'
+        req.headers['Authorization'] = "Bearer #{@account_link.api_key}"
+        req.body = body
+      end
     end
 
     def message(response_hash)
@@ -38,14 +39,5 @@ def message(response_hash)
         I18n.t('tasks.task_service.check_external.no_task')
       end
     end
-
-    def connection
-      Faraday.new(url: @account_link.check_uuid_url) do |faraday|
-        faraday.options[:open_timeout] = 5
-        faraday.options[:timeout] = 5
-
-        faraday.adapter Faraday.default_adapter
-      end
-    end
   end
 end

app/services/task_service/handle_groups.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module TaskService
+class TaskService
   class HandleGroups < ServiceBase
     def initialize(user:, task:, group_tasks_params:)
       super()

app/services/task_service/push_external.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-module TaskService
-  class PushExternal < ServiceBase
+class TaskService
+  class PushExternal < TaskService
     def initialize(zip:, account_link:)
       super()
       @zip = zip
@@ -11,7 +11,7 @@ def initialize(zip:, account_link:)
     def execute
       body = @zip.string
       begin
-        response = connection.post {|request| request_parameters(request, body) }
+        response = self.class.connection.post(@account_link.push_url) {|request| request_parameters(request, body) }
         response.success? ? nil : response.body
       rescue StandardError => e
         e
@@ -28,11 +28,5 @@ def request_parameters(request, body)
         req.body = body
       end
     end
-
-    def connection
-      Faraday.new(url: @account_link.push_url) do |faraday|
-        faraday.adapter Faraday.default_adapter
-      end
-    end
   end
 end

lib/nbp/push_connector.rb

@@ -116,7 +116,12 @@ def auth
     end
 
     def api_conn
-      Faraday.new(url: settings.api_host, headers:)
+      @api_conn ||= Faraday.new(url: settings.api_host, headers:) do |faraday|
+        faraday.options[:open_timeout] = 5
+        faraday.options[:timeout] = 5
+
+        faraday.adapter :net_http_persistent
+      end
     end
 
     def source_slug