Lint: Use parentheses for button_to calls in views

MrSerth · MrSerth · commit 5390999a5761 · 2025-07-09T13:12:41.000+02:00
diff --git a/app/views/account_links/show.html.slim b/app/views/account_links/show.html.slim
@@ -30,7 +30,7 @@
                   .table-list
                     = shared_user.email
                     .btn-group.float-end
-                      = button_to remove_shared_user_user_account_link_path, method: :post, params: {shared_user: shared_user.id}, data: {confirm: t('common.sure')}, class: 'btn btn-light btn-sm', remote: true, form_class: 'remove-account-link-form' do
+                      = button_to(remove_shared_user_user_account_link_path, method: :post, params: {shared_user: shared_user.id}, data: {confirm: t('common.sure')}, class: 'btn btn-light btn-sm', remote: true, form_class: 'remove-account-link-form') do
                         i.fa-solid.fa-trash-can
                         =< t('common.button.remove')
 
@@ -39,7 +39,7 @@
     = link_to edit_user_account_link_path(@user, @account_link), class: 'btn btn-important' do
       i.fa-solid.fa-pen-to-square
       =< t('common.button.edit')
-    = button_to user_account_link_path(@user, @account_link), class: 'btn btn-important h-100', method: :delete, data: {confirm: t('common.sure')} do
+    = button_to(user_account_link_path(@user, @account_link), class: 'btn btn-important h-100', method: :delete, data: {confirm: t('common.sure')}) do
       i.fa-solid.fa-trash-can.text-danger
       =< t('common.button.delete')
   = link_to t('common.button.back'), user_path(@user), class: 'btn btn-important'
diff --git a/app/views/application/_session.html.slim b/app/views/application/_session.html.slim
@@ -14,7 +14,7 @@
           - if current_user.unread_messages_count != '0'
             span.menu-number
               = current_user.unread_messages_count
-  li.nav-item = button_to t('.button.log_out'), destroy_user_session_path, method: :delete, class: 'nav-link px-3', data: {turbo: false}
+  li.nav-item = button_to(t('.button.log_out'), destroy_user_session_path, method: :delete, class: 'nav-link px-3', data: {turbo: false})
 - else
   = render('navigation_collection_link', target: :new_user_registration_path, text: t('common.button.sign_up'), icon: 'fa-user', cached: true)
   = render('navigation_collection_link', target: :new_user_session_path, text: t('common.button.log_in'), icon: 'fa-right-to-bracket', cached: true)
diff --git a/app/views/collections/_collections.html.slim b/app/views/collections/_collections.html.slim
@@ -34,7 +34,7 @@
               - else
                 = render_markdown(collection.description)
             .more-btn-wrapper
-              = button_to collection, class: 'more-btn' do
+              = button_to(collection, class: 'more-btn') do
                 .more-tag
                   = t('common.button.show_more')
                   span.fa-solid.fa-caret-down.ms-1
diff --git a/app/views/collections/_form.html.slim b/app/views/collections/_form.html.slim
@@ -52,7 +52,7 @@
           i.fa-solid.fa-folder-open
           =< t('.button.save')
         - if @collection.tasks.present?
-          = button_to remove_all_collection_path(@collection), method: :patch, data: {confirm: t('common.sure')}, class: 'btn btn-important h-100' do
+          = button_to(remove_all_collection_path(@collection), method: :patch, data: {confirm: t('common.sure')}, class: 'btn btn-important h-100') do
             i.fa-solid.fa-xmark.text-danger
             =< t('.button.remove_all')
         = link_to :back, class: 'btn btn-important' do
diff --git a/app/views/collections/show.html.slim b/app/views/collections/show.html.slim
@@ -36,7 +36,7 @@
         - else
           = render_markdown(@collection.description)
       .more-btn-wrapper
-        = button_to @collection, class: 'more-btn' do
+        = button_to(@collection, class: 'more-btn') do
           .more-tag
             = t('common.button.show_more')
             span.fa-solid.fa-caret-down.ms-1
@@ -74,7 +74,7 @@
   .col-md-12.mb-4
     .actions.btn-group role='group'
       - if action_name == 'view_shared'
-        = button_to t('.button.collaborate'), save_shared_collection_path(@collection), method: :post, class: 'btn btn-important h-100'
+        = button_to(t('.button.collaborate'), save_shared_collection_path(@collection), method: :post, class: 'btn btn-important h-100')
         = link_to t('common.button.back'), user_messages_path(current_user), class: 'btn btn-important'
       - else
         - if policy(@collection).edit?
@@ -120,9 +120,9 @@
             i.fa-solid.fa-pen-to-square
             =< t('common.button.edit')
           - if @collection.users.include? current_user
-            = button_to leave_collection_path(@collection), class: 'btn btn-important h-100', method: :post, data: {confirm: @collection.users.size == 1 ? t('.leave.deletion_warning') : t('common.sure')} do
+            = button_to(leave_collection_path(@collection), class: 'btn btn-important h-100', method: :post, data: {confirm: @collection.users.size == 1 ? t('.leave.deletion_warning') : t('common.sure')}) do
               = @collection.users.size == 1 ? t('.button.delete') : t('.button.leave')
-        = button_to toggle_favorite_collection_path(@collection), class: 'btn btn-important h-100', method: :post do
+        = button_to(toggle_favorite_collection_path(@collection), class: 'btn btn-important h-100', method: :post) do
           - if current_user.favorite_collections.include?(@collection)
             i.fa-regular.fa-star
             =< t('.button.unfavorite')
diff --git a/app/views/comments/_edit.html.slim b/app/views/comments/_edit.html.slim
@@ -7,6 +7,6 @@
         = button_tag type: 'submit', class: 'btn btn-light btn-sm' do
           i.fa-solid.fa-floppy-disk
           =< t('common.button.save')
-        = button_to task_comment_path(@task, @comment), class: 'btn btn-light btn-sm', method: :delete, remote: true, data: {confirm: t('common.sure')}
+        = button_to(task_comment_path(@task, @comment), class: 'btn btn-light btn-sm', method: :delete, remote: true, data: {confirm: t('common.sure')})
           i.fa-solid.fa-trash-can
           =< t('common.button.delete')
diff --git a/app/views/comments/_task_comments.html.slim b/app/views/comments/_task_comments.html.slim
@@ -20,7 +20,7 @@
             = link_to edit_task_comment_path(@task, comment), class: 'btn btn-light btn-sm', remote: true do
               i.fa-solid.fa-pen-to-square
               =< t('common.button.edit')
-            = button_to task_comment_path(@task, comment), class: 'btn btn-light btn-sm', method: :delete, remote: true, data: {confirm: t('common.sure')}
+            = button_to(task_comment_path(@task, comment), class: 'btn btn-light btn-sm', method: :delete, remote: true, data: {confirm: t('common.sure')})
               i.fa-solid.fa-trash-can
               =< t('common.button.delete')
       .more-btn-wrapper
diff --git a/app/views/groups/_groups.html.slim b/app/views/groups/_groups.html.slim
@@ -34,11 +34,11 @@
               - if policy(group).edit?
                 = link_to edit_group_path(group), class: 'btn btn-light', data: {bs_toggle: 'tooltip', bs_placement: 'top', bs_title: t('common.button.edit')} do
                   i.fas.fa-edit aria-hidden="true"
-                = button_to group, class: 'btn btn-light', method: :delete, data: {bs_toggle: 'tooltip', bs_placement: 'top', bs_title: t('common.button.delete')} do
+                = button_to(group, class: 'btn btn-light', method: :delete, data: {bs_toggle: 'tooltip', bs_placement: 'top', bs_title: t('common.button.delete')}) do
                   i.fas.fa-trash-alt aria-hidden="true"
 
             - elsif group.applicants.include?(current_user)
               = t('.wait_to_get_accepted')
             - else
-              = button_to t('groups.shared.button.request_membership'), request_access_group_path(group), method: :post, class: 'btn btn-light'
+              = button_to(t('groups.shared.button.request_membership'), request_access_group_path(group), method: :post, class: 'btn btn-light')
 = render('shared/pagination', collection: @groups)
diff --git a/app/views/groups/_share_account_link_button.html.slim b/app/views/groups/_share_account_link_button.html.slim
@@ -1,8 +1,8 @@
 - if shared_user.shared_account_links.include?(account_link)
-  = button_to remove_shared_user_user_account_link_path(current_user, account_link), method: :post, params: {shared_user: shared_user.id}, form_class: 'share-account-link-form', class: 'dropdown-item account-link-share', remote: true, title: t('.unshare_tooltip', account_link: account_link.name, user: shared_user.email) do
+  = button_to(remove_shared_user_user_account_link_path(current_user, account_link), method: :post, params: {shared_user: shared_user.id}, form_class: 'share-account-link-form', class: 'dropdown-item account-link-share', remote: true, title: t('.unshare_tooltip', account_link: account_link.name, user: shared_user.email)) do
     i.fa-solid.fa-square-check
     =< account_link.name
 - else
-  = button_to add_shared_user_user_account_link_path(current_user, account_link), method: :post, params: {shared_user: shared_user.id}, form_class: 'share-account-link-form', class: 'dropdown-item account-link-share', remote: true, title: t('.share_tooltip', account_link: account_link.name, user: shared_user.email) do
+  = button_to(add_shared_user_user_account_link_path(current_user, account_link), method: :post, params: {shared_user: shared_user.id}, form_class: 'share-account-link-form', class: 'dropdown-item account-link-share', remote: true, title: t('.share_tooltip', account_link: account_link.name, user: shared_user.email)) do
     i.fa-solid.fa-square
     =< account_link.name
diff --git a/app/views/groups/show.html.slim b/app/views/groups/show.html.slim
@@ -16,7 +16,7 @@
         .table-list
           => admin.email
           - if policy(@group).demote_admin? && @group.admins.length > 1
-            = button_to demote_admin_group_path(group: @group, user: admin), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm', data: {confirm: admin == current_user ? t('.demote_yourself.confirm') : t('.demote_admin.confirm')} do
+            = button_to(demote_admin_group_path(group: @group, user: admin), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm', data: {confirm: admin == current_user ? t('.demote_yourself.confirm') : t('.demote_admin.confirm')}) do
               i.fa-solid.fa-arrow-down
               =< (admin == current_user ? t('.button.demote_yourself') : t('.button.demote_admin'))
 
@@ -30,10 +30,10 @@
             => member.email
             - if policy(@group).edit?
               - if @group.group_membership_for(member).role_confirmed_member?
-                = button_to make_admin_group_path(group: @group, user: member), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm' do
+                = button_to(make_admin_group_path(group: @group, user: member), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm') do
                   i.fa-solid.fa-plus
                   =< t('.button.make_admin')
-              = button_to delete_from_group_group_path(group: @group, user: member), method: :patch, form_class: 'd-inline-block', class: 'btn btn-light btn-sm' do
+              = button_to(delete_from_group_group_path(group: @group, user: member), method: :patch, form_class: 'd-inline-block', class: 'btn btn-light btn-sm') do
                 i.fa-solid.fa-xmark
                 =< t('common.button.remove')
       - else
@@ -50,10 +50,10 @@
             .table-list
               => user.email
               .btn-group.float-end
-                = button_to grant_access_group_path(group: @group, user:), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm' do
+                = button_to(grant_access_group_path(group: @group, user:), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm') do
                   i.fa-solid.fa-plus
                   =< t('.button.grant_access')
-                = button_to deny_access_group_path(group: @group, user:), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm' do
+                = button_to(deny_access_group_path(group: @group, user:), method: :post, form_class: 'd-inline-block', class: 'btn btn-light btn-sm') do
                   i.fa-solid.fa-xmark
                   =< t('.button.deny_access')
         - else
@@ -67,7 +67,7 @@
             .btn-group
               = link_to task.title, task_path(task), class: 'btn btn-light'
               - if policy(@group).remove_task?
-                = button_to remove_task_group_path(task:), method: :patch, form_class: 'd-inline-block', class: 'btn btn-light' do
+                = button_to(remove_task_group_path(task:), method: :patch, form_class: 'd-inline-block', class: 'btn btn-light') do
                   i.fa-solid.fa-xmark.text-secondary
       - else
         = t('.has_no_tasks')
@@ -76,14 +76,14 @@
   .col-md-12.mb-4
     .actions.btn-group role='group'
       - if policy(@group).request_access?
-        = button_to t('groups.shared.button.request_membership'), request_access_group_path(@group), method: :post, class: 'btn btn-important h-100'
+        = button_to(t('groups.shared.button.request_membership'), request_access_group_path(@group), method: :post, class: 'btn btn-important h-100')
       - if policy(@group).edit?
         = link_to edit_group_path(@group), class: 'btn btn-important' do
           i.fa-solid.fa-pen-to-square
           =< t('common.button.edit')
-        = button_to group_path(@group), class: 'btn btn-important h-100', method: :delete, data: {confirm: t('common.sure')} do
+        = button_to(group_path(@group), class: 'btn btn-important h-100', method: :delete, data: {confirm: t('common.sure')}) do
           i.fa-solid.fa-trash-can.text-danger
           =< t('.button.delete_group')
       - if policy(@group).leave?
-        = button_to t('.button.leave'), leave_group_path(@group), method: :post, class: "leave-btn btn btn-important h-100 #{'disabled' if @group.last_admin?(current_user)}", data: {confirm: t('common.sure')}
+        = button_to(t('.button.leave'), leave_group_path(@group), method: :post, class: "leave-btn btn btn-important h-100 #{'disabled' if @group.last_admin?(current_user)}", data: {confirm: t('common.sure')})
       = link_to t('common.button.back'), :back, class: 'btn btn-important'
diff --git a/app/views/messages/index.html.slim b/app/views/messages/index.html.slim
@@ -45,13 +45,13 @@ br
               - if message.attachment.present?
                 - if message.action_collection_shared?
                   = link_to t('.button.view'), view_shared_collection_path(message.attachment, user: message.sender), class: 'btn btn-light btn-sm'
-                  = button_to t('.button.save_collection'), save_shared_collection_path(message.attachment), method: :post, class: 'btn btn-light btn-sm'
+                  = button_to(t('.button.save_collection'), save_shared_collection_path(message.attachment), method: :post, class: 'btn btn-light btn-sm')
                 - if message.action_group_request?
                   = link_to t('.button.view'), group_path(message.attachment), class: 'btn btn-light btn-sm'
-                  = button_to grant_access_group_path(message.attachment, user: message.sender.id), method: :post, class: 'btn btn-light btn-sm' do
+                  = button_to(grant_access_group_path(message.attachment, user: message.sender.id), method: :post, class: 'btn btn-light btn-sm') do
                     i.fa-solid.fa-plus.text-success
                     =< t('.button.grant_access')
-                  = button_to deny_access_group_path(message.attachment, user: message.sender.id), method: :post, class: 'btn btn-light btn-sm' do
+                  = button_to(deny_access_group_path(message.attachment, user: message.sender.id), method: :post, class: 'btn btn-light btn-sm') do
                     i.fa-solid.fa-xmark.text-danger
                     =< t('.button.deny_access')
                 - if message.action_group_approval?
@@ -63,7 +63,7 @@ br
                 = link_to reply_user_messages_path(recipient: message.sender), class: 'btn btn-light btn-sm' do
                   i.fa-solid.fa-reply
                   =< t('.button.reply')
-              = button_to user_message_path(current_user, message, option: @option), method: :delete, class: 'btn btn-light btn-sm', data: {confirm: t('common.sure')} do
+              = button_to(user_message_path(current_user, message, option: @option), method: :delete, class: 'btn btn-light btn-sm', data: {confirm: t('common.sure')}) do
                 i.fa-solid.fa-trash-can
                 =< t('common.button.delete')
   = render('shared/pagination', collection: @messages)
diff --git a/app/views/tasks/_tasks.html.slim b/app/views/tasks/_tasks.html.slim
@@ -51,7 +51,7 @@
               - else
                 = render_markdown(task.description)
             .more-btn-wrapper
-              = button_to task, class: 'more-btn' do
+              = button_to(task, class: 'more-btn') do
                 .more-tag
                   = t('common.button.show_more')
                   span.fa-solid.fa-caret-down.ms-1
@@ -68,7 +68,7 @@
               = link_to task.url_for(:edit), class: 'btn btn-light', data: {bs_toggle: 'tooltip', bs_placement: 'top', bs_title: t('common.button.edit')} do
                 i.fas.fa-edit aria-hidden="true"
             - if policy(task).destroy?
-              = button_to task.url_for(:destroy), class: 'btn btn-light', method: :delete, data: {bs_toggle: 'tooltip', bs_placement: 'top', bs_title: t('common.button.delete'), confirm: t('common.sure')} do
+              = button_to(task.url_for(:destroy), class: 'btn btn-light', method: :delete, data: {bs_toggle: 'tooltip', bs_placement: 'top', bs_title: t('common.button.delete'), confirm: t('common.sure')}) do
                 i.fas.fa-trash-alt aria-hidden="true"
 
     .card-footer.d-flex.align-items-center.pe-2
diff --git a/app/views/tasks/show.html.slim b/app/views/tasks/show.html.slim
diff --git a/app/views/users/nbp_wallet/connect.html.slim b/app/views/users/nbp_wallet/connect.html.slim
diff --git a/app/views/users/registrations/edit.html.slim b/app/views/users/registrations/edit.html.slim
diff --git a/app/views/users/shared/_links.html.slim b/app/views/users/shared/_links.html.slim
diff --git a/app/views/users/shared/_notification_modal.html.slim b/app/views/users/shared/_notification_modal.html.slim
diff --git a/app/views/users/show.html.slim b/app/views/users/show.html.slim
