1320: Remove autosave causing unnecessary N+1 queries

Author: kkoehn

app/models/concerns/file_concern.rb

@@ -4,7 +4,7 @@ module FileConcern
   extend ActiveSupport::Concern
 
   included do
-    has_many :files, as: :fileable, class_name: 'TaskFile', dependent: :destroy, autosave: true, inverse_of: :fileable
+    has_many :files, as: :fileable, class_name: 'TaskFile', dependent: :destroy, inverse_of: :fileable
     accepts_nested_attributes_for :files, allow_destroy: true
   end
 

app/models/model_solution.rb

@@ -5,7 +5,7 @@ class ModelSolution < ApplicationRecord
   include TransferValues
   include ParentValidation
 
-  belongs_to :task, autosave: true, inverse_of: :model_solutions
+  belongs_to :task, inverse_of: :model_solutions
   belongs_to :parent, class_name: 'ModelSolution', optional: true
   has_many :files, as: :fileable, class_name: 'TaskFile', dependent: :destroy
   accepts_nested_attributes_for :files, allow_destroy: true

app/models/task_file.rb

@@ -4,7 +4,7 @@ class TaskFile < ApplicationRecord
   include ParentValidation
   include TransferValues
 
-  belongs_to :fileable, polymorphic: true, autosave: true, inverse_of: :files
+  belongs_to :fileable, polymorphic: true, inverse_of: :files
   belongs_to :parent, class_name: 'TaskFile', optional: true
   has_one_attached :attachment
   validates :name, presence: true

app/models/test.rb

@@ -5,7 +5,7 @@ class Test < ApplicationRecord
   include TransferValues
   include ParentValidation
 
-  belongs_to :task, autosave: true, inverse_of: :tests
+  belongs_to :task, inverse_of: :tests
   belongs_to :testing_framework, optional: true
   belongs_to :parent, class_name: 'Test', optional: true
   validates :title, presence: true