Avoid race condition in system specs

Author: MrSerth

spec/system/messages_system_spec.rb

@@ -28,7 +28,10 @@
 
       it 'adds the user to the collection when saving the collection' do
         view_inbox
-        expect { find("[href='#{save_shared_link}'").click }.to change { collection.users.reload.include? user }.from(false).to(true)
+        expect do
+          find("[href='#{save_shared_link}'").click
+          wait_for_ajax
+        end.to change { collection.users.reload.include? user }.from(false).to(true)
       end
 
       context 'when the collection has been deleted' do

spec/system/tasks_system_spec.rb

@@ -152,12 +152,15 @@ def select_option(param_name, idx)
         find_by_id('advanced', wait: true).click
 
         select_option('q_created_before_days', all_time)
+        wait_for_ajax
         expect(all('.card-task-title').map(&:text)).to contain_exactly(today_task.title, last_week_task.title, all_time_task.title)
 
         select_option('q_created_before_days', last_week)
+        wait_for_ajax
         expect(all('.card-task-title').map(&:text)).to contain_exactly(today_task.title, last_week_task.title)
 
         select_option('q_created_before_days', today)
+        wait_for_ajax
         expect(all('.card-task-title').map(&:text)).to contain_exactly(today_task.title)
       end
     end