Lint: Use hash for data attributes in views

Author: MrSerth

app/views/application/_navigation.html.slim

@@ -5,6 +5,6 @@
     = render('navigation_collection_link', model: Group, cached: true)
     - if current_user.role == 'admin'
       li.nav-item
-        = link_to(rails_admin.dashboard_path, 'data-turbo': false, class: 'nav-link px-3') do
+        = link_to(rails_admin.dashboard_path, data: {turbo: false}, class: 'nav-link px-3') do
           i.fa-solid.fa-lock
           =< t('.rails_admin')

app/views/collections/show.html.slim

@@ -79,7 +79,7 @@
       - else
         - if policy(@collection).edit?
           .btn-group
-            = button_tag type: 'button', 'data-bs-toggle': 'dropdown', aria: {haspopup: 'true', expanded: 'false'}, class: 'btn btn-important nav-btn-exercise dropdown-toggle split' do
+            = button_tag type: 'button', data: {bs_toggle: 'dropdown'}, aria: {haspopup: 'true', expanded: 'false'}, class: 'btn btn-important nav-btn-exercise dropdown-toggle split' do
               => t('.button.share')
               span.caret
             .dropdown-menu#share-collection-menu
@@ -92,10 +92,10 @@
           .dropdown.btn-group
             - if @collection.tasks.empty?
               .btn-group data-bs-toggle='tooltip' title=t('.download_no_exercises') data-bs-delay=150
-                = button_tag class: 'btn btn-important dropdown-toggle disabled', 'data-bs-toggle': 'dropdown' do
+                = button_tag class: 'btn btn-important dropdown-toggle disabled', data: {bs_toggle: 'dropdown'} do
                   => t('common.button.download_zip')
             - else
-              = button_tag class: 'btn btn-important dropdown-toggle', 'data-bs-toggle': 'dropdown' do
+              = button_tag class: 'btn btn-important dropdown-toggle', data: {bs_toggle: 'dropdown'} do
                 => t('common.button.download_zip')
                 span.caret
               .scrollable.dropdown-menu role='menu'
@@ -105,7 +105,7 @@
                     = link_to(proforma_version, download_all_collection_path(@collection, version: proforma_version), class: 'dropdown-item', target: '_blank', rel: 'noopener noreferrer')
 
           .dropdown.btn-group
-            = button_tag class: 'btn btn-important dropdown-toggle', 'data-bs-toggle': 'dropdown' do
+            = button_tag class: 'btn btn-important dropdown-toggle', data: {bs_toggle: 'dropdown'} do
               => t('common.button.export')
               span.caret
             .scrollable.dropdown-menu role='menu'

app/views/layouts/application.html.slim

@@ -11,10 +11,10 @@ html lang=I18n.locale data-default-locale=I18n.default_locale
     = favicon_link_tag('/icon.svg', type: 'image/svg+xml')
     = favicon_link_tag('/icon.png', rel: 'apple-touch-icon', type: 'image/png')
     = tag.link rel: 'manifest', href: pwa_manifest_path
-    = stylesheet_pack_tag('stylesheets', "multilang_#{I18n.locale}", media: 'all', 'data-turbo-track': 'reload', integrity: true, crossorigin: 'anonymous')
-    = stylesheet_link_tag('application', media: 'all', 'data-turbo-track': 'reload', integrity: true, crossorigin: 'anonymous')
-    = javascript_pack_tag('application', 'data-turbo-track': 'reload', defer: false, integrity: true, crossorigin: 'anonymous')
-    = javascript_include_tag('application', 'data-turbo-track': 'reload', defer: true, integrity: true, crossorigin: 'anonymous')
+    = stylesheet_pack_tag('stylesheets', "multilang_#{I18n.locale}", media: 'all', data: {turbo_track: 'reload'}, integrity: true, crossorigin: 'anonymous')
+    = stylesheet_link_tag('application', media: 'all', data: {turbo_track: 'reload'}, integrity: true, crossorigin: 'anonymous')
+    = javascript_pack_tag('application', data: {turbo_track: 'reload'}, defer: false, integrity: true, crossorigin: 'anonymous')
+    = javascript_include_tag('application', data: {turbo_track: 'reload'}, defer: true, integrity: true, crossorigin: 'anonymous')
     = yield(:head)
     = csrf_meta_tags
     /= csp_meta_tag

app/views/tasks/_editor.html.slim

@@ -18,7 +18,7 @@ a.btn.btn-main.btn-sm.toggle-input href='#'
         - if file.object.persisted? && file.object.attachment.image?
           = image_tag file.object.attachment.variant(resize_to_limit: [600, 600])
         - elsif file.object.persisted?
-          = link_to(file.object.attachment.filename, download_attachment_task_file_path(file.object), class: 'btn btn-light border-right-0', 'data-turbo' => false)
+          = link_to(file.object.attachment.filename, download_attachment_task_file_path(file.object), class: 'btn btn-light border-right-0', data: {turbo: false})
         - else
           .btn.btn-light.border-right-0.disabled = file.object.attachment.filename
         = link_to('#', class: 'btn btn-light reupload-attachment border-left-0 me-1', title: t('.button.upload_a_new_file')) do

app/views/tasks/_form.html.slim

@@ -43,7 +43,7 @@
           - unless @task.contribution?
             .field-element
               = f.label :uuid, Task.human_attribute_name('uuid'), class: 'form-label'
-              = f.text_field :uuid, type: :uuid, class: 'form-control not-allowed', disabled: true, title: t('.unchangeable_uuid'), 'data-bs-toggle': 'tooltip', pattern: uuid_pattern
+              = f.text_field :uuid, type: :uuid, class: 'form-control not-allowed', disabled: true, title: t('.unchangeable_uuid'), data: {bs_toggle: 'tooltip'}, pattern: uuid_pattern
             .field-element
               = f.label :parent_uuid, Task.human_attribute_name('parent_uuid'), class: 'form-label'
               = f.text_field :parent_uuid, type: :uuid, class: 'form-control', pattern: uuid_pattern
@@ -87,7 +87,7 @@
             = f.label :license, Task.human_attribute_name('license'), class: 'form-label'
             .license
               .select
-                = f.select :license_id, options_for_select(License.all.collect {|l| [l.name, l.id, {'data-link' => l.link}] }, @task.license_id), {include_blank: t('.no_license')}, {class: 'form-select'}
+                = f.select :license_id, options_for_select(License.all.collect {|l| [l.name, l.id, {data: {link: l.link}}] }, @task.license_id), {include_blank: t('.no_license')}, {class: 'form-select'}
               .link
       fieldset.form-group
         legend.toggle-next

app/views/tasks/_import_export_dialog.html.slim

@@ -1,3 +1,3 @@
 - content_for :modal_footer, flush: true do
-  = button_tag class: 'btn btn-important', 'data-bs-dismiss': 'modal' do
+  = button_tag class: 'btn btn-important', data: {bs_dismiss: 'modal'} do
     = t('common.button.close')

app/views/tasks/index.html.slim

@@ -15,7 +15,7 @@
             = link_to(new_task_path, class: 'btn btn-main nav-btn-exercise') do
               i.fa-solid.fa-plus.text-success
               =< t('.button.new_task')
-            = button_tag type: 'button', 'data-bs-toggle': 'dropdown', aria: {haspopup: 'true', expanded: 'false'}, class: 'btn btn-main nav-btn-exercise dropdown-toggle split' do
+            = button_tag type: 'button', data: {bs_toggle: 'dropdown'}, aria: {haspopup: 'true', expanded: 'false'}, class: 'btn btn-main nav-btn-exercise dropdown-toggle split' do
               span.caret
             ul.dropdown-menu.rounded-0.shadow-sm#xml-import
               li.dropdown-header.dropdown-title
@@ -69,7 +69,7 @@
                 p
                   b = t('.search.has_all_labels')
                 span.form-group
-                  = f.select 'has_all_labels', options_for_select(@req_labels.map {|l| [l.name, l.name, {label_color: l.color, label_font_color: l.font_color}] }, @req_labels.pluck(:name)), {}, {class: 'labels-select2-tag form-control ransack-filter', multiple: true, 'data-tags': false}
+                  = f.select 'has_all_labels', options_for_select(@req_labels.map {|l| [l.name, l.name, {label_color: l.color, label_font_color: l.font_color}] }, @req_labels.pluck(:name)), {}, {class: 'labels-select2-tag form-control ransack-filter', multiple: true, data: {tags: false}}
               - if @visibility == :owner
                 .other.col-md-4.pt-3
                   p

app/views/tasks/show.html.slim

@@ -217,7 +217,7 @@
                   - if file.attachment.image?
                     = image_tag(file.attachment.variant(resize_to_limit: [900, 900]))
                   - else
-                    = link_to(file.attachment.filename, download_attachment_task_file_path(file), 'data-turbo': false)
+                    = link_to(file.attachment.filename, download_attachment_task_file_path(file), data: {turbo: false})
             .row
               .col-auto.row-label
                 = TaskFile.human_attribute_name('used_by_grader')
@@ -358,7 +358,7 @@
                           - if file.attachment.image?
                             = image_tag(file.attachment.variant(resize_to_limit: [900, 900]))
                           - else
-                            = link_to(file.attachment.filename, download_attachment_task_file_path(file), 'data-turbo': false)
+                            = link_to(file.attachment.filename, download_attachment_task_file_path(file), data: {turbo: false})
                     .row
                       .col-auto.row-label
                         = TaskFile.human_attribute_name('used_by_grader')
@@ -459,7 +459,7 @@
                           - if file.attachment.image?
                             = image_tag(file.attachment.variant(resize_to_limit: [900, 900]))
                           - else
-                            = link_to(file.attachment.filename, download_attachment_task_file_path(file), 'data-turbo': false)
+                            = link_to(file.attachment.filename, download_attachment_task_file_path(file), data: {turbo: false})
                     .row
                       .col-auto.row-label
                         = TaskFile.human_attribute_name('used_by_grader')
@@ -486,7 +486,7 @@
       .wrapper
         - if policy(@task).add_to_collection?
           .dropdown.btn-group
-            = button_tag class: 'btn btn-light dropdown-toggle', 'data-bs-toggle': 'dropdown' do
+            = button_tag class: 'btn btn-light dropdown-toggle', data: {bs_toggle: 'dropdown'} do
               = t('.button.add_to_collection')
             ul.scrollable.dropdown-menu role='menu'
               - current_user.collections.order(created_at: :desc).each do |collection|
@@ -510,7 +510,7 @@
                     = f.submit class: 'btn btn-light submit', value: t('.button.create_collection')
         - else
           div data-bs-toggle='tooltip' title=unavailable_tooltip data-bs-delay=150
-            = button_tag class: 'btn btn-outline-dark dropdown-toggle disabled', 'data-bs-toggle': 'dropdown' do
+            = button_tag class: 'btn btn-outline-dark dropdown-toggle disabled', data: {bs_toggle: 'dropdown'} do
               = t('.button.add_to_collection')
   .col-md-4.col-sm-6.mb-3.p-0
     .button-box.border.p-3.h-100
@@ -519,7 +519,7 @@
       .wrapper
         - if policy(@task).download?
           .dropdown.btn-group
-            = button_tag class: 'btn btn-light dropdown-toggle', 'data-bs-toggle': 'dropdown' do
+            = button_tag class: 'btn btn-light dropdown-toggle', data: {bs_toggle: 'dropdown'} do
               = t('common.button.download_zip')
             ul.scrollable.dropdown-menu role='menu'
               li.dropdown-header = "#{t('common.button.available_versions')}: "
@@ -529,11 +529,11 @@
 
         - else
           div data-bs-toggle='tooltip' title=unavailable_tooltip data-bs-delay=150
-            = link_to(t('common.button.download_zip'), download_task_path(@task), class: 'btn btn-outline-dark disabled', 'data-turbo' => false)
+            = link_to(t('common.button.download_zip'), download_task_path(@task), class: 'btn btn-outline-dark disabled', data: {turbo: false})
 
         - if policy(@task).export_external_start?
           .dropdown.btn-group
-            = button_tag class: 'btn btn-light dropdown-toggle', 'data-bs-toggle': 'dropdown' do
+            = button_tag class: 'btn btn-light dropdown-toggle', data: {bs_toggle: 'dropdown'} do
               = t('.button.export')
             ul.scrollable.dropdown-menu role='menu'
               li.dropdown-header = "#{t('tasks.show.export_to')}: "
@@ -546,7 +546,7 @@
                     = button_to(acc_link.name, export_external_start_task_path(account_link: acc_link), method: :post, remote: true, class: 'dropdown-item export-test')
         - else
           div data-bs-toggle='tooltip' title=unavailable_tooltip data-bs-delay=150
-            = button_tag class: 'btn btn-outline-dark dropdown-toggle disabled', 'data-bs-toggle': 'dropdown' do
+            = button_tag class: 'btn btn-outline-dark dropdown-toggle disabled', data: {bs_toggle: 'dropdown'} do
               = t('.button.export')
   .col-md-4.col-sm-6.mb-3.p-0
     .button-box.border.p-3.h-100
@@ -587,7 +587,7 @@
 
     .actions.btn-group role='group'
       - if policy(@task).edit?
-        = link_to(@task.url_for(:edit), class: 'btn btn-important', 'data-turbo': false) do
+        = link_to(@task.url_for(:edit), class: 'btn btn-important', data: {turbo: false}) do
           i.fa-solid.fa-pen-to-square
           =< t('common.button.edit')
       - if policy(@task).destroy?