Unify redirect_to targets

Author: MrSerth

app/controllers/collections_controller.rb

@@ -41,15 +41,15 @@ def create
       # Redirect back to task#show as collections with tasks can only be created from that view
       create_collection_with_task
     elsif @collection.save
-      redirect_to collections_path, notice: t('common.notices.object_created', model: Collection.model_name.human)
+      redirect_to Collection, notice: t('common.notices.object_created', model: Collection.model_name.human)
     else
       render :new
     end
   end
 
   def update
     if @collection.update(collection_params)
-      redirect_to collections_path, notice: t('common.notices.object_updated', model: Collection.model_name.human)
+      redirect_to Collection, notice: t('common.notices.object_updated', model: Collection.model_name.human)
     else
       render :edit
     end
@@ -94,9 +94,9 @@ def download_all
 
   def share
     if share_message.save
-      redirect_to collection_path(@collection), notice: t('.success_notice')
+      redirect_to @collection, notice: t('.success_notice')
     else
-      redirect_to collection_path(@collection), alert: share_message.errors.full_messages.join(', ')
+      redirect_to @collection, alert: share_message.errors.full_messages.join(', ')
     end
   end
 
@@ -119,10 +119,10 @@ def save_shared # rubocop:disable Metrics/AbcSize
   def leave
     if @collection.users.count == 1
       @collection.destroy
-      redirect_to collections_path, notice: t('common.notices.object_deleted', model: Collection.model_name.human)
+      redirect_to Collection, notice: t('common.notices.object_deleted', model: Collection.model_name.human)
     else
       @collection.users.delete(current_user)
-      redirect_to collections_path, notice: t('.left_successfully')
+      redirect_to Collection, notice: t('.left_successfully')
     end
   end
 

app/controllers/groups_controller.rb

@@ -46,15 +46,15 @@ def update
 
   def destroy
     @group.destroy
-    redirect_to groups_url, notice: t('common.notices.object_deleted', model: Group.model_name.human)
+    redirect_to Group, notice: t('common.notices.object_deleted', model: Group.model_name.human)
   end
 
   def leave
     if @group.last_admin?(current_user)
       redirect_to @group, alert: t('.cannot_leave_alert')
     else
       @group.users.delete(current_user)
-      redirect_to groups_path, notice: t('.success_notice')
+      redirect_to Group, notice: t('.success_notice')
     end
   end
 
@@ -66,7 +66,7 @@ def request_access
       AccessRequestMailer.send_access_request(current_user, admin, @group).deliver_later
     end
     @group.add(current_user, role: :applicant)
-    redirect_to groups_path
+    redirect_to Group
   end
 
   def remove_task

app/controllers/tasks_controller.rb

@@ -75,7 +75,7 @@ def update
 
   def destroy
     @task.destroy!
-    redirect_to tasks_url, notice: t('common.notices.object_deleted', model: Task.model_name.human)
+    redirect_to Task, notice: t('common.notices.object_deleted', model: Task.model_name.human)
   end
 
   def add_to_collection

app/controllers/users_controller.rb

@@ -7,7 +7,7 @@ class UsersController < ApplicationController
     if current_user
       redirect_to({id: current_user.id}, alert: t('common.errors.not_authorized'))
     else
-      redirect_to root_path, alert: t('common.errors.not_authorized')
+      redirect_to :root, alert: t('common.errors.not_authorized')
     end
   end