Fix Rubocop offenses

Author: MrSerth

app/views/comments/_task_comments.html.slim

@@ -2,7 +2,7 @@
   .comment-block
     = t('.info.no_comments')
 
--else
+- else
   = link_to task_comments_path(@task), class: 'refresh', remote: true do
     span.fa-solid.fa-arrows-rotate
     =< t('.button.refresh_comments')

spec/controllers/account_links_controller_spec.rb

@@ -38,15 +38,15 @@
     end
 
     describe 'GET #new' do
-      include_examples 'new examples', klass: AccountLink, resource: :account_link
+      it_behaves_like 'new examples', klass: AccountLink, resource: :account_link
     end
 
     describe 'GET #edit' do
-      include_examples 'edit examples', klass: AccountLink, resource: :account_link
+      it_behaves_like 'edit examples', klass: AccountLink, resource: :account_link
     end
 
     describe 'POST #create' do
-      include_examples 'create examples', klass: AccountLink, resource: :account_link
+      it_behaves_like 'create examples', klass: AccountLink, resource: :account_link
 
       it 'with valid attributes redirects to the user' do
         post :create, params: empty_params.merge(account_link: valid_attributes)
@@ -61,7 +61,7 @@
         attributes
       end
 
-      include_examples 'update examples', klass: AccountLink, resource: :account_link
+      it_behaves_like 'update examples', klass: AccountLink, resource: :account_link
 
       context 'with valid attributes' do
         it 'updates the requested account_link' do
@@ -80,7 +80,7 @@
     end
 
     describe 'DELETE #destroy' do
-      include_examples 'destroy examples', klass: AccountLink, resource: :account_link
+      it_behaves_like 'destroy examples', klass: AccountLink, resource: :account_link
       it 'with valid attributes redirects to the user' do
         account_link = AccountLink.create! valid_attributes.merge(user:)
         delete :destroy, params: empty_params.merge(id: account_link.to_param)

spec/controllers/bridges/lom/tasks_controller_spec.rb

@@ -30,7 +30,7 @@
     before { allow(Task).to receive(:find).with(task.id.to_s).and_return(task) }
 
     context 'when allowed to access the LOM' do
-      include_examples 'is a valid LOM response'
+      it_behaves_like 'is a valid LOM response'
     end
 
     context 'when not allowed to access the LOM' do
@@ -58,19 +58,19 @@
       context 'when no license is specified' do
         let(:license) { nil }
 
-        include_examples 'is a valid LOM response'
+        it_behaves_like 'is a valid LOM response'
       end
 
       context 'when ratings are available' do
         before { create(:rating, task:, user:) }
 
-        include_examples 'is a valid LOM response'
+        it_behaves_like 'is a valid LOM response'
       end
 
       context 'when comments are available' do
         before { create(:comment, task:, user:) }
 
-        include_examples 'is a valid LOM response'
+        it_behaves_like 'is a valid LOM response'
       end
     end
   end

spec/controllers/collections_controller_spec.rb

@@ -712,7 +712,7 @@
       end
     end
 
-    include_examples 'redirects to collection and flashes message successfully'
+    it_behaves_like 'redirects to collection and flashes message successfully'
 
     context 'when push_tasks returns errors' do
       let(:push_task_return) { ['error'] }
@@ -731,19 +731,19 @@
     context 'when user is not in collection' do
       let(:users) { [create(:user)] }
 
-      include_examples 'redirect to collection-list and flashes not authorized'
+      it_behaves_like 'redirect to collection-list and flashes not authorized'
     end
 
     context 'when the account link is shared with the requesting user' do
       let(:account_link) { create(:account_link, user: create(:user), shared_users: Array.wrap(user)) }
 
-      include_examples 'redirects to collection and flashes message successfully'
+      it_behaves_like 'redirects to collection and flashes message successfully'
     end
 
     context 'when the account link is neither owned by nor shared with the requesting user' do
       let(:account_link_user) { create(:user) }
 
-      include_examples 'redirect to collection-list and flashes not authorized'
+      it_behaves_like 'redirect to collection-list and flashes not authorized'
     end
   end
   # get collections_all # adminview

spec/controllers/labels_controller_spec.rb

@@ -45,13 +45,13 @@
       before { sign_in user }
 
       context 'without requesting more info' do
-        include_examples 'json without the number of referrencing tasks'
+        it_behaves_like 'json without the number of referrencing tasks'
       end
 
       context 'when requesting more info' do
         subject(:get_request) { get :search, params: params.merge(more_info: true) }
 
-        include_examples 'json without the number of referrencing tasks'
+        it_behaves_like 'json without the number of referrencing tasks'
       end
     end
 
@@ -61,7 +61,7 @@
       before { sign_in admin }
 
       context 'when not requesting more info' do
-        include_examples 'json without the number of referrencing tasks'
+        it_behaves_like 'json without the number of referrencing tasks'
       end
 
       context 'when requesting more info' do
@@ -122,20 +122,20 @@
       context 'with an invalid new label name' do
         let(:new_label_name) { '' }
 
-        include_examples 'error and flash message'
+        it_behaves_like 'error and flash message'
       end
 
       context 'with an already existing new label name' do
         let(:selected_labels) { labels[1..3] }
         let(:new_label_name) { labels.first.name }
 
-        include_examples 'error and flash message'
+        it_behaves_like 'error and flash message'
       end
 
       context 'with no labels to merge' do
         let(:selected_labels) { [] }
 
-        include_examples 'error and flash message'
+        it_behaves_like 'error and flash message'
       end
 
       context 'when the new label name is one of the selected labels except the first' do

spec/controllers/ratings_controller_spec.rb

@@ -39,7 +39,7 @@
         expect { post_request }.to change { flash[:notice] }.to(I18n.t('common.notices.object_created', model: Rating.model_name.human))
       end
 
-      include_examples 'responds with the average_rating of the task'
+      it_behaves_like 'responds with the average_rating of the task'
 
       context 'when the user has already rated the task' do
         let!(:existing_rating) { task.ratings.create(user:, overall_rating: 1) }
@@ -56,7 +56,7 @@
           expect { post_request }.to change { flash[:notice] }.to(I18n.t('common.notices.object_updated', model: Rating.model_name.human))
         end
 
-        include_examples 'responds with the average_rating of the task'
+        it_behaves_like 'responds with the average_rating of the task'
       end
 
       context 'when user rates his own task' do
@@ -70,7 +70,7 @@
           expect { post_request }.to change { flash[:alert] }.to(I18n.t('ratings.handle_own_rating.error'))
         end
 
-        include_examples 'responds with the average_rating of the task'
+        it_behaves_like 'responds with the average_rating of the task'
       end
     end
 
@@ -81,7 +81,7 @@
         expect { post_request }.not_to change(Rating, :count)
       end
 
-      include_examples 'responds with the average_rating of the task'
+      it_behaves_like 'responds with the average_rating of the task'
     end
   end
 end

spec/controllers/tasks_controller_spec.rb

@@ -90,27 +90,27 @@
           context "when using filter keywords from #{description}" do
             let(:ransack_params) { {'fulltext_search' => keywords} }
 
-            include_examples 'shows task1'
+            it_behaves_like 'shows task1'
           end
         end
       end
 
       context 'when a label filter is used' do
         let(:ransack_params) { {'has_all_labels' => %w[l1 l3]} }
 
-        include_examples 'shows task1'
+        it_behaves_like 'shows task1'
       end
 
       context 'when a fulltext search filter and label filter are combined' do
         let(:ransack_params) { {'fulltext_search' => 'key1 key2', 'has_all_labels' => %w[l3]} }
 
-        include_examples 'shows task1'
+        it_behaves_like 'shows task1'
       end
 
       context 'when a programming language filter is used' do
         let(:ransack_params) { {'programming_language_id_in' => ruby_lang.id} }
 
-        include_examples 'shows task1'
+        it_behaves_like 'shows task1'
       end
 
       context 'when a second request without searchparams is made' do
@@ -984,12 +984,12 @@
       end
     end
 
-    include_examples 'renders success response'
+    it_behaves_like 'renders success response'
 
     context 'when the account link is shared with the requesting user' do
       let(:account_link) { create(:account_link, user: create(:user), shared_users: Array.wrap(user)) }
 
-      include_examples 'renders success response'
+      it_behaves_like 'renders success response'
     end
 
     context 'when the account link is neither owned by nor shared with the requesting user' do
@@ -1035,7 +1035,7 @@
       end
     end
 
-    include_examples 'renders success json'
+    it_behaves_like 'renders success json'
 
     context 'when there is an error' do
       let(:error) { 'error' }
@@ -1070,7 +1070,7 @@
     context 'when the account link is shared with the requesting user' do
       let(:account_link) { create(:account_link, user: create(:user), shared_users: Array.wrap(user)) }
 
-      include_examples 'renders success json'
+      it_behaves_like 'renders success json'
     end
 
     context 'when the account link is neither owned by nor shared with the requesting user' do
@@ -1124,7 +1124,7 @@
       expect { post_request }.not_to change(Task, :count)
     end
 
-    include_examples 'renders success response'
+    it_behaves_like 'renders success response'
 
     context 'when push_type is create_new' do
       let(:push_type) { 'create_new' }
@@ -1168,7 +1168,7 @@
     context 'when the account link is shared with the requesting user' do
       let(:account_link) { create(:account_link, user: create(:user), shared_users: Array.wrap(user)) }
 
-      include_examples 'renders success response'
+      it_behaves_like 'renders success response'
     end
 
     context 'when the account link is neither owned by nor shared with the requesting user' do