Fix button_to for forms

Forms shouldn't be nested, particularly their submit buttons shouldn't. With this commit, we fix this issue. For some forms, we had to provide an ID and assign a separate submit button outside the form to keep the current appearance and make the least changes. A more proper solution should be found in the future.

Author: MrSerth

app/views/collections/_form.html.slim

@@ -2,8 +2,8 @@
   - append_javascript_pack_tag('toast-ui')
   - append_stylesheet_pack_tag('toast-ui')
 
-= form_for @collection, builder: MarkdownFormBuilder, data: {turbo: false} do |f|
-  .my-4
+.my-4
+  = form_for @collection, builder: MarkdownFormBuilder, data: {turbo: false}, id: 'edit_collection' do |f|
     = render('shared/form_errors', object: @collection)
     .form-group
       .field-element
@@ -46,15 +46,15 @@
                         i.fa-solid.fa-xmark.vert-align.text-danger.lead
 
         br
-    .form-group
-      .actions.btn-group role='group'
-        = button_tag type: 'submit', class: 'btn btn-important' do
-          i.fa-solid.fa-folder-open
-          =< t('.button.save')
-        - if @collection.tasks.present?
-          = button_to(remove_all_collection_path(@collection), method: :patch, data: {confirm: t('common.sure')}, class: 'btn btn-important h-100') do
-            i.fa-solid.fa-xmark.text-danger
-            =< t('.button.remove_all')
-        = link_to(:back, class: 'btn btn-important') do
-          i.fa-solid.fa-xmark
-          =< t('common.button.cancel')
+  .form-group
+    .actions.btn-group role='group'
+      = button_tag type: 'submit', class: 'btn btn-important', form: 'edit_collection' do
+        i.fa-solid.fa-folder-open
+        =< t('.button.save')
+      - if @collection.tasks.present?
+        = button_to(remove_all_collection_path(@collection), method: :patch, data: {confirm: t('common.sure')}, class: 'btn btn-important h-100') do
+          i.fa-solid.fa-xmark.text-danger
+          =< t('.button.remove_all')
+      = link_to(:back, class: 'btn btn-important') do
+        i.fa-solid.fa-xmark
+        =< t('common.button.cancel')

app/views/comments/_edit.html.slim

@@ -1,12 +1,12 @@
-= form_for :comment, url: task_comment_path(@task, @comment), method: :put, remote: true do |f|
-  .comment-text
-    .comment-text-input
+.comment-text
+  .comment-text-input
+    = form_for :comment, url: task_comment_path(@task, @comment), method: :put, remote: true, id: "edit_comment_#{@comment.id}", class: 'd-inline' do |f|
       = f.text_field :text, class: 'form-control'
-    .actions.btn-group.float-end role='group'
-      - if policy(@comment).edit?
-        = button_tag type: 'submit', class: 'btn btn-light btn-sm' do
-          i.fa-solid.fa-floppy-disk
-          =< t('common.button.save')
-        = button_to(task_comment_path(@task, @comment), class: 'btn btn-light btn-sm', method: :delete, remote: true, data: {confirm: t('common.sure')})
-          i.fa-solid.fa-trash-can
-          =< t('common.button.delete')
+  .actions.btn-group.float-end role='group'
+    - if policy(@comment).edit?
+      = button_tag type: 'submit', class: 'btn btn-light btn-sm', form: "edit_comment_#{@comment.id}" do
+        i.fa-solid.fa-floppy-disk
+        =< t('common.button.save')
+      = button_to(task_comment_path(@task, @comment), class: 'btn btn-light btn-sm', method: :delete, remote: true, data: {confirm: t('common.sure')})
+        i.fa-solid.fa-trash-can
+        =< t('common.button.delete')

app/views/users/registrations/edit.html.slim

@@ -6,7 +6,7 @@
         =< t('devise.registrations.edit.title', resource: User.model_name.human)
 
 .row.my-4
-  = form_for(resource, as: resource_name, url: registration_path(resource_name), html: {method: :put}) do |f|
+  = form_for(resource, as: resource_name, url: registration_path(resource_name), html: {method: :put}, id: 'edit_user') do |f|
     = render('shared/form_errors', object: resource, title: t('common.errors.changes_not_saved'))
 
     .form-group.field-element
@@ -74,27 +74,27 @@
         small.form-text.text-body-secondary = t('devise.registrations.edit.we_need_your_current_password_to_confirm_your_changes')
 
 
-    - if devise_mapping.omniauthable? && resource_class.omniauth_providers.any?
-      .form-group.field-element
-        .form-label
-          = t('.manage_omniauth')
-        .form-content.manage_omniauth
-          - resource_class.omniauth_providers.each do |provider|
-            - provider_name = OmniAuth::Utils.camelize(provider)
-            - configured_providers = current_user.omniauth_identities.pluck(:omniauth_provider)
-            - if configured_providers.include?(provider.to_s) && (configured_providers.size > 1 || resource.password_set?)
-              = button_to(t('.remove_identity', kind: provider_name), omniauth_deauthorize_path(provider), class: 'btn btn-light btn-sm mb-2 me-2', method: :delete)
-            - elsif configured_providers.include?(provider.to_s)
-              a.btn.btn-light.btn-sm.mb-2.me-2.disabled href='#'
-                = t('.cannot_remove_last_identity', kind: provider_name)
-            - else
-              = button_to(t('.add_identity', kind: provider_name), omniauth_authorize_path(resource_name, provider), class: 'btn btn-light btn-sm mb-2 me-2', method: :post)
+  - if devise_mapping.omniauthable? && resource_class.omniauth_providers.any?
+    .form-group.field-element.px-4
+      .form-label
+        = t('.manage_omniauth')
+      .form-content.manage_omniauth
+        - resource_class.omniauth_providers.each do |provider|
+          - provider_name = OmniAuth::Utils.camelize(provider)
+          - configured_providers = current_user.omniauth_identities.pluck(:omniauth_provider)
+          - if configured_providers.include?(provider.to_s) && (configured_providers.size > 1 || resource.password_set?)
+            = button_to(t('.remove_identity', kind: provider_name), omniauth_deauthorize_path(provider), class: 'btn btn-light btn-sm mb-2 me-2', method: :delete)
+          - elsif configured_providers.include?(provider.to_s)
+            a.btn.btn-light.btn-sm.mb-2.me-2.disabled href='#'
+              = t('.cannot_remove_last_identity', kind: provider_name)
+          - else
+            = button_to(t('.add_identity', kind: provider_name), omniauth_authorize_path(resource_name, provider), class: 'btn btn-light btn-sm mb-2 me-2', method: :post)
 
-    .form-group.py-3
-      .btn-group role='group'
-        = button_tag type: 'submit', class: 'btn btn-important' do
-          i.fa-solid.fa-user
-          =< t('common.button.update')
-        = link_to(:back, class: 'btn btn-important') do
-          i.fa-solid.fa-xmark.text-secondary
-          =< t('common.button.back')
+  .form-group.py-3
+    .btn-group role='group'
+      = button_tag type: 'submit', class: 'btn btn-important', form: 'edit_user' do
+        i.fa-solid.fa-user
+        =< t('common.button.update')
+      = link_to(:back, class: 'btn btn-important') do
+        i.fa-solid.fa-xmark.text-secondary
+        =< t('common.button.back')