Migrate link_to to button_to for stateful actions in views

MrSerth · MrSerth · commit 0a38755c2f13 · 2025-07-09T13:10:34.000+02:00
For these actions, we use use a non-default `method` (other than `GET`). To indicate that within the DOM (i.e., for Screenreaders) but also enhance compatibility with Turbo, we switch to proper `button_to` forms here. As part of this migration, some buttons should still be shown inline (hence, we add the `form_class: 'd-inline-block'`) or with the same height as regular links (hence, we add `class: 'h-100'`). See https://github.com/heartcombo/devise/wiki/How-To:-Upgrade-to-Devise-4.9.0-%5BHotwire-Turbo-integration%5D#data-method-vs-data-turbo-method See https://gorails.com/episodes/link_to-vs-button_to-in-rails
diff --git a/app/views/application/_session.html.slim b/app/views/application/_session.html.slim
@@ -17,11 +17,11 @@
         - if current_user.admin? || current_user.teacher? || current_user.internal_user?
           li = link_to(t('consumers.show.link'), current_user.consumer, class: 'dropdown-item') if current_user.consumer && policy(current_user.consumer).show?
           li = link_to(t('internal_users.show.link'), current_user, class: 'dropdown-item') if policy(current_user).show?
-          li = link_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
+          li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
         - elsif current_user.webauthn_configured?
-          li = link_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
+          li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
       - else
-        li = link_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
+        li = button_to(t('sessions.destroy.link'), sign_out_path, method: :delete, class: 'dropdown-item')
 - else
   li.nav-item = link_to(sign_in_path, class: 'nav-link') do
     i.fa-solid.fa-arrow-right-to-bracket
diff --git a/app/views/codeharbor_links/_form.html.slim b/app/views/codeharbor_links/_form.html.slim
@@ -15,4 +15,4 @@
   .actions
     = render('shared/submit_button', f:, object: @codeharbor_link)
     - if @codeharbor_link.persisted?
-      = link_to(t('codeharbor_link.delete'), polymorphic_path([@codeharbor_link.user, @codeharbor_link]), data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-danger float-end')
+      = button_to(t('codeharbor_link.delete'), polymorphic_path([@codeharbor_link.user, @codeharbor_link]), data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-danger float-end')
diff --git a/app/views/consumers/index.html.slim b/app/views/consumers/index.html.slim
@@ -12,7 +12,7 @@ h1 = Consumer.model_name.human(count: :other)
           td = link_to_if(policy(consumer).show?, consumer.name, consumer)
           td = link_to(t('shared.show'), consumer) if policy(consumer).show?
           td = link_to(t('shared.edit'), edit_consumer_path(consumer)) if policy(consumer).edit?
-          td = link_to(t('shared.destroy'), consumer, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(consumer).destroy?
+          td = button_to(t('shared.destroy'), consumer, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(consumer).destroy?
 
 = render('shared/pagination', collection: @consumers)
 p = render('shared/new_button', model: Consumer)
diff --git a/app/views/error_template_attributes/index.html.slim b/app/views/error_template_attributes/index.html.slim
@@ -23,7 +23,7 @@ h1 = ErrorTemplateAttribute.model_name.human(count: :other)
             code = error_template_attribute.regex
           td = link_to(t('shared.show'), error_template_attribute) if policy(error_template_attribute).show?
           td = link_to(t('shared.edit'), edit_error_template_attribute_path(error_template_attribute)) if policy(error_template_attribute).edit?
-          td = link_to(t('shared.destroy'), error_template_attribute, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(error_template_attribute).destroy?
+          td = button_to(t('shared.destroy'), error_template_attribute, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(error_template_attribute).destroy?
 
 = render('shared/pagination', collection: @error_template_attributes)
 p = render('shared/new_button', model: ErrorTemplateAttribute)
diff --git a/app/views/error_templates/index.html.slim b/app/views/error_templates/index.html.slim
@@ -16,7 +16,7 @@ h1 = ErrorTemplate.model_name.human(count: :other)
           td = link_to(error_template.execution_environment)
           td = link_to(t('shared.show'), error_template) if policy(error_template).show?
           td = link_to(t('shared.edit'), edit_error_template_path(error_template)) if policy(error_template).edit?
-          td = link_to(t('shared.destroy'), error_template, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(error_template).destroy?
+          td = button_to(t('shared.destroy'), error_template, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(error_template).destroy?
 
 = render('shared/pagination', collection: @error_templates)
 p = render('shared/new_button', model: ErrorTemplate)
diff --git a/app/views/error_templates/show.html.slim b/app/views/error_templates/show.html.slim
@@ -35,7 +35,7 @@ h2.mt-4
             code = attribute.regex
           td = link_to(t('shared.show'), attribute) if policy(attribute).show?
           td = link_to(t('shared.edit'), edit_error_template_attribute_path(attribute)) if policy(attribute).edit?
-          td = link_to(t('shared.destroy'), attribute_error_template_url(error_template_attribute_id: attribute.id), method: :delete) if policy(attribute).destroy?
+          td = button_to(t('shared.destroy'), attribute_error_template_url(error_template_attribute_id: attribute.id), method: :delete, class: 'btn btn-sm btn-link') if policy(attribute).destroy?
 
 #add-attribute
   = collection_select({}, :error_template_attribute_id,
diff --git a/app/views/execution_environments/index.html.slim b/app/views/execution_environments/index.html.slim
@@ -31,7 +31,7 @@ h1.d-inline-block = ExecutionEnvironment.model_name.human(count: :other)
           td = execution_environment.permitted_execution_time
           td = link_to(t('shared.show'), execution_environment) if policy(execution_environment).show?
           td = link_to(t('shared.edit'), edit_execution_environment_path(execution_environment)) if policy(execution_environment).edit?
-          td = link_to(t('shared.destroy'), execution_environment, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(execution_environment).destroy?
+          td = button_to(t('shared.destroy'), execution_environment, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(execution_environment).destroy?
           td = link_to(t('.shell'), shell_execution_environment_path(execution_environment)) if policy(execution_environment).shell?
           td = link_to(t('shared.statistics'), statistics_execution_environment_path(execution_environment)) if policy(execution_environment).statistics?
 
diff --git a/app/views/execution_environments/show.html.slim b/app/views/execution_environments/show.html.slim
@@ -3,10 +3,10 @@ h1.d-inline-block = @execution_environment
   = render('shared/edit_button', object: @execution_environment)
   button.btn.btn-secondary.float-end.dropdown-toggle data-bs-toggle='dropdown' type='button'
   ul.dropdown-menu.dropdown-menu-end role='menu'
-    li = link_to(t('execution_environments.index.synchronize.button'), sync_to_runner_management_execution_environment_path(@execution_environment), method: :post, class: 'dropdown-item') if policy(@execution_environment).sync_to_runner_management?
+    li = button_to(t('execution_environments.index.synchronize.button'), sync_to_runner_management_execution_environment_path(@execution_environment), method: :post, class: 'dropdown-item') if policy(@execution_environment).sync_to_runner_management?
     li = link_to(t('execution_environments.index.shell'), shell_execution_environment_path(@execution_environment), class: 'dropdown-item') if policy(@execution_environment).shell?
     li = link_to(t('shared.statistics'), statistics_execution_environment_path(@execution_environment), 'data-turbo': 'false', class: 'dropdown-item') if policy(@execution_environment).statistics?
-    li = link_to(t('shared.destroy'), @execution_environment, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(@execution_environment).destroy?
+    li = button_to(t('shared.destroy'), @execution_environment, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(@execution_environment).destroy?
 
 = row(label: 'execution_environment.name', value: @execution_environment.name)
 = row(label: 'execution_environment.user', value: link_to_if(policy(@execution_environment.author).show?, @execution_environment.author, @execution_environment.author))
diff --git a/app/views/exercise_collections/index.html.slim b/app/views/exercise_collections/index.html.slim
@@ -19,7 +19,7 @@ h1 = ExerciseCollection.model_name.human(count: :other)
           td = link_to(t('shared.show'), collection) if policy(collection).show?
           td = link_to(t('shared.edit'), edit_exercise_collection_path(collection)) if policy(collection).edit?
           td = link_to(t('shared.statistics'), statistics_exercise_collection_path(collection)) if policy(collection).statistics?
-          td = link_to(t('shared.destroy'), collection, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(collection).destroy?
+          td = button_to(t('shared.destroy'), collection, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(collection).destroy?
 
 = render('shared/pagination', collection: @exercise_collections)
 p = render('shared/new_button', model: ExerciseCollection)
diff --git a/app/views/exercises/index.html.slim b/app/views/exercises/index.html.slim
@@ -51,8 +51,8 @@ h1 = Exercise.model_name.human(count: :other)
                 li = link_to(UserExerciseFeedback.model_name.human(count: :other), feedback_exercise_path(exercise), class: 'dropdown-item') if policy(exercise).feedback?
                 li = link_to(RequestForComment.model_name.human(count: :other), exercise_request_for_comments_path(exercise), class: 'dropdown-item') if policy(exercise).rfcs_for_exercise?
                 li = link_to(ProgrammingGroup.model_name.human(count: :other), exercise_programming_groups_path(exercise), class: 'dropdown-item') if policy(exercise).programming_groups_for_exercise?
-                li = link_to(t('shared.destroy'), exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(exercise).destroy?
-                li = link_to(t('.clone'), clone_exercise_path(exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(exercise).clone?
+                li = button_to(t('shared.destroy'), exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(exercise).destroy?
+                li = button_to(t('.clone'), clone_exercise_path(exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(exercise).clone?
                 li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {'exercise-id': exercise.id, 'bs-toggle': 'modal', 'bs-target': '#transfer-modal'}) if policy(exercise).export_external_confirm?
                 li = link_to(t('exercises.download_proforma.label'), download_proforma_exercise_path(exercise), class: 'dropdown-item', target: '_blank', rel: 'noopener noreferrer') if policy(exercise).download_proforma?
 
diff --git a/app/views/exercises/show.html.slim b/app/views/exercises/show.html.slim
@@ -20,8 +20,8 @@ h1.d-inline-block
     li = link_to(UserExerciseFeedback.model_name.human(count: :other), feedback_exercise_path(@exercise), class: 'dropdown-item') if policy(@exercise).feedback?
     li = link_to(RequestForComment.model_name.human(count: :other), exercise_request_for_comments_path(@exercise), class: 'dropdown-item') if policy(@exercise).rfcs_for_exercise?
     li = link_to(ProgrammingGroup.model_name.human(count: :other), exercise_programming_groups_path(@exercise), class: 'dropdown-item') if policy(@exercise).programming_groups_for_exercise?
-    li = link_to(t('shared.destroy'), @exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(@exercise).destroy?
-    li = link_to(t('exercises.index.clone'), clone_exercise_path(@exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(@exercise).clone?
+    li = button_to(t('shared.destroy'), @exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(@exercise).destroy?
+    li = button_to(t('exercises.index.clone'), clone_exercise_path(@exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(@exercise).clone?
     li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {'exercise-id': @exercise.id, 'bs-toggle': 'modal', 'bs-target': '#transfer-modal'}) if policy(@exercise).export_external_confirm?
     li = link_to(t('exercises.download_proforma.label'), download_proforma_exercise_path(@exercise), class: 'dropdown-item', target: '_blank', rel: 'noopener noreferrer') if policy(@exercise).download_proforma?
 
@@ -62,7 +62,7 @@ ul.list-unstyled#files
       .card-collapse.collapse class="collapse#{file.id}" role='tabpanel'
         .card-body
           - if policy(file).destroy?
-            .clearfix = link_to(t('shared.destroy'), file, class: 'btn btn-warning btn-sm float-end', data: {confirm: t('shared.confirm_destroy')}, method: :delete)
+            .clearfix = button_to(t('shared.destroy'), file, class: 'btn btn-warning btn-sm float-end', data: {confirm: t('shared.confirm_destroy')}, method: :delete)
           = render('shared/file', file:)
 
 - if policy(@exercise).export_external_confirm?
diff --git a/app/views/external_users/show.html.slim b/app/views/external_users/show.html.slim
@@ -23,7 +23,7 @@ h1 = @user.displayname
             - if study_group_membership.study_group_id == current_user.current_study_group_id
               span.text-success =< t('users.show.current_study_group')
             - else
-              =< link_to(t('users.show.set_as_current_study_group'), set_as_current_study_group_path(study_group_membership.study_group), method: :post, class: 'text-body-secondary')
+              =< button_to(t('users.show.set_as_current_study_group'), set_as_current_study_group_path(study_group_membership.study_group), method: :post, class: 'btn btn-sm btn-link text-body-secondary')
           - elsif @user == current_user && study_group_membership.role_teacher? && study_group_membership.study_group_id == current_user.current_study_group_id
             | ,
             span.text-success =< t('users.show.current_study_group')
diff --git a/app/views/file_templates/index.html.slim b/app/views/file_templates/index.html.slim
@@ -14,7 +14,7 @@ h1 = FileTemplate.model_name.human(count: :other)
           td = link_to_if(policy(file_template.file_type).show?, file_template.file_type, file_type_path(file_template.file_type))
           td = link_to(t('shared.show'), file_template) if policy(file_template).show?
           td = link_to(t('shared.edit'), edit_file_template_path(file_template)) if policy(file_template).edit?
-          td = link_to(t('shared.destroy'), file_template, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(file_template).destroy?
+          td = button_to(t('shared.destroy'), file_template, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(file_template).destroy?
 
 = render('shared/pagination', collection: @file_templates)
 p = render('shared/new_button', model: FileTemplate)
diff --git a/app/views/file_types/index.html.slim b/app/views/file_types/index.html.slim
@@ -16,7 +16,7 @@ h1 = FileType.model_name.human(count: :other)
           td = file_type.file_extension
           td = link_to(t('shared.show'), file_type) if policy(file_type).show?
           td = link_to(t('shared.edit'), edit_file_type_path(file_type)) if policy(file_type).edit?
-          td = link_to(t('shared.destroy'), file_type, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(file_type).destroy?
+          td = button_to(t('shared.destroy'), file_type, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(file_type).destroy?
 
 = render('shared/pagination', collection: @file_types)
 p = render('shared/new_button', model: FileType)
diff --git a/app/views/internal_users/index.html.slim b/app/views/internal_users/index.html.slim
@@ -31,7 +31,7 @@ h1 = InternalUser.model_name.human(count: :other)
             td = symbol_for(user.webauthn_configured?)
           td = link_to(t('shared.show'), user) if policy(user).show?
           td = link_to(t('shared.edit'), edit_internal_user_path(user)) if policy(user).edit?
-          td = link_to(t('shared.destroy'), user, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(user).destroy?
+          td = button_to(t('shared.destroy'), user, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(user).destroy?
 
 = render('shared/pagination', collection: @users)
 p = render('shared/new_button', model: InternalUser)
diff --git a/app/views/internal_users/show.html.slim b/app/views/internal_users/show.html.slim
@@ -23,7 +23,7 @@ h1
             - if study_group_membership.study_group_id == current_user.current_study_group_id
               span.text-success =< t('users.show.current_study_group')
             - else
-              =< link_to(t('users.show.set_as_current_study_group'), set_as_current_study_group_path(study_group_membership.study_group), method: :post, class: 'text-body-secondary')
+              =< button_to(t('users.show.set_as_current_study_group'), set_as_current_study_group_path(study_group_membership.study_group), method: :post, class: 'btn btn-sm btn-link text-body-secondary')
           | )
   - else
     = t('users.show.no_groups')
diff --git a/app/views/programming_groups/index.html.slim b/app/views/programming_groups/index.html.slim
@@ -36,5 +36,5 @@
           td = l(programming_group.created_at, format: :short)
           td = link_to(t('shared.show'), [@exercise, programming_group]) if policy(programming_group).show?
           td = link_to(t('shared.edit'), polymorphic_path([@exercise, programming_group], action: :edit)) if policy(programming_group).edit?
-          td = link_to(t('shared.destroy'), [@exercise, programming_group], data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(programming_group).destroy?
+          td = button_to(t('shared.destroy'), [@exercise, programming_group], data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(programming_group).destroy?
 = render('shared/pagination', collection: @programming_groups)
diff --git a/app/views/proxy_exercises/index.html.slim b/app/views/proxy_exercises/index.html.slim
@@ -32,8 +32,8 @@ h1 = ProxyExercise.model_name.human(count: :other)
               span.visually-hidden Toggle Dropdown
               ul.dropdown-menu.float-end role='menu'
                 li = link_to(t('shared.show'), proxy_exercise, class: 'dropdown-item') if policy(proxy_exercise).show?
-                li = link_to(t('shared.destroy'), proxy_exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(proxy_exercise).destroy?
-                li = link_to(t('.clone'), clone_proxy_exercise_path(proxy_exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(proxy_exercise).clone?
+                li = button_to(t('shared.destroy'), proxy_exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(proxy_exercise).destroy?
+                li = button_to(t('.clone'), clone_proxy_exercise_path(proxy_exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(proxy_exercise).clone?
 
 = render('shared/pagination', collection: @proxy_exercises)
 p = render('shared/new_button', model: ProxyExercise)
diff --git a/app/views/request_for_comments/_admin_menu.html.slim b/app/views/request_for_comments/_admin_menu.html.slim
@@ -1,7 +1,7 @@
 hr
 h5.mt-4 Admin Menu
 ul.text
-  li = link_to 'Clear question text (in case of explicit text)', clear_question_request_for_comment_path(id: @request_for_comment.id), method: :post if policy(@request_for_comment).clear_question?
+  li = button_to('Clear question text (in case of explicit text)', clear_question_request_for_comment_path(id: @request_for_comment.id), method: :post, class: 'btn btn-sm btn-link') if policy(@request_for_comment).clear_question?
   li = link_to "User's current status of this exercise", statistics_external_user_exercise_path(id: @request_for_comment.exercise_id, external_user_id: @request_for_comment.user_id) if policy(@request_for_comment.exercise).statistics?
   li = link_to 'All exercises of this user', statistics_external_user_path(id: @request_for_comment.user_id) if policy(@request_for_comment.user).statistics?
 ul.text
diff --git a/app/views/study_groups/_table.html.slim b/app/views/study_groups/_table.html.slim
@@ -17,4 +17,4 @@
           td = group.study_group_memberships.size
           td = link_to(t('shared.show'), group) if policy(group).show?
           td = link_to(t('shared.edit'), edit_study_group_path(group)) if policy(group).edit?
-          td = link_to(t('shared.destroy'), group, data: {confirm: t('shared.confirm_destroy')}, method: :delete) if policy(group).destroy?
+          td = button_to(t('shared.destroy'), group, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'btn btn-sm btn-link') if policy(group).destroy?
diff --git a/app/views/tags/index.html.slim b/app/views/tags/index.html.slim
diff --git a/app/views/tips/index.html.slim b/app/views/tips/index.html.slim
diff --git a/app/views/webauthn_credential_authentication/_form.html.slim b/app/views/webauthn_credential_authentication/_form.html.slim
diff --git a/app/views/webauthn_credentials/_list.html.slim b/app/views/webauthn_credentials/_list.html.slim
