Skip to content

Commit 1d230cc

Browse files
committed
chore: Files feedback_message without NULL state
Column type string should not have a null state to avoid logical distinction between NULL and '' case. User defined tests are created without feedback_message but render a possible feedback_message. Removing the NULL case allows new records render the empty feedback_message. An edgecase remains when a test for assessment with a feedback_message is transformed to a user defined test. The feedback message will be displayed. Resolves #3014
1 parent fb06892 commit 1d230cc

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# frozen_string_literal: true
2+
3+
class RemoveNullFromFilesFeedbackMessage < ActiveRecord::Migration[8.0]
4+
def up
5+
execute <<~SQL
6+
UPDATE files SET feedback_message = '' WHERE feedback_message IS NULL;
7+
SQL
8+
9+
change_column_default :files, :feedback_message, ''
10+
change_column_null :files, :feedback_message, false
11+
end
12+
13+
def down
14+
change_column_null :files, :feedback_message, true
15+
change_column_default :files, :feedback_message, nil
16+
end
17+
end

db/schema.rb

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)