Skip to content

Commit 22a6665

Browse files
committed
Prevent duplicate listing of users for respective scope
The `group(:id)` is faster than `distinct`.
1 parent c502d25 commit 22a6665

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

app/policies/external_user_policy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def resolve
2525
@scope.joins(:study_group_memberships)
2626
.where(study_group_memberships: {
2727
study_group_id: @user.study_group_ids_as_teacher,
28-
})
28+
}).group(:id)
2929
else
3030
@scope.none
3131
end

app/policies/internal_user_policy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def resolve
2121
@scope.joins(:study_group_memberships)
2222
.where(study_group_memberships: {
2323
study_group_id: @user.study_group_ids_as_teacher,
24-
})
24+
}).group(:id)
2525
else
2626
@scope.none
2727
end

app/policies/programming_group_policy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def resolve
3232
@scope.joins(:submissions)
3333
.where(submissions: {
3434
study_group_id: @user.study_group_ids_as_teacher,
35-
}).distinct
35+
}).group(:id)
3636
else
3737
@scope.none
3838
end

0 commit comments

Comments
 (0)