Skip to content

Commit 28d4ce0

Browse files
committed
Fix determination of passed test files in case of syntax errors
Previously, when a testfile couldn't be run, the file could still be deemed as `passed`, since the wrong binary operator was used. Fixes #2760
1 parent 2bcc898 commit 28d4ce0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/models/submission.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def run_file(action, file, runner, waiting_duration)
284284
def score_file(output, file, requesting_user)
285285
assessor = Assessor.new(execution_environment:)
286286
assessment = assessor.assess(output)
287-
passed = (assessment[:passed] == assessment[:count]) and assessment[:score].positive?
287+
passed = (assessment[:passed] == assessment[:count]) && assessment[:score].positive?
288288
testrun_output = passed ? nil : "status: #{output[:status]}\n stdout: #{output[:stdout]}\n stderr: #{output[:stderr]}"
289289
if testrun_output.present?
290290
execution_environment.error_templates.each do |template|

0 commit comments

Comments
 (0)