Lint: Use parentheses for method calls in views

MrSerth · MrSerth · commit 2aff835908cf · 2025-07-09T13:11:19.000+02:00
This commit adds parentheses for various method calls in Slim:

- render
- button_tag
- button_to
- link_to
- link_to_if
diff --git a/app/views/codeharbor_links/_form.html.slim b/app/views/codeharbor_links/_form.html.slim
@@ -11,7 +11,7 @@
     .input-group
       = f.text_field(:api_key, data: {'bs-toggle': 'tooltip', 'bs-placement': 'bottom'}, title: t('codeharbor_link.info.api_key'), class: 'form-control api_key')
       .input-group-btn
-        = button_tag t('codeharbor_link.generate'), type: 'button', class: 'generate-api_key btn btn-default'
+        = button_tag(t('codeharbor_link.generate'), type: 'button', class: 'generate-api_key btn btn-default')
   .actions
     = render('shared/submit_button', f:, object: @codeharbor_link)
     - if @codeharbor_link.persisted?
diff --git a/app/views/community_solutions/edit.html.slim b/app/views/community_solutions/edit.html.slim
@@ -1 +1 @@
-== render 'form'
+== render('form')
diff --git a/app/views/community_solutions/index.html.slim b/app/views/community_solutions/index.html.slim
@@ -11,6 +11,6 @@ h1 = CommunitySolution.model_name.human(count: :other)
       - @community_solutions.each do |community_solution|
         tr
           td = community_solution.exercise.title
-          td = link_to 'Edit', edit_community_solution_path(community_solution)
+          td = link_to('Edit', edit_community_solution_path(community_solution))
 
 = render('shared/pagination', collection: @community_solutions)
diff --git a/app/views/execution_environments/statistics.html.slim b/app/views/execution_environments/statistics.html.slim
@@ -21,7 +21,7 @@ h1 = @execution_environment
         - if wts then average_time = wts['average_time'] else 0 # rubocop:disable Lint/ElseLayout
         - if wts then stddev_time = wts['stddev_time'] else 0 # rubocop:disable Lint/ElseLayout
         tr
-          td = link_to_if policy(exercise).statistics?, exercise.title, controller: 'exercises', action: 'statistics', id: exercise.id, 'data-turbo': 'false'
+          td = link_to_if(policy(exercise).statistics?, exercise.title, controller: 'exercises', action: 'statistics', id: exercise.id, 'data-turbo': 'false')
           td = us['contributors']
           td = us['average_score'].to_f.round(4)
           td = us['maximum_score'].to_f.round(2)
diff --git a/app/views/exercise_collections/_form.html.slim b/app/views/exercise_collections/_form.html.slim
@@ -35,7 +35,7 @@
 
   .actions = render('shared/submit_button', f:, object: @exercise_collection)
 
-= render 'shared/modal',
+= render('shared/modal',
         title: t('.add_exercises'),
         modal_root_attributes: {id: 'add-exercise-modal'},
-        template: 'exercise_collections/_add_exercise_modal'
+        template: 'exercise_collections/_add_exercise_modal')
diff --git a/app/views/exercises/_code_field.html.slim b/app/views/exercises/_code_field.html.slim
@@ -1,7 +1,7 @@
 .mb-3
   = form.label(attribute, class: 'form-label')
   = form.text_area(attribute, class: 'code-field form-control', rows: 16, style: 'display:none;')
-  = render partial: 'editor_edit', locals: {exercise: @exercise}
+  = render(partial: 'editor_edit', locals: {exercise: @exercise})
   .card.border-warning.p-2.my-2
     = form.file_field(attribute, class: 'form-control', style: 'display: inline-block;')
     .help-block.form-text = t('exercises.file_form.hints.upload')
diff --git a/app/views/exercises/_editor.html.slim b/app/views/exercises/_editor.html.slim
@@ -64,19 +64,19 @@
     .output-col-collapsed#output_sidebar = render('exercises/editor_output')
 
 - unless @embed_options[:disable_rfc]
-  = render 'shared/modal',
+  = render('shared/modal',
           title: t('exercises.implement.comment.request'),
           modal_root_attributes: {id: 'comment-modal'},
-          template: 'exercises/_request_comment_dialogcontent'
+          template: 'exercises/_request_comment_dialogcontent')
 
 - unless @embed_options[:disable_interventions]
-  = render 'shared/modal',
+  = render('shared/modal',
           title: t('exercises.implement.break_intervention.title'),
           modal_root_attributes: {id: 'break-intervention-modal'},
-          template: 'interventions/_break_intervention_modal'
+          template: 'interventions/_break_intervention_modal')
 
 - unless @embed_options[:disable_hints] || @tips.blank?
-  = render 'shared/modal',
+  = render('shared/modal',
           title: t('exercises.implement.tips.heading'),
           modal_root_attributes: {id: 'tips-intervention-modal'},
-          template: 'interventions/_tips_intervention_modal'
+          template: 'interventions/_tips_intervention_modal')
diff --git a/app/views/exercises/_editor_file_tree.html.slim b/app/views/exercises/_editor_file_tree.html.slim
@@ -30,7 +30,7 @@
       = render(partial: 'tips_content')
 
 - if @exercise.allow_file_creation?
-  = render 'shared/modal',
+  = render('shared/modal',
           title: t('exercises.editor.create_file'),
           modal_root_attributes: {id: 'modal-file'},
-          template: 'code_ocean/files/_form'
+          template: 'code_ocean/files/_form')
diff --git a/app/views/exercises/_export_actions.html.slim b/app/views/exercises/_export_actions.html.slim
@@ -1,12 +1,12 @@
 - if error
-  = button_tag type: 'button', class: 'btn btn-primary float-end export-button export-retry-button', data: {exercise_id: exercise.id} do
+  = button_tag(type: 'button', class: 'btn btn-primary float-end export-button export-retry-button', data: {exercise_id: exercise.id}) do
     i.fa-solid.fa-arrows-rotate.confirm-icon
     = t('exercises.export_codeharbor.buttons.retry')
 - elsif !exported && (!uuid_found || update_right)
-  = button_tag type: 'button', class: 'btn btn-primary float-end export-action export-button', data: {exercise_id: exercise.id} do
+  = button_tag(type: 'button', class: 'btn btn-primary float-end export-action export-button', data: {exercise_id: exercise.id}) do
     i.fa-solid.fa-check.confirm-icon
     = t('exercises.export_codeharbor.buttons.export')
 
-= button_tag type: 'submit', class: 'btn btn-secondary float-end export-button', data: {bs_dismiss: 'modal'} do
+= button_tag(type: 'submit', class: 'btn btn-secondary float-end export-button', data: {bs_dismiss: 'modal'}) do
   i.fa-solid.fa-xmark.abort-icon
   = exported ? t('shared.close') : t('exercises.export_codeharbor.buttons.abort')
diff --git a/app/views/exercises/_form.html.slim b/app/views/exercises/_form.html.slim
@@ -104,7 +104,7 @@
 
   .actions = render('shared/submit_button', f:, object: @exercise)
 
-= render 'shared/modal',
+= render('shared/modal',
         title: t('.add_tips'),
         modal_root_attributes: {id: 'add-tips-modal'},
-        template: 'exercises/_add_tip_modal'
+        template: 'exercises/_add_tip_modal')
diff --git a/app/views/exercises/_import_actions.html.slim b/app/views/exercises/_import_actions.html.slim
@@ -1,14 +1,14 @@
 - if imported
-  = link_to t('exercises.import_proforma.button.show_exercise'), exercise, class: 'btn btn-light btn-sm float-end show-action import-export-button', target: '_blank', rel: 'noopener noreferrer'
+  = link_to(t('exercises.import_proforma.button.show_exercise'), exercise, class: 'btn btn-light btn-sm float-end show-action import-export-button', target: '_blank', rel: 'noopener noreferrer')
 - elsif exists && updatable
-  = button_tag type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'import', 'file-id' => file_id} do
+  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'import', 'file-id' => file_id}) do
     i.fa-solid.fa-check.confirm-icon.export-button-icon
     = t('exercises.import_proforma.button.overwrite')
 - elsif exists
-  = button_tag type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'create_new', 'file-id' => file_id} do
+  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'create_new', 'file-id' => file_id}) do
     i.fa-solid.fa-check.confirm-icon-alt.export-button-icon
     = t('exercises.import_proforma.button.import_copy')
 - else
-  = button_tag type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'import', 'file-id' => file_id} do
+  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'import', 'file-id' => file_id}) do
     i.fa-solid.fa-check.confirm-icon.export-button-icon
     = t('exercises.import_proforma.button.import')
diff --git a/app/views/exercises/external_users/statistics.html.slim b/app/views/exercises/external_users/statistics.html.slim
@@ -43,12 +43,12 @@ h1
         span.ps-1.pb-1
           i.fa-solid.fa-circle-info.align-middle
           small.me-5.ms-1 = t('.toggle_status_on')
-        = link_to t('.toggle_autosave_off'), statistics_external_user_exercise_path(show_autosaves: false), class: 'btn btn-outline-contrast float-end btn-sm'
+        = link_to(t('.toggle_autosave_off'), statistics_external_user_exercise_path(show_autosaves: false), class: 'btn btn-outline-contrast float-end btn-sm')
       - else
         span.ps-1.pb-1
           i.fa-solid.fa-circle-info.align-middle
           small.me-5.ms-1 = t('.toggle_status_off')
-        = link_to t('.toggle_autosave_on'), statistics_external_user_exercise_path(show_autosaves: true), class: 'btn btn-outline-contrast float-end btn-sm'
+        = link_to(t('.toggle_autosave_on'), statistics_external_user_exercise_path(show_autosaves: true), class: 'btn btn-outline-contrast float-end btn-sm')
   #timeline
     .table-responsive
       table.table
diff --git a/app/views/exercises/implement.html.slim b/app/views/exercises/implement.html.slim
@@ -39,8 +39,8 @@
 
 
   = render('editor', exercise: @exercise, files: @files, submission: @submission)
-  = render 'shared/modal',
+  = render('shared/modal',
           title: t('programming_groups.new.pair_programming_info'),
           size: 'modal-lg',
           modal_root_attributes: {id: 'modal-info-pair-programming'},
-          template: 'programming_groups/_info_pair_programming'
+          template: 'programming_groups/_info_pair_programming')
diff --git a/app/views/exercises/index.html.slim b/app/views/exercises/index.html.slim
@@ -64,6 +64,6 @@ p
       i.fa-solid.fa-upload
       = t('exercises.import_proforma.label')
 
-= render 'shared/modal',
+= render('shared/modal',
         modal_root_attributes: {id: 'transfer-modal'},
-        template: 'exercises/_transfer_dialogcontent'
+        template: 'exercises/_transfer_dialogcontent')
diff --git a/app/views/exercises/show.html.slim b/app/views/exercises/show.html.slim
@@ -63,7 +63,7 @@ ul.list-unstyled#files
           = render('shared/file', file:)
 
 - if policy(@exercise).export_external_confirm?
-  = render 'shared/modal',
+  = render('shared/modal',
           title: t('exercises.export_codeharbor.dialogtitle'),
           modal_root_attributes: {id: 'transfer-modal'},
-          template: 'exercises/_transfer_dialogcontent'
+          template: 'exercises/_transfer_dialogcontent')
diff --git a/app/views/exercises/statistics.html.slim b/app/views/exercises/statistics.html.slim
@@ -77,7 +77,7 @@ h1 = @exercise
         tbody
           - user_with_submission_stats.each do |contributor, submission_stat|
             tr
-              td = link_to_if user_type == ExternalUser && policy(contributor).statistics?, contributor.displayname, statistics_external_user_exercise_path(contributor, @exercise)
+              td = link_to_if(user_type == ExternalUser && policy(contributor).statistics?, contributor.displayname, statistics_external_user_exercise_path(contributor, @exercise))
               td = submission_stat['maximum_score'] || '0.0'
               td.align-middle
                 - if submission_stat.created_at.present?
diff --git a/app/views/external_users/show.html.slim b/app/views/external_users/show.html.slim
@@ -33,7 +33,7 @@ h1 = @user.displayname
 
 - if @user == current_user || current_user.admin?
   = row(label: 'codeharbor_link.profile_label', value: @user.codeharbor_link.nil? ? link_to(t('codeharbor_link.new'), polymorphic_path([@user, CodeharborLink], action: :new), class: 'btn btn-secondary') : link_to(t('codeharbor_link.edit'), polymorphic_path([@user, @user.codeharbor_link], action: :edit), class: 'btn btn-secondary')) if policy(CodeharborLink).enabled?
-  = render 'webauthn_credentials/list'
+  = render('webauthn_credentials/list')
 
 h4.mt-4 = link_to(t('.exercise_statistics'), statistics_external_user_path(@user)) if policy(@user).statistics?
 
diff --git a/app/views/external_users/statistics.html.slim b/app/views/external_users/statistics.html.slim
@@ -13,7 +13,7 @@ h1 = t('.title', user: @user.displayname)
       tbody
         - statistics.each do |exercise, submission_stat|
           tr
-            td = link_to exercise, statistics_external_user_exercise_path(@user, exercise)
+            td = link_to(exercise, statistics_external_user_exercise_path(@user, exercise))
             td = submission_stat['maximum_score'] || 0.0
             td.align-middle
               - if submission_stat.created_at.present?
diff --git a/app/views/internal_users/show.html.slim b/app/views/internal_users/show.html.slim
@@ -31,4 +31,4 @@ h1
 - if @user == current_user || current_user.admin?
   = row(label: 'codeharbor_link.profile_label', value: @user.codeharbor_link.nil? ? link_to(t('codeharbor_link.new'), polymorphic_path([@user, CodeharborLink], action: :new), class: 'btn btn-secondary') : link_to(t('codeharbor_link.edit'), polymorphic_path([@user, @user.codeharbor_link], action: :edit), class: 'btn btn-secondary')) if policy(CodeharborLink).enabled?
   = row(label: 'internal_user.password', value: link_to(t('.change_password'), change_password_internal_user_path(@user), class: 'btn btn-secondary'))
-  = render 'webauthn_credentials/list'
+  = render('webauthn_credentials/list')
diff --git a/app/views/layouts/application.html.slim b/app/views/layouts/application.html.slim
@@ -53,9 +53,9 @@ html lang=I18n.locale data-default-locale=I18n.default_locale
         = yield
 
     - template_variables = {execution_environment: @exercise.execution_environment} if action_name == 'implement'
-    = render 'shared/modal',
+    = render('shared/modal',
             title: t('shared.help.headline'),
             size: 'modal-lg',
             modal_root_attributes: {id: 'modal-help'},
             template: 'application/help',
-            template_variables:
+            template_variables:)
diff --git a/app/views/programming_groups/new.html.slim b/app/views/programming_groups/new.html.slim
@@ -37,8 +37,8 @@ h1.d-inline-block = t('programming_groups.new.create_programming_pair')
         h5 = t('programming_groups.new.work_alone')
         == t('programming_groups.new.work_alone_description', path: implement_exercise_path(@exercise))
 
-= render 'shared/modal',
+= render('shared/modal',
         title: t('programming_groups.new.pair_programming_info'),
         size: 'modal-lg',
         modal_root_attributes: {id: 'modal-info-pair-programming'},
-        template: 'programming_groups/_info_pair_programming'
+        template: 'programming_groups/_info_pair_programming')
diff --git a/app/views/request_for_comments/_admin_menu.html.slim b/app/views/request_for_comments/_admin_menu.html.slim
@@ -2,8 +2,8 @@ hr
 h5.mt-4 Admin Menu
 ul.text
   li = button_to('Clear question text (in case of explicit text)', clear_question_request_for_comment_path(id: @request_for_comment.id), method: :post, class: 'btn btn-sm btn-link') if policy(@request_for_comment).clear_question?
-  li = link_to "User's current status of this exercise", statistics_external_user_exercise_path(id: @request_for_comment.exercise_id, external_user_id: @request_for_comment.user_id) if policy(@request_for_comment.exercise).statistics?
-  li = link_to 'All exercises of this user', statistics_external_user_path(id: @request_for_comment.user_id) if policy(@request_for_comment.user).statistics?
+  li = link_to("User's current status of this exercise", statistics_external_user_exercise_path(id: @request_for_comment.exercise_id, external_user_id: @request_for_comment.user_id)) if policy(@request_for_comment.exercise).statistics?
+  li = link_to('All exercises of this user', statistics_external_user_path(id: @request_for_comment.user_id)) if policy(@request_for_comment.user).statistics?
 ul.text
-  li = link_to 'Implement the exercise yourself', implement_exercise_path(id: @request_for_comment.exercise_id) if policy(@request_for_comment.exercise).implement?
-  li = link_to 'Show the exercise', exercise_path(id: @request_for_comment.exercise_id) if policy(@request_for_comment.exercise).show?
+  li = link_to('Implement the exercise yourself', implement_exercise_path(id: @request_for_comment.exercise_id)) if policy(@request_for_comment.exercise).implement?
+  li = link_to('Show the exercise', exercise_path(id: @request_for_comment.exercise_id)) if policy(@request_for_comment.exercise).show?
diff --git a/app/views/request_for_comments/_report.html.slim b/app/views/request_for_comments/_report.html.slim
@@ -1,7 +1,7 @@
 /# locals: (request_for_comment:)
 
 - if policy(request_for_comment).report?
-  = button_to t('.report'), report_request_for_comment_path(request_for_comment),
+  = button_to(t('.report'), report_request_for_comment_path(request_for_comment),
       data: {confirm: t('.confirm')},
       class: 'btn btn-light btn-sm',
-      form: {class: 'd-inline float-end'}
+      form: {class: 'd-inline float-end'})
diff --git a/app/views/request_for_comments/show.html.slim b/app/views/request_for_comments/show.html.slim
@@ -90,7 +90,7 @@
   #commentitor.editor data-file-id=file.id data-mode=file.file_type.editor_mode data-read-only='true'
     = file.content
 
-= render 'shared/modal',
+= render('shared/modal',
         title: t('exercises.implement.comment.dialogtitle'),
         modal_root_attributes: {id: 'comment-modal'},
-        template: 'exercises/_comment_dialogcontent'
+        template: 'exercises/_comment_dialogcontent')
