Specs: Wait for successful login before navigation

Without this change, the new path might be visited before the login succeeded. This causes authorization issues, where another login screen was shown.

Author: MrSerth

spec/system/editor_system_spec.rb

@@ -30,6 +30,7 @@
     fill_in('email', with: contributor.email)
     fill_in('password', with: attributes_for(:teacher)[:password])
     click_button(I18n.t('sessions.new.link'))
+    has_content?(I18n.t('sessions.create.success'))
     allow_any_instance_of(LtiHelper).to receive(:lti_outcome_service?).and_return(true)
     visit(implement_exercise_path(exercise))
   end

spec/system/external_user_statistics_system_spec.rb

@@ -22,12 +22,12 @@
     fill_in('email', with: user.email)
     fill_in('password', with: password)
     click_button(I18n.t('sessions.new.link'))
-    wait_for_ajax
+    has_content?(I18n.t('sessions.create.success'))
     allow_any_instance_of(LtiHelper).to receive(:lti_outcome_service?).and_return(true)
     visit(statistics_external_user_exercise_path(id: exercise.id, external_user_id: learner.id))
   end
 
-  context 'when a admin accesses the page' do
+  context 'when an admin accesses the page' do
     let(:user) { create(:admin, password:) }
 
     it 'does display the option to enable autosaves' do

spec/system/request_for_comments_filter_system_spec.rb

@@ -10,6 +10,7 @@
     fill_in('email', with: user.email)
     fill_in('password', with: attributes_for(:teacher)[:password])
     click_button(I18n.t('sessions.new.link'))
+    has_content?(I18n.t('sessions.create.success'))
   end
 
   it 'does not contain rfcs for unpublished exercises' do