request test setup

Author: arkirchner

app/controllers/application_controller.rb

@@ -1,8 +1,13 @@
 # frozen_string_literal: true
 
 class ApplicationController < ActionController::Base
+  # around_action do |_controller, block|
+  #   binding.irb
+  #   block.call
+  # end
+
   # Only allow modern browsers supporting webp images, web push, badges, import maps, CSS nesting, and CSS :has.
-  # allow_browser versions: :modern
+  allow_browser versions: :modern
 
   include ApplicationHelper
   include I18nHelper

app/controllers/test_sessions_controller.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+# Helper to sign in users in request tests.
+class TestSessionsController < ApplicationController
+  skip_after_action :verify_authorized
+  skip_before_action :require_fully_authenticated_user!
+
+  def create
+    raise 'test authorisation called outside of test environment' unless Rails.env.test?
+
+    user = params[:user_class].constantize.find(params[:user_id])
+    auto_login(user)
+    head :ok
+  end
+end

config/routes.rb

@@ -199,4 +199,8 @@
 
   # Defines the root path route ("/")
   root to: 'application#welcome'
+
+  if Rails.env.test?
+    post '/test_login', to: 'test_sessions#create'
+  end
 end

spec/request/request_for_comments_spec.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'POST /request_for_comments/:rfc_id/report', type: :request do
+  it 'sends an email to let admins know about the report' do
+    login_as(create(:learner))
+    rfc = create(:rfc)
+
+    expect { post(report_request_for_comment_path(rfc, session: {foo: 'bar'})) }
+      .to have_enqueued_mail(ReportMailer, :report_content)
+      .with(params: {reported_content: rfc}, args: [])
+  end
+end

spec/support/authentication.rb

@@ -6,6 +6,13 @@ def sign_in(user, password)
   end
 end
 
+module RequestLoginHelper
+  def login_as(user)
+    post '/test_login', params: {user_id: user.id, user_class: user.class.name}
+  end
+end
+
 RSpec.configure do |config|
   config.include Authentication, type: :system
+  config.include RequestLoginHelper, type: :request
 end

spec/system/request_for_comments_filter_system_spec.rb

@@ -42,13 +42,10 @@
     request_for_comment = create(:rfc)
     visit(request_for_comment_path(request_for_comment))
 
-    expect do
-      accept_confirm do
-        click_on I18n.t('request_for_comments.report.report')
-      end
-
-      expect(page).to have_text(I18n.t('request_for_comments.report.reported'))
-    end.to have_enqueued_mail(ReportMailer, :report_content)
-      .with(params: {reported_content: request_for_comment}, args: [])
+    accept_confirm do
+      click_on I18n.t('request_for_comments.report.report')
+    end
+
+    expect(page).to have_text(I18n.t('request_for_comments.report.reported'))
   end
 end