added various let statements

Author: arkirchner

spec/request/request_for_comments_spec.rb

@@ -3,19 +3,20 @@
 require 'rails_helper'
 
 RSpec.describe 'POST /request_for_comments/:rfc_id/report', type: :request do
+  let(:user) { create(:learner) }
+  let(:rfc) { create(:rfc) }
+  let(:report_emails) { ['[email protected]'] }
+
   before do
-    user = create(:learner)
     allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
     codeocean_config = instance_double(CodeOcean::Config)
     allow(CodeOcean::Config).to receive(:new).with(:code_ocean).and_return(codeocean_config)
     allow(codeocean_config).to receive(:read).and_return({
-      content_moderation: {report_emails: ['[email protected]']},
+      content_moderation: {report_emails:},
     })
   end
 
   it 'sends an email to let admins know about the report' do
-    rfc = create(:rfc)
-
     expect { post(report_request_for_comment_path(rfc)) }
       .to have_enqueued_mail(ReportMailer, :report_content)
       .with(params: {reported_content: rfc}, args: [])

spec/system/request_for_comments_filter_system_spec.rb

@@ -4,8 +4,15 @@
 
 RSpec.describe 'Request_for_Comments' do
   let(:user) { create(:teacher) }
+  let(:report_emails) { [] }
 
   before do
+    codeocean_config = instance_double(CodeOcean::Config)
+    allow(CodeOcean::Config).to receive(:new).with(:code_ocean).and_return(codeocean_config)
+    allow(codeocean_config).to receive(:read).and_return({
+      content_moderation: {report_emails:},
+    })
+
     visit(sign_in_path)
     fill_in('email', with: user.email)
     fill_in('password', with: attributes_for(:teacher)[:password])
@@ -38,20 +45,18 @@
     expect(page).to have_css('ul.pagination')
   end
 
-  it 'allows reporting of RfCs', :js do
-    codeocean_config = instance_double(CodeOcean::Config)
-    allow(CodeOcean::Config).to receive(:new).with(:code_ocean).and_return(codeocean_config)
-    allow(codeocean_config).to receive(:read).and_return({
-      content_moderation: {report_emails: ['[email protected]']},
-    })
+  context 'when reporting is enabled' do
+    let(:report_emails) { ['[email protected]'] }
 
-    request_for_comment = create(:rfc)
-    visit(request_for_comment_path(request_for_comment))
+    it 'allows reporting of RfCs', :js do
+      request_for_comment = create(:rfc)
+      visit(request_for_comment_path(request_for_comment))
 
-    accept_confirm do
-      click_on I18n.t('request_for_comments.report.report')
-    end
+      accept_confirm do
+        click_on I18n.t('request_for_comments.report.report')
+      end
 
-    expect(page).to have_text(I18n.t('request_for_comments.report.reported'))
+      expect(page).to have_text(I18n.t('request_for_comments.report.reported'))
+    end
   end
 end