Consider remote causes in all remaining places

Author: MrSerth

app/assets/javascripts/exercise_graphs.js

@@ -29,15 +29,15 @@ $(document).on('turbolinks:load', function() {
                 maximumValue = submission.score;
             }
 
-            if(submission.cause == "assess"){
+            if(submission.cause === "assess" || submission.cause === "remoteAssess"){
                 submissionsScoreAndTimeAssess.push(submissionArray);
-            } else if(submission.cause == "submit"){
+            } else if(submission.cause === "submit" || submission.cause === "remoteSubmit"){
                 submissionsScoreAndTimeSubmits.push(submissionArray);
-            } else if(submission.cause == "run"){
+            } else if(submission.cause === "run"){
                 submissionsScoreAndTimeRuns.push(submissionArray[1]);
-            } else if(submission.cause == "autosave"){
+            } else if(submission.cause === "autosave"){
                 submissionsAutosaves.push(submissionArray[1]);
-            }  else if(submission.cause == "save"){
+            }  else if(submission.cause === "save"){
                 submissionsSaves.push(submissionArray[1]);
             }
         }
@@ -120,10 +120,10 @@ $(document).on('turbolinks:load', function() {
             var largestSubmittedTimeStamp = submissions[submissions_length-1];
             var largestArrayForRange;
 
-            if(largestSubmittedTimeStamp.cause === "assess"){
+            if(largestSubmittedTimeStamp.cause === "assess" || largestSubmittedTimeStamp.cause === "remoteAssess"){
                 largestArrayForRange = submissionsScoreAndTimeAssess;
                 x.domain([0,largestArrayForRange[largestArrayForRange.length - 1][1]]).clamp(true);
-            } else if(largestSubmittedTimeStamp.cause === "submit"){
+            } else if(largestSubmittedTimeStamp.cause === "submit" || largestSubmittedTimeStamp.cause === "remoteSubmit"){
                 largestArrayForRange = submissionsScoreAndTimeSubmits;
                 x.domain([0,largestArrayForRange[largestArrayForRange.length - 1][1]]).clamp(true);
             } else if(largestSubmittedTimeStamp.cause === "run"){

app/models/exercise.rb

@@ -52,7 +52,7 @@ class Exercise < ApplicationRecord
   MAX_GROUP_EXERCISE_FEEDBACKS = 20
 
   def average_percentage(base = submissions)
-    if average_score(base) && (maximum_score.to_d != BigDecimal('0.0')) && base.exists?(cause: 'submit')
+    if average_score(base) && (maximum_score.to_d != BigDecimal('0.0')) && base.exists?(cause: %w[submit assess remoteSubmit remoteAssess])
       (average_score(base) / maximum_score * 100).round(2)
     else
       0
@@ -84,7 +84,7 @@ def contributors
 
   def time_maximum_score(contributor)
     submissions
-      .where(contributor:, cause: %w[submit assess])
+      .where(contributor:, cause: %w[submit assess remoteSubmit remoteAssess])
       .where.not(score: nil)
       .order(score: :desc, created_at: :asc)
       .first&.created_at || Time.zone.at(0)
@@ -528,7 +528,7 @@ def generate_token
   def maximum_score(contributor = nil)
     if contributor
       submissions
-        .where(contributor:, cause: %w[submit assess])
+        .where(contributor:, cause: %w[submit assess remoteSubmit remoteAssess])
         .where.not(score: nil)
         .order(score: :desc)
         .first&.score || 0

app/models/proxy_exercise.rb

@@ -78,7 +78,7 @@ def get_matching_exercise(user)
   end
 
   def find_matching_exercise(user)
-    exercises_user_has_accessed = user.submissions.where("cause IN ('submit','assess')").map(&:exercise).uniq.compact
+    exercises_user_has_accessed = user.submissions.where(cause: %w[submit assess remoteSubmit remoteAssess]).map(&:exercise).uniq.compact
     tags_user_has_seen = exercises_user_has_accessed.map(&:tags).uniq.flatten
     Rails.logger.debug { "exercises_user_has_accessed #{exercises_user_has_accessed.map(&:id).join(',')}" }
 

app/models/submission.rb

@@ -32,7 +32,7 @@ class Submission < ApplicationRecord
   delegate :execution_environment, to: :exercise
 
   scope :final, -> { where(cause: %w[submit remoteSubmit]) }
-  scope :intermediate, -> { where.not(cause: 'submit') }
+  scope :intermediate, -> { where.not(cause: %w[submit remoteSubmit]) }
 
   scope :before_deadline, lambda {
                             joins(:exercise).where('submissions.updated_at <= exercises.submission_deadline OR exercises.submission_deadline IS NULL')