Fix Rubocop offenses

Author: MrSerth

app/controllers/exercises_controller.rb

@@ -69,7 +69,7 @@ def clone
   def collect_paths(files)
     unique_paths = files.map(&:path).compact_blank.uniq
     subpaths = unique_paths.map do |path|
-      Array.new((path.split('/').length + 1)) do |n|
+      Array.new(path.split('/').length + 1) do |n|
         path.split('/').shift(n).join('/')
       end
     end

spec/controllers/request_for_comments_controller_spec.rb

@@ -82,7 +82,7 @@
       expect(assigns(:request_for_comments)).to eq([rfc_within_my_study_group])
     end
 
-    include_examples 'RfC visibility settings'
+    it_behaves_like 'RfC visibility settings'
   end
 
   describe 'GET #my_comment_requests' do
@@ -91,7 +91,7 @@
     expect_http_status(:ok)
     expect_template(:index)
 
-    include_examples 'RfC visibility settings'
+    it_behaves_like 'RfC visibility settings'
   end
 
   describe 'GET #rfcs_with_my_comments' do
@@ -100,7 +100,7 @@
     expect_http_status(:ok)
     expect_template(:index)
 
-    include_examples 'RfC visibility settings'
+    it_behaves_like 'RfC visibility settings'
   end
 
   describe 'GET #rfcs_for_exercise' do

spec/lib/runner/strategy/docker_container_pool_spec.rb

@@ -63,7 +63,7 @@
       end
     end
 
-    include_examples 'Faraday error handling', :post
+    it_behaves_like 'Faraday error handling', :post
   end
 
   describe '#destroy_at_management' do
@@ -81,7 +81,7 @@
       expect(destroy_runner_stub).to have_been_requested.once
     end
 
-    include_examples 'Faraday error handling', :delete
+    it_behaves_like 'Faraday error handling', :delete
   end
 
   describe '#copy_files' do

spec/lib/runner/strategy/poseidon_spec.rb

@@ -82,14 +82,14 @@
       end
 
       context 'when error code is nomad overload' do
-        include_examples(
+        it_behaves_like(
           'InternalServerError (500) with error code',
           described_class.error_nomad_overload, Runner::Error::NotAvailable
         )
       end
 
       context 'when error code is not nomad overload' do
-        include_examples(
+        it_behaves_like(
           'InternalServerError (500) with error code',
           described_class.error_unknown, Runner::Error::InternalServerError
         )
@@ -189,11 +189,11 @@
     end
 
     [201, 204].each do |status|
-      include_examples 'returns true when the api request was successful', status
+      it_behaves_like 'returns true when the api request was successful', status
     end
 
     [400, 500].each do |status|
-      include_examples 'returns false when the api request failed', status
+      it_behaves_like 'returns false when the api request failed', status
     end
 
     it 'raises an exception if Faraday raises an error' do
@@ -252,8 +252,8 @@
       end
     end
 
-    include_examples 'BadRequest (400) error handling'
-    include_examples 'Unauthorized (401) error handling'
+    it_behaves_like 'BadRequest (400) error handling'
+    it_behaves_like 'Unauthorized (401) error handling'
 
     context 'when Poseidon returns NotFound (404)' do
       let(:response_status) { 404 }
@@ -263,9 +263,9 @@
       end
     end
 
-    include_examples 'InternalServerError (500) error handling'
-    include_examples 'unknown response status error handling'
-    include_examples 'Faraday error handling'
+    it_behaves_like 'InternalServerError (500) error handling'
+    it_behaves_like 'unknown response status error handling'
+    it_behaves_like 'Faraday error handling'
   end
 
   describe '#execute_command' do
@@ -319,12 +319,12 @@
       end
     end
 
-    include_examples 'BadRequest (400) error handling'
-    include_examples 'Unauthorized (401) error handling'
-    include_examples 'Gone (410) error handling'
-    include_examples 'InternalServerError (500) error handling'
-    include_examples 'unknown response status error handling'
-    include_examples 'Faraday error handling'
+    it_behaves_like 'BadRequest (400) error handling'
+    it_behaves_like 'Unauthorized (401) error handling'
+    it_behaves_like 'Gone (410) error handling'
+    it_behaves_like 'InternalServerError (500) error handling'
+    it_behaves_like 'unknown response status error handling'
+    it_behaves_like 'Faraday error handling'
   end
 
   describe '#destroy_at_management' do
@@ -352,10 +352,10 @@
       end
     end
 
-    include_examples 'Unauthorized (401) error handling'
-    include_examples 'InternalServerError (500) error handling'
-    include_examples 'unknown response status error handling'
-    include_examples 'Faraday error handling'
+    it_behaves_like 'Unauthorized (401) error handling'
+    it_behaves_like 'InternalServerError (500) error handling'
+    it_behaves_like 'unknown response status error handling'
+    it_behaves_like 'Faraday error handling'
   end
 
   describe '#copy_files' do
@@ -382,13 +382,13 @@
       end
     end
 
-    include_examples 'BadRequest (400) error handling'
-    include_examples 'BadRequest (400) destroys local runner'
-    include_examples 'Unauthorized (401) error handling'
-    include_examples 'Gone (410) error handling'
-    include_examples 'InternalServerError (500) error handling'
-    include_examples 'unknown response status error handling'
-    include_examples 'Faraday error handling'
+    it_behaves_like 'BadRequest (400) error handling'
+    it_behaves_like 'BadRequest (400) destroys local runner'
+    it_behaves_like 'Unauthorized (401) error handling'
+    it_behaves_like 'Gone (410) error handling'
+    it_behaves_like 'InternalServerError (500) error handling'
+    it_behaves_like 'unknown response status error handling'
+    it_behaves_like 'Faraday error handling'
   end
 
   describe '#attach_to_execution' do

spec/policies/request_for_comment_policy_spec.rb

@@ -103,12 +103,12 @@
           let(:viewer_study_groups) { create_list(:study_group, 1, consumer: viewer_consumer) }
 
           permissions(:show?) do
-            include_examples 'grants access to everyone'
+            it_behaves_like 'grants access to everyone'
           end
 
           %i[mark_as_solved? set_thank_you_note?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -119,7 +119,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -130,7 +130,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -143,12 +143,12 @@
           let(:viewer_study_groups) { create_list(:study_group, 1, consumer: viewer_consumer) }
 
           permissions(:show?) do
-            include_examples 'grants access to everyone'
+            it_behaves_like 'grants access to everyone'
           end
 
           %i[mark_as_solved? set_thank_you_note?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -157,12 +157,12 @@
           let(:viewer_study_groups) { author_study_groups }
 
           permissions(:show?) do
-            include_examples 'grants access to everyone'
+            it_behaves_like 'grants access to everyone'
           end
 
           %i[mark_as_solved? set_thank_you_note?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -179,7 +179,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -190,7 +190,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -201,7 +201,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -214,12 +214,12 @@
           let(:viewer_study_groups) { create_list(:study_group, 1, consumer: viewer_consumer) }
 
           permissions(:show?) do
-            include_examples 'grants access to everyone'
+            it_behaves_like 'grants access to everyone'
           end
 
           %i[mark_as_solved? set_thank_you_note?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -228,12 +228,12 @@
           let(:viewer_study_groups) { author_study_groups }
 
           permissions(:show?) do
-            include_examples 'grants access to everyone'
+            it_behaves_like 'grants access to everyone'
           end
 
           %i[mark_as_solved? set_thank_you_note?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -250,7 +250,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -261,7 +261,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -272,7 +272,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -286,7 +286,7 @@
 
           %i[mark_as_solved? set_thank_you_note? show?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end
@@ -295,12 +295,12 @@
           let(:viewer_study_groups) { author_study_groups }
 
           permissions(:show?) do
-            include_examples 'grants access to everyone'
+            it_behaves_like 'grants access to everyone'
           end
 
           %i[mark_as_solved? set_thank_you_note?].each do |action|
             permissions(action) do
-              include_examples 'grants access to admins and authors only'
+              it_behaves_like 'grants access to admins and authors only'
             end
           end
         end