remove request test authorization helper

Author: arkirchner

spec/request/request_for_comments_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe 'POST /request_for_comments/:rfc_id/report', type: :request do
   before do
-    login_as(create(:learner))
+    allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
     codeocean_config = instance_double(CodeOcean::Config)
     allow(CodeOcean::Config).to receive(:new).with(:code_ocean).and_return(codeocean_config)
     allow(codeocean_config).to receive(:read).and_return({

spec/support/authentication.rb

@@ -6,13 +6,6 @@ def sign_in(user, password)
   end
 end
 
-module RequestLoginHelper
-  def login_as(user)
-    allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
-  end
-end
-
 RSpec.configure do |config|
   config.include Authentication, type: :system
-  config.include RequestLoginHelper, type: :request
 end