Fix Rubocop offenses

Author: MrSerth

app/controllers/exercises_controller.rb

@@ -547,7 +547,7 @@ def external_user_statistics
           # Hacky: If the autosave is the first element after a break, we need to set the delta of the following element to 0.
           # Since the @delta array is "broken" for filtered views anyway, we use this hack to get the red "highlight" line right.
           # TODO: Refactor the whole method into a more clean solution.
-          @deltas[index + 1] = 0 if (@deltas[index]).zero? && @deltas[index + 1].present?
+          @deltas[index + 1] = 0 if @deltas[index].zero? && @deltas[index + 1].present?
           @deltas.delete_at(index)
         end
       end

app/models/submission.rb

@@ -284,7 +284,7 @@ def run_file(action, file, runner, waiting_duration)
   def score_file(output, file, requesting_user)
     assessor = Assessor.new(execution_environment:)
     assessment = assessor.assess(output)
-    passed = (assessment[:passed] == assessment[:count]) and (assessment[:score]).positive?
+    passed = (assessment[:passed] == assessment[:count]) and assessment[:score].positive?
     testrun_output = passed ? nil : "status: #{output[:status]}\n stdout: #{output[:stdout]}\n stderr: #{output[:stderr]}"
     if testrun_output.present?
       execution_environment.error_templates.each do |template|

db/migrate/20210602071834_change_type_of_exposed_ports_in_execution_environment.rb

@@ -4,7 +4,7 @@ class ChangeTypeOfExposedPortsInExecutionEnvironment < ActiveRecord::Migration[6
   class ExecutionEnvironment < ApplicationRecord
   end
 
-  # rubocop:disable Rails/SkipsModelValidations:
+  # rubocop:disable Rails/SkipsModelValidations
   def up
     rename_column :execution_environments, :exposed_ports, :exposed_ports_migration
     add_column :execution_environments, :exposed_ports, :integer, array: true, default: [], nil: true
@@ -36,5 +36,5 @@ def down
     end
     remove_column :execution_environments, :exposed_ports_migration
   end
-  # rubocop:enable Rails/SkipsModelValidations:
+  # rubocop:enable Rails/SkipsModelValidations
 end

lib/runner/strategy/docker_container_pool.rb

@@ -104,12 +104,12 @@ def copy_files(files)
     Rails.logger.debug { "#{Time.zone.now.getutc.inspect}: Finished copying files" }
   end
 
-  def retrieve_files(path: './', recursive: true, privileged_execution: false) # rubocop:disable Lint/UnusedMethodArgument for the keyword argument
+  def retrieve_files(path: './', recursive: true, privileged_execution: false) # rubocop:disable Lint/UnusedMethodArgument -- for the keyword argument
     # The DockerContainerPool does not support retrieving files from the runner.
     {'files' => []}
   end
 
-  def attach_to_execution(command, event_loop, starting_time, privileged_execution: false) # rubocop:disable Lint/UnusedMethodArgument for the keyword argument
+  def attach_to_execution(command, event_loop, starting_time, privileged_execution: false) # rubocop:disable Lint/UnusedMethodArgument -- for the keyword argument
     reset_inactivity_timer
 
     @command = command

lib/runner/strategy/null.rb

@@ -27,11 +27,11 @@ def copy_files(_files); end
 
   def retrieve_files(path: './', recursive: true, privileged_execution: false); end
 
-  def download_file(_file, privileged_execution: false, &_block) # rubocop:disable Lint/UnusedMethodArgument for the keyword argument
+  def download_file(_file, privileged_execution: false, &_block) # rubocop:disable Lint/UnusedMethodArgument -- for the keyword argument
     raise Runner::Error.new
   end
 
-  def attach_to_execution(command, event_loop, starting_time, privileged_execution: false) # rubocop:disable Lint/UnusedMethodArgument for the keyword argument
+  def attach_to_execution(command, event_loop, starting_time, privileged_execution: false) # rubocop:disable Lint/UnusedMethodArgument -- for the keyword argument
     socket = Connection.new(nil, self, event_loop)
     # We don't want to return an error if the execution environment is changed
     socket.status = :terminated_by_codeocean if command == ExecutionEnvironment::VALIDATION_COMMAND

lib/tasks/detect_exercise_anomalies.rake

@@ -6,7 +6,7 @@ namespace :detect_exercise_anomalies do
   # logger.level     = Logger::DEBUG
   # Rails.logger     = logger
 
-  # rubocop:disable Lint/ConstantDefinitionInBlock Style/MutableConstant
+  # rubocop:disable Lint/ConstantDefinitionInBlock, Style/MutableConstant
   # These factors determine if an exercise is an anomaly, given the average working time (avg):
   # (avg * MIN_TIME_FACTOR) <= working_time <= (avg * MAX_TIME_FACTOR)
   MIN_TIME_FACTOR = 0.1
@@ -19,11 +19,9 @@ namespace :detect_exercise_anomalies do
   MIN_CONTRIBUTOR_WORKING_TIME = 0.0
 
   # Cache exercise working times, because queries are expensive and values do not change between collections
-  # rubocop:disable Style/MutableConstant
   WORKING_TIME_CACHE = {}
   AVERAGE_WORKING_TIME_CACHE = {}
-  # rubocop:enable Style/MutableConstant
-  # rubocop:enable Lint/ConstantDefinitionInBlock
+  # rubocop:enable Lint/ConstantDefinitionInBlock, Style/MutableConstant
 
   task :with_at_least, %i[number_of_exercises number_of_contributors] => :environment do |_task, args|
     include TimeHelper